Re: [U-Boot] [PATCH] powerpc: Drop unreferenced CONFIG_* defines
Hi Tuomas, On Sat, Jan 13, 2018 at 1:21 AM, Tuomas Tynkkynen wrote: > The following config symbols are only defined once and never referenced > anywhere else: > > CONFIG_CYRUS > CONFIG_IDS8313 > CONFIG_MPC8308_P1M > CONFIG_MPC8308RDB > CONFIG_MPC8349EMDS > CONFIG_MPC8349ITXGP > CONFIG_SBC8349 > CONFIG_SBC8548 > CONFIG_SBC8641D > CONFIG_TQM834X > CONFIG_VE8313 > CONFIG_XPEDITE5140 > CONFIG_XPEDITE5200 > CONFIG_XPEDITE550X > > Most of them are config symbols named after the respective boards which > seems to have been a standard practice at some point. > > Signed-off-by: Tuomas Tynkkynen > --- > board/freescale/mpc8349itx/README | 1 - > configs/MPC8349ITXGP_defconfig| 2 +- > include/configs/MPC8308RDB.h | 1 - > include/configs/MPC8349EMDS.h | 1 - > include/configs/TQM834x.h | 1 - > include/configs/cyrus.h | 2 -- > include/configs/ids8313.h | 1 - > include/configs/mpc8308_p1m.h | 1 - > include/configs/sbc8349.h | 1 - > include/configs/sbc8548.h | 1 - > include/configs/sbc8641d.h| 1 - > include/configs/ve8313.h | 1 - > include/configs/xpedite517x.h | 1 - > include/configs/xpedite520x.h | 1 - > include/configs/xpedite550x.h | 1 - > scripts/config_whitelist.txt | 14 -- > 16 files changed, 1 insertion(+), 30 deletions(-) > > diff --git a/board/freescale/mpc8349itx/README > b/board/freescale/mpc8349itx/README > index 48bbd50356..3012b83737 100644 > --- a/board/freescale/mpc8349itx/README > +++ b/board/freescale/mpc8349itx/README > @@ -91,7 +91,6 @@ Freescale MPC8349E-mITX and MPC8349E-mITX-GP Boards > CONFIG_MPC83xx MPC83xx family > CONFIG_MPC8349 MPC8349 specific > CONFIG_MPC8349ITX MPC8349E-mITX > - CONFIG_MPC8349ITXGP MPC8349E-mITX-GP > > 5. Compilation > > diff --git a/configs/MPC8349ITXGP_defconfig b/configs/MPC8349ITXGP_defconfig > index 319141de1b..97dc8e7a80 100644 > --- a/configs/MPC8349ITXGP_defconfig > +++ b/configs/MPC8349ITXGP_defconfig > @@ -3,7 +3,7 @@ CONFIG_MPC83xx=y > CONFIG_TARGET_MPC8349ITX=y > CONFIG_OF_BOARD_SETUP=y > CONFIG_OF_STDOUT_VIA_ALIAS=y > -CONFIG_SYS_EXTRA_OPTIONS="MPC8349ITXGP,SYS_TEXT_BASE=0xFE00" > +CONFIG_SYS_EXTRA_OPTIONS="SYS_TEXT_BASE=0xFE00" > CONFIG_BOOTDELAY=6 > CONFIG_USE_BOOTARGS=y > CONFIG_BOOTARGS="root=/dev/nfs rw nfsroot=:/nfsroot/rootfs > ip=mpc8349emitxgp:eth0:off console=ttyS0,115200" > diff --git a/include/configs/MPC8308RDB.h b/include/configs/MPC8308RDB.h > index bd0cb6fddc..d348ec9367 100644 > --- a/include/configs/MPC8308RDB.h > +++ b/include/configs/MPC8308RDB.h > @@ -15,7 +15,6 @@ > #define CONFIG_E3001 /* E300 family */ > #define CONFIG_MPC830x 1 /* MPC830x family */ > #define CONFIG_MPC8308 1 /* MPC8308 CPU specific */ > -#define CONFIG_MPC8308RDB 1 /* MPC8308RDB board specific */ > > #defineCONFIG_SYS_TEXT_BASE0xFE00 > > diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h > index 9b906a7c77..c7a5ee0aaf 100644 > --- a/include/configs/MPC8349EMDS.h > +++ b/include/configs/MPC8349EMDS.h > @@ -19,7 +19,6 @@ > #define CONFIG_E3001 /* E300 Family */ > #define CONFIG_MPC834x 1 /* MPC834x family */ > #define CONFIG_MPC8349 1 /* MPC8349 specific */ > -#define CONFIG_MPC8349EMDS 1 /* MPC8349EMDS board specific */ > > #defineCONFIG_SYS_TEXT_BASE0xFE00 > > diff --git a/include/configs/TQM834x.h b/include/configs/TQM834x.h > index 0c6bcae33c..9d27358031 100644 > --- a/include/configs/TQM834x.h > +++ b/include/configs/TQM834x.h > @@ -18,7 +18,6 @@ > #define CONFIG_E3001 /* E300 Family */ > #define CONFIG_MPC834x 1 /* MPC834x specific */ > #define CONFIG_MPC8349 1 /* MPC8349 specific */ > -#define CONFIG_TQM834X 1 /* TQM834X board specific */ > > #defineCONFIG_SYS_TEXT_BASE0x8000 > > diff --git a/include/configs/cyrus.h b/include/configs/cyrus.h > index e413b5158c..3da91e80c8 100644 > --- a/include/configs/cyrus.h > +++ b/include/configs/cyrus.h > @@ -7,8 +7,6 @@ > #ifndef __CONFIG_H > #define __CONFIG_H > > -#define CONFIG_CYRUS > - > #if !defined(CONFIG_ARCH_P5020) && !defined(CONFIG_ARCH_P5040) > #error Must call Cyrus CONFIG with a specific CPU enabled. > #endif > diff --git a/include/configs/ids8313.h b/include/configs/ids8313.h > index b43c8c711e..12eb07d1f7 100644 > --- a/include/configs/ids8313.h > +++ b/include/configs/ids8313.h > @@ -17,7 +17,6 @@ > */ > #define CONFIG_MPC831x > #define CONFIG_MPC8313 > -#define CONFIG_IDS8313 > > #define CONFIG_FSL_ELBC > > diff --git a/include/configs/mpc8308_p1m.h b/include/configs/mpc8308_p1m.h > index f97773146a..69c4309139 100644 > --- a/include/configs/mpc8308_p1m.h > +++ b/include/configs/mpc8308_p1m.h > @@ -15,7 +15,6 @@ > #define CONFIG_E300
[U-Boot] [PATCH] powerpc: Drop unreferenced CONFIG_* defines
The following config symbols are only defined once and never referenced anywhere else: CONFIG_CYRUS CONFIG_IDS8313 CONFIG_MPC8308_P1M CONFIG_MPC8308RDB CONFIG_MPC8349EMDS CONFIG_MPC8349ITXGP CONFIG_SBC8349 CONFIG_SBC8548 CONFIG_SBC8641D CONFIG_TQM834X CONFIG_VE8313 CONFIG_XPEDITE5140 CONFIG_XPEDITE5200 CONFIG_XPEDITE550X Most of them are config symbols named after the respective boards which seems to have been a standard practice at some point. Signed-off-by: Tuomas Tynkkynen --- board/freescale/mpc8349itx/README | 1 - configs/MPC8349ITXGP_defconfig| 2 +- include/configs/MPC8308RDB.h | 1 - include/configs/MPC8349EMDS.h | 1 - include/configs/TQM834x.h | 1 - include/configs/cyrus.h | 2 -- include/configs/ids8313.h | 1 - include/configs/mpc8308_p1m.h | 1 - include/configs/sbc8349.h | 1 - include/configs/sbc8548.h | 1 - include/configs/sbc8641d.h| 1 - include/configs/ve8313.h | 1 - include/configs/xpedite517x.h | 1 - include/configs/xpedite520x.h | 1 - include/configs/xpedite550x.h | 1 - scripts/config_whitelist.txt | 14 -- 16 files changed, 1 insertion(+), 30 deletions(-) diff --git a/board/freescale/mpc8349itx/README b/board/freescale/mpc8349itx/README index 48bbd50356..3012b83737 100644 --- a/board/freescale/mpc8349itx/README +++ b/board/freescale/mpc8349itx/README @@ -91,7 +91,6 @@ Freescale MPC8349E-mITX and MPC8349E-mITX-GP Boards CONFIG_MPC83xx MPC83xx family CONFIG_MPC8349 MPC8349 specific CONFIG_MPC8349ITX MPC8349E-mITX - CONFIG_MPC8349ITXGP MPC8349E-mITX-GP 5. Compilation diff --git a/configs/MPC8349ITXGP_defconfig b/configs/MPC8349ITXGP_defconfig index 319141de1b..97dc8e7a80 100644 --- a/configs/MPC8349ITXGP_defconfig +++ b/configs/MPC8349ITXGP_defconfig @@ -3,7 +3,7 @@ CONFIG_MPC83xx=y CONFIG_TARGET_MPC8349ITX=y CONFIG_OF_BOARD_SETUP=y CONFIG_OF_STDOUT_VIA_ALIAS=y -CONFIG_SYS_EXTRA_OPTIONS="MPC8349ITXGP,SYS_TEXT_BASE=0xFE00" +CONFIG_SYS_EXTRA_OPTIONS="SYS_TEXT_BASE=0xFE00" CONFIG_BOOTDELAY=6 CONFIG_USE_BOOTARGS=y CONFIG_BOOTARGS="root=/dev/nfs rw nfsroot=:/nfsroot/rootfs ip=mpc8349emitxgp:eth0:off console=ttyS0,115200" diff --git a/include/configs/MPC8308RDB.h b/include/configs/MPC8308RDB.h index bd0cb6fddc..d348ec9367 100644 --- a/include/configs/MPC8308RDB.h +++ b/include/configs/MPC8308RDB.h @@ -15,7 +15,6 @@ #define CONFIG_E3001 /* E300 family */ #define CONFIG_MPC830x 1 /* MPC830x family */ #define CONFIG_MPC8308 1 /* MPC8308 CPU specific */ -#define CONFIG_MPC8308RDB 1 /* MPC8308RDB board specific */ #defineCONFIG_SYS_TEXT_BASE0xFE00 diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h index 9b906a7c77..c7a5ee0aaf 100644 --- a/include/configs/MPC8349EMDS.h +++ b/include/configs/MPC8349EMDS.h @@ -19,7 +19,6 @@ #define CONFIG_E3001 /* E300 Family */ #define CONFIG_MPC834x 1 /* MPC834x family */ #define CONFIG_MPC8349 1 /* MPC8349 specific */ -#define CONFIG_MPC8349EMDS 1 /* MPC8349EMDS board specific */ #defineCONFIG_SYS_TEXT_BASE0xFE00 diff --git a/include/configs/TQM834x.h b/include/configs/TQM834x.h index 0c6bcae33c..9d27358031 100644 --- a/include/configs/TQM834x.h +++ b/include/configs/TQM834x.h @@ -18,7 +18,6 @@ #define CONFIG_E3001 /* E300 Family */ #define CONFIG_MPC834x 1 /* MPC834x specific */ #define CONFIG_MPC8349 1 /* MPC8349 specific */ -#define CONFIG_TQM834X 1 /* TQM834X board specific */ #defineCONFIG_SYS_TEXT_BASE0x8000 diff --git a/include/configs/cyrus.h b/include/configs/cyrus.h index e413b5158c..3da91e80c8 100644 --- a/include/configs/cyrus.h +++ b/include/configs/cyrus.h @@ -7,8 +7,6 @@ #ifndef __CONFIG_H #define __CONFIG_H -#define CONFIG_CYRUS - #if !defined(CONFIG_ARCH_P5020) && !defined(CONFIG_ARCH_P5040) #error Must call Cyrus CONFIG with a specific CPU enabled. #endif diff --git a/include/configs/ids8313.h b/include/configs/ids8313.h index b43c8c711e..12eb07d1f7 100644 --- a/include/configs/ids8313.h +++ b/include/configs/ids8313.h @@ -17,7 +17,6 @@ */ #define CONFIG_MPC831x #define CONFIG_MPC8313 -#define CONFIG_IDS8313 #define CONFIG_FSL_ELBC diff --git a/include/configs/mpc8308_p1m.h b/include/configs/mpc8308_p1m.h index f97773146a..69c4309139 100644 --- a/include/configs/mpc8308_p1m.h +++ b/include/configs/mpc8308_p1m.h @@ -15,7 +15,6 @@ #define CONFIG_E3001 /* E300 family */ #define CONFIG_MPC830x 1 /* MPC830x family */ #define CONFIG_MPC8308 1 /* MPC8308 CPU specific */ -#define CONFIG_MPC8308_P1M 1 /* mpc8308_p1m board specific */ #ifndef CONFIG_SYS_TEXT_BASE #define CONFIG_SYS_TEXT_BASE 0xFC00 diff --git a/include/configs/s
