Re: [U-Boot] [PATCH] serial: UniPhier: borrow macros from linux/serial_reg.h

2014-11-11 Thread Masahiro YAMADA
2014-10-30 12:11 GMT+09:00 Masahiro Yamada yamad...@jp.panasonic.com:
 The same bit-field macros are defined in include/linux/serial_reg.h
 so let's include it and delete duplicated defines.

 Also, remove unnecessary inclusion of common.h.

 Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com


Applied to u-boot-uniphier/master.


-- 
Best Regards
Masahiro Yamada
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] serial: UniPhier: borrow macros from linux/serial_reg.h

2014-10-29 Thread Masahiro Yamada
The same bit-field macros are defined in include/linux/serial_reg.h
so let's include it and delete duplicated defines.

Also, remove unnecessary inclusion of common.h.

Signed-off-by: Masahiro Yamada yamad...@jp.panasonic.com
---

 drivers/serial/serial_uniphier.c | 15 ++-
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/serial/serial_uniphier.c b/drivers/serial/serial_uniphier.c
index 3f3d415..6046efb 100644
--- a/drivers/serial/serial_uniphier.c
+++ b/drivers/serial/serial_uniphier.c
@@ -5,7 +5,7 @@
  * SPDX-License-Identifier:GPL-2.0+
  */
 
-#include common.h
+#include linux/serial_reg.h
 #include asm/io.h
 #include asm/errno.h
 #include dm/device.h
@@ -37,17 +37,6 @@ struct uniphier_serial {
 
 #define thr rbr
 
-/*
- * These are the definitions for the Line Control Register
- */
-#define UART_LCR_WLS_8 0x03/* 8 bit character length */
-
-/*
- * These are the definitions for the Line Status Register
- */
-#define UART_LSR_DR0x01/* Data ready */
-#define UART_LSR_THRE  0x20/* Xmit holding register empty */
-
 struct uniphier_serial_private_data {
struct uniphier_serial __iomem *membase;
 };
@@ -62,7 +51,7 @@ static int uniphier_serial_setbrg(struct udevice *dev, int 
baudrate)
const unsigned int mode_x_div = 16;
unsigned int divisor;
 
-   writeb(UART_LCR_WLS_8, port-lcr);
+   writeb(UART_LCR_WLEN8, port-lcr);
 
divisor = DIV_ROUND_CLOSEST(plat-uartclk, mode_x_div * baudrate);
 
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot