Re: [U-Boot] [PATCH] sf: move useful messages from debug to printf

[Wolfgang Denk]

Dear Mike Frysinger,

In message 1272516050-17920-1-git-send-email-vap...@gentoo.org you wrote:
 At the moment, the default SPI flash subsystem is quite terse.  Errors and
 successes both result in a generic message.  So move the useful errors and
 useful successes to printf output by default.
...
 - debug(SF: Detected %s with page size %lu, total %u bytes\n,
 + printf(SF: Detected %s with page size %lu, total %u bytes\n,
   params-name, page_size, asf-flash.size);

When we touch this code, we might as well make the output more
readable and print the size in easier to parse units using
print_size() - see Timur's patches from 13 Ap 2010,
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/77288

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
It is your destiny. - Darth Vader
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] sf: move useful messages from debug to printf

[Mike Frysinger]

At the moment, the default SPI flash subsystem is quite terse.  Errors and
successes both result in a generic message.  So move the useful errors and
useful successes to printf output by default.

Signed-off-by: Mike Frysinger vap...@gentoo.org
---
 drivers/mtd/spi/atmel.c |2 +-
 drivers/mtd/spi/spansion.c  |4 ++--
 drivers/mtd/spi/spi_flash.c |4 ++--
 drivers/mtd/spi/sst.c   |4 ++--
 drivers/mtd/spi/stmicro.c   |4 ++--
 drivers/mtd/spi/winbond.c   |4 ++--
 6 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/mtd/spi/atmel.c b/drivers/mtd/spi/atmel.c
index 8306c00..f1f5975 100644
--- a/drivers/mtd/spi/atmel.c
+++ b/drivers/mtd/spi/atmel.c
@@ -540,7 +540,7 @@ struct spi_flash *spi_flash_probe_atmel(struct spi_slave 
*spi, u8 *idcode)
* params-blocks_per_sector
* params-nr_sectors;
 
-   debug(SF: Detected %s with page size %lu, total %u bytes\n,
+   printf(SF: Detected %s with page size %lu, total %u bytes\n,
params-name, page_size, asf-flash.size);
 
return asf-flash;
diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index fdb7917..cd1f250 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -343,8 +343,8 @@ struct spi_flash *spi_flash_probe_spansion(struct spi_slave 
*spi, u8 *idcode)
spsn-flash.size = params-page_size * params-pages_per_sector
* params-nr_sectors;
 
-   debug(SF: Detected %s with page size %u, total %u bytes\n,
- params-name, params-page_size, spsn-flash.size);
+   printf(SF: Detected %s with page size %u, total %u bytes\n,
+  params-name, params-page_size, spsn-flash.size);
 
return spsn-flash;
 }
diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
index 612f819..bbb194e 100644
--- a/drivers/mtd/spi/spi_flash.c
+++ b/drivers/mtd/spi/spi_flash.c
@@ -106,7 +106,7 @@ struct spi_flash *spi_flash_probe(unsigned int bus, 
unsigned int cs,
 
spi = spi_setup_slave(bus, cs, max_hz, spi_mode);
if (!spi) {
-   debug(SF: Failed to set up slave\n);
+   printf(SF: Failed to set up slave\n);
return NULL;
}
 
@@ -156,7 +156,7 @@ struct spi_flash *spi_flash_probe(unsigned int bus, 
unsigned int cs,
break;
 #endif
default:
-   debug(SF: Unsupported manufacturer %02X\n, idcode[0]);
+   printf(SF: Unsupported manufacturer %02X\n, idcode[0]);
flash = NULL;
break;
}
diff --git a/drivers/mtd/spi/sst.c b/drivers/mtd/spi/sst.c
index 50e9299..9d5ebef 100644
--- a/drivers/mtd/spi/sst.c
+++ b/drivers/mtd/spi/sst.c
@@ -364,8 +364,8 @@ spi_flash_probe_sst(struct spi_slave *spi, u8 *idcode)
stm-flash.read = sst_read_fast;
stm-flash.size = SST_SECTOR_SIZE * params-nr_sectors;
 
-   debug(SF: Detected %s with page size %u, total %u bytes\n,
- params-name, SST_SECTOR_SIZE, stm-flash.size);
+   printf(SF: Detected %s with page size %u, total %u bytes\n,
+  params-name, SST_SECTOR_SIZE, stm-flash.size);
 
/* Flash powers up read-only, so clear BP# bits */
sst_unlock(stm-flash);
diff --git a/drivers/mtd/spi/stmicro.c b/drivers/mtd/spi/stmicro.c
index ae0d047..9b17b3e 100644
--- a/drivers/mtd/spi/stmicro.c
+++ b/drivers/mtd/spi/stmicro.c
@@ -344,8 +344,8 @@ struct spi_flash *spi_flash_probe_stmicro(struct spi_slave 
*spi, u8 * idcode)
stm-flash.size = params-page_size * params-pages_per_sector
* params-nr_sectors;
 
-   debug(SF: Detected %s with page size %u, total %u bytes\n,
- params-name, params-page_size, stm-flash.size);
+   printf(SF: Detected %s with page size %u, total %u bytes\n,
+  params-name, params-page_size, stm-flash.size);
 
return stm-flash;
 }
diff --git a/drivers/mtd/spi/winbond.c b/drivers/mtd/spi/winbond.c
index b8da923..09c4f1a 100644
--- a/drivers/mtd/spi/winbond.c
+++ b/drivers/mtd/spi/winbond.c
@@ -289,7 +289,7 @@ out:
 struct spi_flash *spi_flash_probe_winbond(struct spi_slave *spi, u8 *idcode)
 {
const struct winbond_spi_flash_params *params;
-   unsigned long page_size;
+   unsigned page_size;
struct winbond_spi_flash *stm;
unsigned int i;
 
@@ -325,7 +325,7 @@ struct spi_flash *spi_flash_probe_winbond(struct spi_slave 
*spi, u8 *idcode)
* params-sectors_per_block
* params-nr_blocks;
 
-   debug(SF: Detected %s with page size %u, total %u bytes\n,
+   printf(SF: Detected %s with page size %u, total %u bytes\n,
params-name, page_size, stm-flash.size);
 
return stm-flash;
-- 
1.7.0.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot