Re: [U-Boot] [PATCH] sf: params: Add support for n25q016a

[Moritz Fischer]

Hi Marek,

On Wed, Mar 30, 2016 at 5:34 PM, Marek Vasut  wrote:
> On 03/31/2016 12:23 AM, Moritz Fischer wrote:
>> This commits adds support for the N25Q016A, a 16Mbit
>> serial NOR flash from Micron.
>>
>> Signed-off-by: Moritz Fischer 
>> ---
>>  drivers/mtd/spi/sf_params.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
>> index 4f37e33..8ae4eea 100644
>> --- a/drivers/mtd/spi/sf_params.c
>> +++ b/drivers/mtd/spi/sf_params.c
>> @@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
>>   {"M25P64", 0x202017, 0x0,   64 * 1024,   128, RD_NORM, 
>>0},
>>   {"M25P128",0x202018, 0x0,  256 * 1024,64, RD_NORM, 
>>0},
>>   {"M25PX64",0x207117, 0x0,   64 * 1024,   128, RD_NORM, 
>>  SECT_4K},
>> + {"N25Q016A",   0x20bb15, 0x1000,64 * 1024,32, RD_NORM, 
>>  SECT_4K},
>
> According to [1], the device supports Quad I/O, so WR_QPP flag should be
> here in addition to SECT_4K .

Just finished testing your suggestion. Will resubmit v2. Thanks for the review.

Moritz
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] sf: params: Add support for n25q016a

[Marek Vasut]

On 03/31/2016 12:23 AM, Moritz Fischer wrote:
> This commits adds support for the N25Q016A, a 16Mbit
> serial NOR flash from Micron.
> 
> Signed-off-by: Moritz Fischer 
> ---
>  drivers/mtd/spi/sf_params.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
> index 4f37e33..8ae4eea 100644
> --- a/drivers/mtd/spi/sf_params.c
> +++ b/drivers/mtd/spi/sf_params.c
> @@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
>   {"M25P64", 0x202017, 0x0,   64 * 1024,   128, RD_NORM,  
>   0},
>   {"M25P128",0x202018, 0x0,  256 * 1024,64, RD_NORM,  
>   0},
>   {"M25PX64",0x207117, 0x0,   64 * 1024,   128, RD_NORM,  
> SECT_4K},
> + {"N25Q016A",   0x20bb15, 0x1000,64 * 1024,32, RD_NORM,  
> SECT_4K},

According to [1], the device supports Quad I/O, so WR_QPP flag should be
here in addition to SECT_4K .

[1]
https://www.micron.com/~/media/documents/products/data-sheet/nor-flash/serial-nor/n25q/n25q_64mb_1_8v_65nm.pdf

>   {"N25Q32", 0x20ba16, 0x0,   64 * 1024,64, RD_FULL,  
>WR_QPP | SECT_4K},
>   {"N25Q32A",0x20bb16, 0x0,   64 * 1024,64, RD_FULL,  
>WR_QPP | SECT_4K},
>   {"N25Q64", 0x20ba17, 0x0,   64 * 1024,   128, RD_FULL,  
>WR_QPP | SECT_4K},
> 


-- 
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] sf: params: Add support for n25q016a

[Moritz Fischer]

This commits adds support for the N25Q016A, a 16Mbit
serial NOR flash from Micron.

Signed-off-by: Moritz Fischer 
---
 drivers/mtd/spi/sf_params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c
index 4f37e33..8ae4eea 100644
--- a/drivers/mtd/spi/sf_params.c
+++ b/drivers/mtd/spi/sf_params.c
@@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
{"M25P64", 0x202017, 0x0,   64 * 1024,   128, RD_NORM,  
  0},
{"M25P128",0x202018, 0x0,  256 * 1024,64, RD_NORM,  
  0},
{"M25PX64",0x207117, 0x0,   64 * 1024,   128, RD_NORM,  
SECT_4K},
+   {"N25Q016A",   0x20bb15, 0x1000,64 * 1024,32, RD_NORM,  
SECT_4K},
{"N25Q32", 0x20ba16, 0x0,   64 * 1024,64, RD_FULL,  
   WR_QPP | SECT_4K},
{"N25Q32A",0x20bb16, 0x0,   64 * 1024,64, RD_FULL,  
   WR_QPP | SECT_4K},
{"N25Q64", 0x20ba17, 0x0,   64 * 1024,   128, RD_FULL,  
   WR_QPP | SECT_4K},
-- 
2.5.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot