Re: [U-Boot] [PATCH] snow: set fdtfile

2018-07-27 Thread Minkyu Kang
Hi,

2018년 7월 16일 (월) 18:04, Minkyu Kang 님이 작성:

> Hi,
>
> 2018년 7월 16일 (월) 17:49, Guillaume Gardet 님이 작성:
>
>> Hi,
>>
>>
>> Le 13/07/2018 à 19:20, Peter Robinson a écrit :
>> > On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET
>> >  wrote:
>> >> Needed to boot with EFI distro boot.
>> >>
>> >> Signed-off-by: Guillaume GARDET 
>> >>
>> >> Cc: Akshay Saraswat 
>> >> Cc: Tom Rini 
>> >> ---
>> >>   include/configs/snow.h | 3 +++
>> >>   1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/include/configs/snow.h b/include/configs/snow.h
>> >> index 3b0db32ece..c546a5a6d0 100644
>> >> --- a/include/configs/snow.h
>> >> +++ b/include/configs/snow.h
>> >> @@ -8,6 +8,9 @@
>> >>   #ifndef __CONFIG_SNOW_H
>> >>   #define __CONFIG_SNOW_H
>> >>
>> >> +#define EXYNOS_FDTFILE_SETTING \
>> >> +   "fdtfile=exynos5250-snow.dtb\0"
>> > Isn't it set in configs/snow_defconfig with
>> > CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow"
>>
>> No, CONFIG_DEFAULT_DEVICE_TREE is only used for U-Boot DT, not to set
>> fdtfile var.
>>
>> Guillaume
>>
>> >
>> >>   #include 
>> >>   #include 
>> >>   #include 
>> >> --
>> >> 2.17.1
>> >>
>> >> ___
>> >> U-Boot mailing list
>> >> U-Boot@lists.denx.de
>> >> https://lists.denx.de/listinfo/u-boot
>>
>> ___
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> https://lists.denx.de/listinfo/u-boot
>
>
> I'll pick this patch up soon.
>
> Thanks,
> Minkyu Kang.
>

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH] snow: set fdtfile

2018-07-16 Thread Minkyu Kang
Hi,

2018년 7월 16일 (월) 17:49, Guillaume Gardet 님이 작성:

> Hi,
>
>
> Le 13/07/2018 à 19:20, Peter Robinson a écrit :
> > On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET
> >  wrote:
> >> Needed to boot with EFI distro boot.
> >>
> >> Signed-off-by: Guillaume GARDET 
> >>
> >> Cc: Akshay Saraswat 
> >> Cc: Tom Rini 
> >> ---
> >>   include/configs/snow.h | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> >> diff --git a/include/configs/snow.h b/include/configs/snow.h
> >> index 3b0db32ece..c546a5a6d0 100644
> >> --- a/include/configs/snow.h
> >> +++ b/include/configs/snow.h
> >> @@ -8,6 +8,9 @@
> >>   #ifndef __CONFIG_SNOW_H
> >>   #define __CONFIG_SNOW_H
> >>
> >> +#define EXYNOS_FDTFILE_SETTING \
> >> +   "fdtfile=exynos5250-snow.dtb\0"
> > Isn't it set in configs/snow_defconfig with
> > CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow"
>
> No, CONFIG_DEFAULT_DEVICE_TREE is only used for U-Boot DT, not to set
> fdtfile var.
>
> Guillaume
>
> >
> >>   #include 
> >>   #include 
> >>   #include 
> >> --
> >> 2.17.1
> >>
> >> ___
> >> U-Boot mailing list
> >> U-Boot@lists.denx.de
> >> https://lists.denx.de/listinfo/u-boot
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot


I'll pick this patch up soon.

Thanks,
Minkyu Kang.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH] snow: set fdtfile

2018-07-16 Thread Guillaume Gardet

Hi,


Le 13/07/2018 à 19:20, Peter Robinson a écrit :

On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET
 wrote:

Needed to boot with EFI distro boot.

Signed-off-by: Guillaume GARDET 

Cc: Akshay Saraswat 
Cc: Tom Rini 
---
  include/configs/snow.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/include/configs/snow.h b/include/configs/snow.h
index 3b0db32ece..c546a5a6d0 100644
--- a/include/configs/snow.h
+++ b/include/configs/snow.h
@@ -8,6 +8,9 @@
  #ifndef __CONFIG_SNOW_H
  #define __CONFIG_SNOW_H

+#define EXYNOS_FDTFILE_SETTING \
+   "fdtfile=exynos5250-snow.dtb\0"

Isn't it set in configs/snow_defconfig with
CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow"


No, CONFIG_DEFAULT_DEVICE_TREE is only used for U-Boot DT, not to set fdtfile 
var.

Guillaume




  #include 
  #include 
  #include 
--
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH] snow: set fdtfile

2018-07-13 Thread Peter Robinson
On Thu, Jun 14, 2018 at 9:34 PM, Guillaume GARDET
 wrote:
> Needed to boot with EFI distro boot.
>
> Signed-off-by: Guillaume GARDET 
>
> Cc: Akshay Saraswat 
> Cc: Tom Rini 
> ---
>  include/configs/snow.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/configs/snow.h b/include/configs/snow.h
> index 3b0db32ece..c546a5a6d0 100644
> --- a/include/configs/snow.h
> +++ b/include/configs/snow.h
> @@ -8,6 +8,9 @@
>  #ifndef __CONFIG_SNOW_H
>  #define __CONFIG_SNOW_H
>
> +#define EXYNOS_FDTFILE_SETTING \
> +   "fdtfile=exynos5250-snow.dtb\0"

Isn't it set in configs/snow_defconfig with
CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow"

>  #include 
>  #include 
>  #include 
> --
> 2.17.1
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH] snow: set fdtfile

2018-07-13 Thread Guillaume Gardet

Hi,

This is a reminder for this patch.

Guillaume



Le 14/06/2018 à 22:34, Guillaume GARDET a écrit :

Needed to boot with EFI distro boot.

Signed-off-by: Guillaume GARDET 

Cc: Akshay Saraswat 
Cc: Tom Rini 
---
  include/configs/snow.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/include/configs/snow.h b/include/configs/snow.h
index 3b0db32ece..c546a5a6d0 100644
--- a/include/configs/snow.h
+++ b/include/configs/snow.h
@@ -8,6 +8,9 @@
  #ifndef __CONFIG_SNOW_H
  #define __CONFIG_SNOW_H
  
+#define EXYNOS_FDTFILE_SETTING \

+   "fdtfile=exynos5250-snow.dtb\0"
+
  #include 
  #include 
  #include 


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH] snow: set fdtfile

2018-06-14 Thread Guillaume GARDET
Needed to boot with EFI distro boot.

Signed-off-by: Guillaume GARDET 

Cc: Akshay Saraswat 
Cc: Tom Rini 
---
 include/configs/snow.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/configs/snow.h b/include/configs/snow.h
index 3b0db32ece..c546a5a6d0 100644
--- a/include/configs/snow.h
+++ b/include/configs/snow.h
@@ -8,6 +8,9 @@
 #ifndef __CONFIG_SNOW_H
 #define __CONFIG_SNOW_H
 
+#define EXYNOS_FDTFILE_SETTING \
+   "fdtfile=exynos5250-snow.dtb\0"
+
 #include 
 #include 
 #include 
-- 
2.17.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot