Re: [U-Boot] [PATCH] tegra: harmony: fix comments for environment config options

2012-07-31 Thread Thierry Reding
On Tue, Jul 31, 2012 at 08:52:34AM -0700, Tom Warren wrote:
> Stephen/Thierry,
> 
> > -Original Message-
> > From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> > Sent: Tuesday, July 31, 2012 8:47 AM
> > To: Tom Warren
> > Cc: Thierry Reding; U-Boot Mailing List; Stephen Warren
> > Subject: [PATCH] tegra: harmony: fix comments for environment config options
> > 
> > From: Stephen Warren 
> > 
> > The environment is now stored in NAND, so update the comment to say so,
> > rather than saying it's not stored.
> > 
> > Signed-off-by: Stephen Warren 
> > ---
> > Tom, feel free to just squash this into my patch that added environment
> > support to Harmony if you want.
> 
> I'll just fix the 'not stored' comment in both harmony and tec when I apply 
> those patches to /next, if that's OK with you two.

That's fine with me. You can just copy Stephen's comment for TEC. In
fact probably the same patch can be used for both Medcom and Plutux as
well, but I'll submit them as separate patches after I've had the time
to actually test them.

Thierry


pgpC6bNamSb2n.pgp
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] tegra: harmony: fix comments for environment config options

2012-07-31 Thread Tom Warren
Stephen/Thierry,

> -Original Message-
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Tuesday, July 31, 2012 8:47 AM
> To: Tom Warren
> Cc: Thierry Reding; U-Boot Mailing List; Stephen Warren
> Subject: [PATCH] tegra: harmony: fix comments for environment config options
> 
> From: Stephen Warren 
> 
> The environment is now stored in NAND, so update the comment to say so,
> rather than saying it's not stored.
> 
> Signed-off-by: Stephen Warren 
> ---
> Tom, feel free to just squash this into my patch that added environment
> support to Harmony if you want.

I'll just fix the 'not stored' comment in both harmony and tec when I apply 
those patches to /next, if that's OK with you two.

Tom
-- 
nvpublic
> 
>  include/configs/harmony.h |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/harmony.h b/include/configs/harmony.h index
> 85059b9..69857dd 100644
> --- a/include/configs/harmony.h
> +++ b/include/configs/harmony.h
> @@ -68,7 +68,7 @@
>  #define CONFIG_SYS_MAX_NAND_DEVICE   1
>  #define CONFIG_SYS_NAND_BASE TEGRA20_NAND_BASE
> 
> -/* Environment not stored */
> +/* Environment in NAND (which is 512M), aligned to start of last sector
> +*/
>  #define CONFIG_ENV_IS_IN_NAND
>  #define CONFIG_ENV_OFFSET(SZ_512M - SZ_128K) /* 128K sector size */
> 
> --
> 1.7.0.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] tegra: harmony: fix comments for environment config options

2012-07-31 Thread Stephen Warren
From: Stephen Warren 

The environment is now stored in NAND, so update the comment to say so,
rather than saying it's not stored.

Signed-off-by: Stephen Warren 
---
Tom, feel free to just squash this into my patch that added environment
support to Harmony if you want.

 include/configs/harmony.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/configs/harmony.h b/include/configs/harmony.h
index 85059b9..69857dd 100644
--- a/include/configs/harmony.h
+++ b/include/configs/harmony.h
@@ -68,7 +68,7 @@
 #define CONFIG_SYS_MAX_NAND_DEVICE 1
 #define CONFIG_SYS_NAND_BASE   TEGRA20_NAND_BASE
 
-/* Environment not stored */
+/* Environment in NAND (which is 512M), aligned to start of last sector */
 #define CONFIG_ENV_IS_IN_NAND
 #define CONFIG_ENV_OFFSET  (SZ_512M - SZ_128K) /* 128K sector size */
 
-- 
1.7.0.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot