Re: [U-Boot] [PATCH] usb: f_mass_storage: set removable flag in do_inquiry based on LUN
Hi Marek, On Saturday, September 20, 2014 at 02:06:46 AM, Eric Nelson wrote: Without this flag, tools like Alex Page's USB Image Tool won't see drives exposed over USB Gadget as removable, and won't allow access to them. http://www.alexpage.de/usb-image-tool/ The code was pulled from the main-line kernel: drivers/usb/gadget/function/f_mass_storage.c Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com I'm OK with this. This should go to current release too. Lukasz, do you agree ? Do you want to pick it + send me PR or shall I apply directly ? Eric thanks for your patch. Acked-by: Lukasz Majewski l.majew...@samsung.com Tested-by: Lukasz Majewski l.majew...@samsung.com Test HW (Trats - Exynos 4210) I've applied this patch to u-boot-dfu branch. I will send PR to Marek in a few days time. Eric, please CC Lukasz on the gadget patches, he's the gadget guru. Best regards, Marek Vasut -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: f_mass_storage: set removable flag in do_inquiry based on LUN
On 09/22/2014 09:00 AM, Lukasz Majewski wrote: Hi Marek, On Saturday, September 20, 2014 at 02:06:46 AM, Eric Nelson wrote: Without this flag, tools like Alex Page's USB Image Tool won't see drives exposed over USB Gadget as removable, and won't allow access to them. http://www.alexpage.de/usb-image-tool/ The code was pulled from the main-line kernel: drivers/usb/gadget/function/f_mass_storage.c Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com I'm OK with this. This should go to current release too. Lukasz, do you agree ? Do you want to pick it + send me PR or shall I apply directly ? Eric thanks for your patch. Acked-by: Lukasz Majewski l.majew...@samsung.com Tested-by: Lukasz Majewski l.majew...@samsung.com Test HW (Trats - Exynos 4210) I've applied this patch to u-boot-dfu branch. I will send PR to Marek in a few days time. Thanks Lukasz and Marek. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: f_mass_storage: set removable flag in do_inquiry based on LUN
Hi Marek, Eric On Saturday, September 20, 2014 at 02:06:46 AM, Eric Nelson wrote: Without this flag, tools like Alex Page's USB Image Tool won't see drives exposed over USB Gadget as removable, and won't allow access to them. http://www.alexpage.de/usb-image-tool/ The code was pulled from the main-line kernel: drivers/usb/gadget/function/f_mass_storage.c Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com I'm OK with this. This should go to current release too. Lukasz, do you agree ? Do you want to pick it + send me PR or shall I apply directly ? Eric, please CC Lukasz on the gadget patches, he's the gadget guru. I will do my best to look into those patches today or tomorrow. Best regards, Marek Vasut -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] usb: f_mass_storage: set removable flag in do_inquiry based on LUN
On Saturday, September 20, 2014 at 02:06:46 AM, Eric Nelson wrote: Without this flag, tools like Alex Page's USB Image Tool won't see drives exposed over USB Gadget as removable, and won't allow access to them. http://www.alexpage.de/usb-image-tool/ The code was pulled from the main-line kernel: drivers/usb/gadget/function/f_mass_storage.c Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com I'm OK with this. This should go to current release too. Lukasz, do you agree ? Do you want to pick it + send me PR or shall I apply directly ? Eric, please CC Lukasz on the gadget patches, he's the gadget guru. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] usb: f_mass_storage: set removable flag in do_inquiry based on LUN
Without this flag, tools like Alex Page's USB Image Tool won't see drives exposed over USB Gadget as removable, and won't allow access to them. http://www.alexpage.de/usb-image-tool/ The code was pulled from the main-line kernel: drivers/usb/gadget/function/f_mass_storage.c Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com --- drivers/usb/gadget/f_mass_storage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index f274d96..e045957 100644 --- a/drivers/usb/gadget/f_mass_storage.c +++ b/drivers/usb/gadget/f_mass_storage.c @@ -1110,6 +1110,7 @@ static int do_inquiry(struct fsg_common *common, struct fsg_buffhd *bh) memset(buf, 0, 8); buf[0] = TYPE_DISK; + buf[1] = curlun-removable ? 0x80 : 0; buf[2] = 2; /* ANSI SCSI level 2 */ buf[3] = 2; /* SCSI-2 INQUIRY data format */ buf[4] = 31;/* Additional length */ -- 1.9.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
