Re: [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig

2015-06-03 Thread Bin Meng
Hi Simon,

On Wed, Jun 3, 2015 at 2:38 AM, Simon Glass s...@chromium.org wrote:
 Hi Bin,

 On 2 June 2015 at 08:41, Bin Meng bmeng...@gmail.com wrote:
 Hi Simon,

 On Tue, Jun 2, 2015 at 6:44 PM, Bin Meng bmeng...@gmail.com wrote:
 Hi Simon,

 On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng bmeng...@gmail.com wrote:
 The following error is observed on QEMU x86.

 = print ipaddr
 ipaddr=192.168.178.66
 = ping 192.168.178.1
 *** ERROR: `ipaddr' not set
 ping failed; host 192.168.178.1 is not alive

 The issue was introduced in commit fd30563. Adding CMD_NET to
 defconfig resolves this. Also reorder the config options to
 match the order in Kconfig.

 Signed-off-by: Bin Meng bmeng...@gmail.com
 ---

  configs/qemu-x86_defconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
 index a5251b5..07b5176 100644
 --- a/configs/qemu-x86_defconfig
 +++ b/configs/qemu-x86_defconfig
 @@ -1,9 +1,9 @@
  CONFIG_X86=y
  CONFIG_VENDOR_EMULATION=y
  CONFIG_TARGET_QEMU_X86=y
 +CONFIG_GENERATE_PIRQ_TABLE=y
 +CONFIG_CMD_NET=y
  CONFIG_OF_CONTROL=y
 -CONFIG_OF_SEPARATE=y
  CONFIG_VIDEO_VESA=y
  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 -CONFIG_GENERATE_PIRQ_TABLE=y
 --

 After Joe's pull request [1] get applied by Tom, you can rebase
 u-boot-x86/testing branch and apply this one to fix the qemu
 networking issue. Thanks!

 [1] http://patchwork.ozlabs.org/patch/479136/


 I see Joe's pull request has been applied, but sorry I've noticed that
 this patch has some dependencies on the qemu v2 patch series I am
 working on. Please ignore this and I will resend it as part of my qemu
 v2 patch series soon. Sorry about that.

 OK I have it setting in x86/testing. Please let me know what commits
 need changing, etc.


Please check this v2 series: http://patchwork.ozlabs.org/patch/479745/

It is rebased on u-boot-x86/master.

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig

2015-06-02 Thread Simon Glass
Hi Bin,

On 2 June 2015 at 08:41, Bin Meng bmeng...@gmail.com wrote:
 Hi Simon,

 On Tue, Jun 2, 2015 at 6:44 PM, Bin Meng bmeng...@gmail.com wrote:
 Hi Simon,

 On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng bmeng...@gmail.com wrote:
 The following error is observed on QEMU x86.

 = print ipaddr
 ipaddr=192.168.178.66
 = ping 192.168.178.1
 *** ERROR: `ipaddr' not set
 ping failed; host 192.168.178.1 is not alive

 The issue was introduced in commit fd30563. Adding CMD_NET to
 defconfig resolves this. Also reorder the config options to
 match the order in Kconfig.

 Signed-off-by: Bin Meng bmeng...@gmail.com
 ---

  configs/qemu-x86_defconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
 index a5251b5..07b5176 100644
 --- a/configs/qemu-x86_defconfig
 +++ b/configs/qemu-x86_defconfig
 @@ -1,9 +1,9 @@
  CONFIG_X86=y
  CONFIG_VENDOR_EMULATION=y
  CONFIG_TARGET_QEMU_X86=y
 +CONFIG_GENERATE_PIRQ_TABLE=y
 +CONFIG_CMD_NET=y
  CONFIG_OF_CONTROL=y
 -CONFIG_OF_SEPARATE=y
  CONFIG_VIDEO_VESA=y
  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 -CONFIG_GENERATE_PIRQ_TABLE=y
 --

 After Joe's pull request [1] get applied by Tom, you can rebase
 u-boot-x86/testing branch and apply this one to fix the qemu
 networking issue. Thanks!

 [1] http://patchwork.ozlabs.org/patch/479136/


 I see Joe's pull request has been applied, but sorry I've noticed that
 this patch has some dependencies on the qemu v2 patch series I am
 working on. Please ignore this and I will resend it as part of my qemu
 v2 patch series soon. Sorry about that.

OK I have it setting in x86/testing. Please let me know what commits
need changing, etc.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig

2015-06-02 Thread Bin Meng
The following error is observed on QEMU x86.

= print ipaddr
ipaddr=192.168.178.66
= ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive

The issue was introduced in commit fd30563. Adding CMD_NET to
defconfig resolves this. Also reorder the config options to
match the order in Kconfig.

Signed-off-by: Bin Meng bmeng...@gmail.com
---

 configs/qemu-x86_defconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
index a5251b5..07b5176 100644
--- a/configs/qemu-x86_defconfig
+++ b/configs/qemu-x86_defconfig
@@ -1,9 +1,9 @@
 CONFIG_X86=y
 CONFIG_VENDOR_EMULATION=y
 CONFIG_TARGET_QEMU_X86=y
+CONFIG_GENERATE_PIRQ_TABLE=y
+CONFIG_CMD_NET=y
 CONFIG_OF_CONTROL=y
-CONFIG_OF_SEPARATE=y
 CONFIG_VIDEO_VESA=y
 CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
 CONFIG_FRAMEBUFFER_VESA_MODE_111=y
-CONFIG_GENERATE_PIRQ_TABLE=y
-- 
1.8.2.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig

2015-06-02 Thread Bin Meng
Hi Simon,

On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng bmeng...@gmail.com wrote:
 The following error is observed on QEMU x86.

 = print ipaddr
 ipaddr=192.168.178.66
 = ping 192.168.178.1
 *** ERROR: `ipaddr' not set
 ping failed; host 192.168.178.1 is not alive

 The issue was introduced in commit fd30563. Adding CMD_NET to
 defconfig resolves this. Also reorder the config options to
 match the order in Kconfig.

 Signed-off-by: Bin Meng bmeng...@gmail.com
 ---

  configs/qemu-x86_defconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
 index a5251b5..07b5176 100644
 --- a/configs/qemu-x86_defconfig
 +++ b/configs/qemu-x86_defconfig
 @@ -1,9 +1,9 @@
  CONFIG_X86=y
  CONFIG_VENDOR_EMULATION=y
  CONFIG_TARGET_QEMU_X86=y
 +CONFIG_GENERATE_PIRQ_TABLE=y
 +CONFIG_CMD_NET=y
  CONFIG_OF_CONTROL=y
 -CONFIG_OF_SEPARATE=y
  CONFIG_VIDEO_VESA=y
  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 -CONFIG_GENERATE_PIRQ_TABLE=y
 --

After Joe's pull request [1] get applied by Tom, you can rebase
u-boot-x86/testing branch and apply this one to fix the qemu
networking issue. Thanks!

[1] http://patchwork.ozlabs.org/patch/479136/

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH] x86: qemu: Add CMD_NET to qemu-x86_defconfig

2015-06-02 Thread Bin Meng
Hi Simon,

On Tue, Jun 2, 2015 at 6:44 PM, Bin Meng bmeng...@gmail.com wrote:
 Hi Simon,

 On Tue, Jun 2, 2015 at 6:40 PM, Bin Meng bmeng...@gmail.com wrote:
 The following error is observed on QEMU x86.

 = print ipaddr
 ipaddr=192.168.178.66
 = ping 192.168.178.1
 *** ERROR: `ipaddr' not set
 ping failed; host 192.168.178.1 is not alive

 The issue was introduced in commit fd30563. Adding CMD_NET to
 defconfig resolves this. Also reorder the config options to
 match the order in Kconfig.

 Signed-off-by: Bin Meng bmeng...@gmail.com
 ---

  configs/qemu-x86_defconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/configs/qemu-x86_defconfig b/configs/qemu-x86_defconfig
 index a5251b5..07b5176 100644
 --- a/configs/qemu-x86_defconfig
 +++ b/configs/qemu-x86_defconfig
 @@ -1,9 +1,9 @@
  CONFIG_X86=y
  CONFIG_VENDOR_EMULATION=y
  CONFIG_TARGET_QEMU_X86=y
 +CONFIG_GENERATE_PIRQ_TABLE=y
 +CONFIG_CMD_NET=y
  CONFIG_OF_CONTROL=y
 -CONFIG_OF_SEPARATE=y
  CONFIG_VIDEO_VESA=y
  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
  CONFIG_FRAMEBUFFER_VESA_MODE_111=y
 -CONFIG_GENERATE_PIRQ_TABLE=y
 --

 After Joe's pull request [1] get applied by Tom, you can rebase
 u-boot-x86/testing branch and apply this one to fix the qemu
 networking issue. Thanks!

 [1] http://patchwork.ozlabs.org/patch/479136/


I see Joe's pull request has been applied, but sorry I've noticed that
this patch has some dependencies on the qemu v2 patch series I am
working on. Please ignore this and I will resend it as part of my qemu
v2 patch series soon. Sorry about that.

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot