Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
On Thursday, January 08, 2015 at 06:40:19 PM, Hans de Goede wrote: > Hi, Hi! [...] > > Only the semantics of "usb start" are changing, and you are > > suggesting renaming "usb reset" which remains unchanged ... > > Yes, that's true. So I suppose we should indeed not rename anything. > >>> > >>> OK, let's go with this approach now. > >> > >> So we are all in agreement, good, so through who's tree are these 2 > >> patches going to go upstream ? Note I can take them upstream through > >> the sunxi tree, but the usb tree seems better to me ... > > > > I can pick them, shall I pick them as they are ? > > Yes, AFAIK there were no requests for changes. > > > Are they for -next or current ? > > They are intended for -next, the double usb scan when using a usb keyboard > *and* booting from usb is a nuisance, but not fatal, and very few people > actually use the combo, so given that current is about to be released in a > couple of days lets play it safe :) OK, applied both to next. Thanks! Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
Hi, On 08-01-15 18:36, Marek Vasut wrote: On Thursday, January 08, 2015 at 06:23:55 PM, Hans de Goede wrote: Hi, On 08-01-15 18:06, Marek Vasut wrote: On Thursday, January 08, 2015 at 05:16:53 PM, Stephen Warren wrote: On 01/08/2015 01:34 AM, Hans de Goede wrote: Hi, Hi! On 08-01-15 01:19, Stephen Warren wrote: On 01/07/2015 04:35 PM, Marek Vasut wrote: On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: Should we rename "usb reset" to "usb restart"? No, let's not mess with the UI any more than we already did. Well, it might not be such a bad idea if the semantics are changing, to give people a heads-up? Only the semantics of "usb start" are changing, and you are suggesting renaming "usb reset" which remains unchanged ... Yes, that's true. So I suppose we should indeed not rename anything. OK, let's go with this approach now. So we are all in agreement, good, so through who's tree are these 2 patches going to go upstream ? Note I can take them upstream through the sunxi tree, but the usb tree seems better to me ... I can pick them, shall I pick them as they are ? Yes, AFAIK there were no requests for changes. Are they for -next or current ? They are intended for -next, the double usb scan when using a usb keyboard *and* booting from usb is a nuisance, but not fatal, and very few people actually use the combo, so given that current is about to be released in a couple of days lets play it safe :) Regards, Hans ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
On Thursday, January 08, 2015 at 06:23:55 PM, Hans de Goede wrote: > Hi, > > On 08-01-15 18:06, Marek Vasut wrote: > > On Thursday, January 08, 2015 at 05:16:53 PM, Stephen Warren wrote: > >> On 01/08/2015 01:34 AM, Hans de Goede wrote: > >>> Hi, > > > > Hi! > > > >>> On 08-01-15 01:19, Stephen Warren wrote: > On 01/07/2015 04:35 PM, Marek Vasut wrote: > > On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: > >>> > >>> > >> Should we rename "usb reset" to "usb restart"? > > > > No, let's not mess with the UI any more than we already did. > > Well, it might not be such a bad idea if the semantics are changing, > to give people a heads-up? > >>> > >>> Only the semantics of "usb start" are changing, and you are suggesting > >>> renaming "usb reset" which remains unchanged ... > >> > >> Yes, that's true. So I suppose we should indeed not rename anything. > > > > OK, let's go with this approach now. > > So we are all in agreement, good, so through who's tree are these 2 > patches going to go upstream ? Note I can take them upstream through > the sunxi tree, but the usb tree seems better to me ... I can pick them, shall I pick them as they are ? Are they for -next or current ? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
Hi, On 08-01-15 18:06, Marek Vasut wrote: On Thursday, January 08, 2015 at 05:16:53 PM, Stephen Warren wrote: On 01/08/2015 01:34 AM, Hans de Goede wrote: Hi, Hi! On 08-01-15 01:19, Stephen Warren wrote: On 01/07/2015 04:35 PM, Marek Vasut wrote: On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: Should we rename "usb reset" to "usb restart"? No, let's not mess with the UI any more than we already did. Well, it might not be such a bad idea if the semantics are changing, to give people a heads-up? Only the semantics of "usb start" are changing, and you are suggesting renaming "usb reset" which remains unchanged ... Yes, that's true. So I suppose we should indeed not rename anything. OK, let's go with this approach now. So we are all in agreement, good, so through who's tree are these 2 patches going to go upstream ? Note I can take them upstream through the sunxi tree, but the usb tree seems better to me ... Regards, Hans ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
On Thursday, January 08, 2015 at 05:16:53 PM, Stephen Warren wrote: > On 01/08/2015 01:34 AM, Hans de Goede wrote: > > Hi, Hi! > > On 08-01-15 01:19, Stephen Warren wrote: > >> On 01/07/2015 04:35 PM, Marek Vasut wrote: > >>> On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: > > > > > Should we rename "usb reset" to "usb restart"? > >>> > >>> No, let's not mess with the UI any more than we already did. > >> > >> Well, it might not be such a bad idea if the semantics are changing, > >> to give people a heads-up? > > > > Only the semantics of "usb start" are changing, and you are suggesting > > renaming "usb reset" which remains unchanged ... > > Yes, that's true. So I suppose we should indeed not rename anything. OK, let's go with this approach now. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
On 01/08/2015 01:34 AM, Hans de Goede wrote: Hi, On 08-01-15 01:19, Stephen Warren wrote: On 01/07/2015 04:35 PM, Marek Vasut wrote: On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: Should we rename "usb reset" to "usb restart"? No, let's not mess with the UI any more than we already did. Well, it might not be such a bad idea if the semantics are changing, to give people a heads-up? Only the semantics of "usb start" are changing, and you are suggesting renaming "usb reset" which remains unchanged ... Yes, that's true. So I suppose we should indeed not rename anything. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
Hi, On 06-01-15 18:02, Stephen Warren wrote: On 01/06/2015 06:27 AM, Hans de Goede wrote: Hi Marek & Stephen, As discussed before we've a problem where our standard bootcmds sometimes scan usb more then once, causing a large boot delay. Marek, as discussed with you before, this patch-set tackles this differently then previous sets, by simply making "usb start" a oneshot command (atleast until "usb stop" is called). Stephen the second patch then modifies config_distro_bootcmd.h to simply call "usb start" unconditionally, since calling it repeatedly now can be done without side-effects. Assuming you both like these patches, that leaves the question of how to merge them, they can be merged individually each through your own trees, or one of you can pick up both of them, I'll leave that to you. Users will have to get used to running "usb reset" rather than "usb start", but I guess that's fine. Should we rename "usb reset" to "usb restart"? Either way, the series, Acked-by: Stephen Warren Will you do something similar for SCSI? I think it would probably make sense to do something similar for SCSI, but I'm not all that familiar with the SCSI code, and I really don't have time to work on this for SCSI, so atm I do not plan to work that. Regards, Hans ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
Hi, On 08-01-15 01:19, Stephen Warren wrote: On 01/07/2015 04:35 PM, Marek Vasut wrote: On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: Should we rename "usb reset" to "usb restart"? No, let's not mess with the UI any more than we already did. Well, it might not be such a bad idea if the semantics are changing, to give people a heads-up? Only the semantics of "usb start" are changing, and you are suggesting renaming "usb reset" which remains unchanged ... Regards, Hans ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
On 01/07/2015 04:35 PM, Marek Vasut wrote: On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: On 01/06/2015 06:27 AM, Hans de Goede wrote: Hi Marek & Stephen, As discussed before we've a problem where our standard bootcmds sometimes scan usb more then once, causing a large boot delay. Marek, as discussed with you before, this patch-set tackles this differently then previous sets, by simply making "usb start" a oneshot command (atleast until "usb stop" is called). Stephen the second patch then modifies config_distro_bootcmd.h to simply call "usb start" unconditionally, since calling it repeatedly now can be done without side-effects. Assuming you both like these patches, that leaves the question of how to merge them, they can be merged individually each through your own trees, or one of you can pick up both of them, I'll leave that to you. Users will have to get used to running "usb reset" rather than "usb start", but I guess that's fine. Hi! So why do we not have "usb reset" only, why can we not discard the "usb start" altogether? The whole point is that we need separate commands for: * usb start: If USB isn't started, start it and scan the bus, else do nothing. This is used by automatic scripts that want to ensure that USB is available, but not force bus rescans over and over. * usb reset: If USB isn't started, start it. Always rescan the bus. This is used by the user to force a rescan of the USB bus, if they know they've plugged in a new device. Should we rename "usb reset" to "usb restart"? No, let's not mess with the UI any more than we already did. Well, it might not be such a bad idea if the semantics are changing, to give people a heads-up? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
On Tuesday, January 06, 2015 at 06:02:57 PM, Stephen Warren wrote: > On 01/06/2015 06:27 AM, Hans de Goede wrote: > > Hi Marek & Stephen, > > > > As discussed before we've a problem where our standard bootcmds sometimes > > scan usb more then once, causing a large boot delay. > > > > Marek, as discussed with you before, this patch-set tackles this > > differently then previous sets, by simply making "usb start" a oneshot > > command (atleast until "usb stop" is called). > > > > Stephen the second patch then modifies config_distro_bootcmd.h to simply > > call "usb start" unconditionally, since calling it repeatedly now can be > > done without side-effects. > > > > Assuming you both like these patches, that leaves the question of how to > > merge them, they can be merged individually each through your own trees, > > or one of you can pick up both of them, I'll leave that to you. > > Users will have to get used to running "usb reset" rather than "usb > start", but I guess that's fine. Hi! So why do we not have "usb reset" only, why can we not discard the "usb start" altogether? > Should we rename "usb reset" to "usb restart"? No, let's not mess with the UI any more than we already did. > Either way, the series, > Acked-by: Stephen Warren > > Will you do something similar for SCSI? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] Fix repeated USB scans problems
On 01/06/2015 06:27 AM, Hans de Goede wrote: Hi Marek & Stephen, As discussed before we've a problem where our standard bootcmds sometimes scan usb more then once, causing a large boot delay. Marek, as discussed with you before, this patch-set tackles this differently then previous sets, by simply making "usb start" a oneshot command (atleast until "usb stop" is called). Stephen the second patch then modifies config_distro_bootcmd.h to simply call "usb start" unconditionally, since calling it repeatedly now can be done without side-effects. Assuming you both like these patches, that leaves the question of how to merge them, they can be merged individually each through your own trees, or one of you can pick up both of them, I'll leave that to you. Users will have to get used to running "usb reset" rather than "usb start", but I guess that's fine. Should we rename "usb reset" to "usb restart"? Either way, the series, Acked-by: Stephen Warren Will you do something similar for SCSI? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/2] Fix repeated USB scans problems
Hi Marek & Stephen, As discussed before we've a problem where our standard bootcmds sometimes scan usb more then once, causing a large boot delay. Marek, as discussed with you before, this patch-set tackles this differently then previous sets, by simply making "usb start" a oneshot command (atleast until "usb stop" is called). Stephen the second patch then modifies config_distro_bootcmd.h to simply call "usb start" unconditionally, since calling it repeatedly now can be done without side-effects. Assuming you both like these patches, that leaves the question of how to merge them, they can be merged individually each through your own trees, or one of you can pick up both of them, I'll leave that to you. Regards, Hans ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
