Re: [U-Boot] [PATCH 0/2] tnetv107x cpsw ethernet switch driver
This patch series adds support for the cpsw ethernet switch found on tnetv107x and other SoCs from Texas Instruments. Cyril Chemparathy (2): TI: netdev: add driver for cpsw ethernet device TI: add tnetv107x evm board support for cpsw board/ti/tnetv107xevm/sdb_board.c | 155 +++ drivers/net/Makefile |1 + drivers/net/cpsw.c| 840 + include/configs/tnetv107x_evm.h | 16 + include/netdev.h | 29 ++ 5 files changed, 1041 insertions(+), 0 deletions(-) create mode 100644 drivers/net/cpsw.c Ben, Can you take a look at this series? Regards, Sandeep ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] tnetv107x cpsw ethernet switch driver
Hi Sandeep, On 8/12/2010 3:51 PM, Paulraj, Sandeep wrote: This patch series adds support for the cpsw ethernet switch found on tnetv107x and other SoCs from Texas Instruments. Cyril Chemparathy (2): TI: netdev: add driver for cpsw ethernet device TI: add tnetv107x evm board support for cpsw board/ti/tnetv107xevm/sdb_board.c | 155 +++ drivers/net/Makefile |1 + drivers/net/cpsw.c| 840 + include/configs/tnetv107x_evm.h | 16 + include/netdev.h | 29 ++ 5 files changed, 1041 insertions(+), 0 deletions(-) create mode 100644 drivers/net/cpsw.c Ben, Can you take a look at this series? I started looking at it a week ago and something came up. My first impression is that the driver needs an include file. netdev.h is reserved for device driver prototypes and common definitions. I'll try to give it a thorough review soon. Regards, Sandeep regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] tnetv107x cpsw ethernet switch driver
On Thu, Aug 12, 2010 at 7:05 PM, Ben Warren wrote: I started looking at it a week ago and something came up. My first impression is that the driver needs an include file. netdev.h is reserved for device driver prototypes and common definitions. how about starting now with a standard like include/net/ ? generally this is how linux is rolling ... include/linux/subsys/driver.h -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] tnetv107x cpsw ethernet switch driver
On 8/12/2010 6:26 PM, Mike Frysinger wrote: On Thu, Aug 12, 2010 at 7:05 PM, Ben Warren wrote: I started looking at it a week ago and something came up. My first impression is that the driver needs an include file. netdev.h is reserved for device driver prototypes and common definitions. how about starting now with a standard like include/net/ ? generally this is how linux is rolling ... include/linux/subsys/driver.h -mike Sounds reasonable. Let's use this going forward. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/2] tnetv107x cpsw ethernet switch driver
This patch series adds support for the cpsw ethernet switch found on tnetv107x and other SoCs from Texas Instruments. Cyril Chemparathy (2): TI: netdev: add driver for cpsw ethernet device TI: add tnetv107x evm board support for cpsw board/ti/tnetv107xevm/sdb_board.c | 155 +++ drivers/net/Makefile |1 + drivers/net/cpsw.c| 840 + include/configs/tnetv107x_evm.h | 16 + include/netdev.h | 29 ++ 5 files changed, 1041 insertions(+), 0 deletions(-) create mode 100644 drivers/net/cpsw.c ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
