Re: [U-Boot] [PATCH 0/3] Makefile: rework / cleanup

2010-05-18 Thread Detlev Zundel 
Hi Wolfgang,

 The top level Makefile is growing and growing. Once, wehn we suppoted
 only a few tens of boards, it was possible to implement board
 configuration logic in the Makefile, but it quickly turned out that
 this doesn't scale. Also, it is not really needed (at least not any
 more) - we noch have mechanisnms in place, that allow for more
 efficient code.

 The following patch series is an attempt to start some cleanup and
 reduce the size of the top level Makefile.  The solution is neither
 perfect nor complete - there are quite a lot of boards that resist
 such a cleanup and need more thorough cleanup.  But it's an initial
 step, showing what could and should be done, which boards have
 problems, and why this is the case.  Eentually this paves the ground
 for a more friendly way to add new board configurations.

Wow, thanks for these cleanups.  This is absolutely a good direction to
simplify the makefile.  For all three parts you have my

Acked-by: Detlev Zundel d...@denx.de

Cheers
  Detlev

-- 
As a general remark, you're more likely to get meaningful feedback if you just
submit what you think is best. You'll get more feedback when people don't like
what you did,  but any  EE will tell you that negative feedback is the path to
stability.  -- Ben Warren 4baa6f5c.5060...@gmail.com
--
DENX Software Engineering GmbH,  MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 0/3] Makefile: rework / cleanup

2010-05-15 Thread Wolfgang Denk 
The top level Makefile is growing and growing. Once, wehn we suppoted
only a few tens of boards, it was possible to implement board
configuration logic in the Makefile, but it quickly turned out that
this doesn't scale. Also, it is not really needed (at least not any
more) - we noch have mechanisnms in place, that allow for more
efficient code.

The following patch series is an attempt to start some cleanup and
reduce the size of the top level Makefile.  The solution is neither
perfect nor complete - there are quite a lot of boards that resist
such a cleanup and need more thorough cleanup.  But it's an initial
step, showing what could and should be done, which boards have
problems, and why this is the case.  Eentually this paves the ground
for a more friendly way to add new board configurations.

1/3:

Fix printing of make targets, simplify Makefile

 Makefile |  740 -
 1 files changed, 243 insertions(+), 497 deletions(-)

2/3:

Makefile: simplify handling of build target names

 Makefile |  774 ++
 mkconfig |4 +-
 2 files changed, 379 insertions(+), 399 deletions(-)

3/3:

Makefile: simplify handling of common board configurations

 Makefile | 1436 ++
 1 files changed, 607 insertions(+), 829 deletions(-)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot