Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
Hi Marek, Eddie, > On 06/07/2016 03:28 AM, Eddie Cai wrote: > > Hi Lukasz > > > > I guess you missed this mail thread. So send it again. Can you help > > to review this patch set? > > Hi, > > please rebase the series and repost. Keep me on CC I'm currently out of office. I will review those patches ASAP when I will come back. > > > 2016-01-18 14:24 GMT+08:00 Eddie Cai : > >> Hi Lukasz > >> > >> Have you back to office? Much appreciate if you can review Frank's > >> patch. > >> > >> Thanks > >> Eddie > >> > >> 2015-12-30 17:14 GMT+08:00 Lukasz Majewski : > >>> Hi Frank > >>> > [PATCH 1/3] Modified the check condition for max packet size of > ep_in in high speed > > [PATCH 2/3] Fixed the error that the last packet transmission > could not be terminated > > [PATCH 3/3] Add usb phy control to support fastboot for rk3036 > > Tested on RK3036 SDK board, it works Okay. > >>> > >>> I'm out of office till the beginning of Jan 2016. > >>> > >>> I will review and read your logs (with the max packet problem) > >>> when I come back. > >>> > > board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 > + drivers/usb/gadget/Makefile > |1 + drivers/usb/gadget/dwc2_udc_otg.c |4 +-- > drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ > drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- > drivers/usb/gadget/rk_otg_phy.c| 48 > > include/configs/rk3036_common.h| 20 7 > files changed, 107 insertions(+), 3 deletions(-) create mode > 100644 drivers/usb/gadget/rk_otg_phy.c > > >>> > >>> Best regards, > >>> Lukasz Majewski > >>> > >>> ___ > >>> U-Boot mailing list > >>> U-Boot@lists.denx.de > >>> http://lists.denx.de/mailman/listinfo/u-boot > >>> > > pgpcteF22Zute.pgp Description: OpenPGP digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
On 06/07/2016 03:28 AM, Eddie Cai wrote: > Hi Lukasz > > I guess you missed this mail thread. So send it again. Can you help to > review this patch set? Hi, please rebase the series and repost. Keep me on CC > 2016-01-18 14:24 GMT+08:00 Eddie Cai : >> Hi Lukasz >> >> Have you back to office? Much appreciate if you can review Frank's patch. >> >> Thanks >> Eddie >> >> 2015-12-30 17:14 GMT+08:00 Lukasz Majewski : >>> Hi Frank >>> [PATCH 1/3] Modified the check condition for max packet size of ep_in in high speed [PATCH 2/3] Fixed the error that the last packet transmission could not be terminated [PATCH 3/3] Add usb phy control to support fastboot for rk3036 Tested on RK3036 SDK board, it works Okay. >>> >>> I'm out of office till the beginning of Jan 2016. >>> >>> I will review and read your logs (with the max packet problem) when I >>> come back. >>> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 + drivers/usb/gadget/Makefile|1 + drivers/usb/gadget/dwc2_udc_otg.c |4 +-- drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- drivers/usb/gadget/rk_otg_phy.c| 48 include/configs/rk3036_common.h| 20 7 files changed, 107 insertions(+), 3 deletions(-) create mode 100644 drivers/usb/gadget/rk_otg_phy.c >>> >>> Best regards, >>> Lukasz Majewski >>> >>> ___ >>> U-Boot mailing list >>> U-Boot@lists.denx.de >>> http://lists.denx.de/mailman/listinfo/u-boot >>> -- Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
Hi Lukasz I guess you missed this mail thread. So send it again. Can you help to review this patch set? 2016-01-18 14:24 GMT+08:00 Eddie Cai : > Hi Lukasz > > Have you back to office? Much appreciate if you can review Frank's patch. > > Thanks > Eddie > > 2015-12-30 17:14 GMT+08:00 Lukasz Majewski : >> Hi Frank >> >>> [PATCH 1/3] Modified the check condition for max packet size of >>> ep_in in high speed >>> >>> [PATCH 2/3] Fixed the error that the last packet transmission could >>> not be terminated >>> >>> [PATCH 3/3] Add usb phy control to support fastboot for rk3036 >>> >>> Tested on RK3036 SDK board, it works Okay. >> >> I'm out of office till the beginning of Jan 2016. >> >> I will review and read your logs (with the max packet problem) when I >> come back. >> >>> >>> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 + >>> drivers/usb/gadget/Makefile|1 + >>> drivers/usb/gadget/dwc2_udc_otg.c |4 +-- >>> drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ >>> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- >>> drivers/usb/gadget/rk_otg_phy.c| 48 >>> >>> include/configs/rk3036_common.h| 20 7 >>> files changed, 107 insertions(+), 3 deletions(-) create mode 100644 >>> drivers/usb/gadget/rk_otg_phy.c >>> >> >> Best regards, >> Lukasz Majewski >> >> ___ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot >> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
Hi Lukasz Have you back to office? Much appreciate if you can review Frank's patch. Thanks Eddie 2015-12-30 17:14 GMT+08:00 Lukasz Majewski : > Hi Frank > >> [PATCH 1/3] Modified the check condition for max packet size of >> ep_in in high speed >> >> [PATCH 2/3] Fixed the error that the last packet transmission could >> not be terminated >> >> [PATCH 3/3] Add usb phy control to support fastboot for rk3036 >> >> Tested on RK3036 SDK board, it works Okay. > > I'm out of office till the beginning of Jan 2016. > > I will review and read your logs (with the max packet problem) when I > come back. > >> >> board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 + >> drivers/usb/gadget/Makefile|1 + >> drivers/usb/gadget/dwc2_udc_otg.c |4 +-- >> drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ >> drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- >> drivers/usb/gadget/rk_otg_phy.c| 48 >> >> include/configs/rk3036_common.h| 20 7 >> files changed, 107 insertions(+), 3 deletions(-) create mode 100644 >> drivers/usb/gadget/rk_otg_phy.c >> > > Best regards, > Lukasz Majewski > > ___ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
Hi Frank > [PATCH 1/3] Modified the check condition for max packet size of > ep_in in high speed > > [PATCH 2/3] Fixed the error that the last packet transmission could > not be terminated > > [PATCH 3/3] Add usb phy control to support fastboot for rk3036 > > Tested on RK3036 SDK board, it works Okay. I'm out of office till the beginning of Jan 2016. I will review and read your logs (with the max packet problem) when I come back. > > board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 + > drivers/usb/gadget/Makefile|1 + > drivers/usb/gadget/dwc2_udc_otg.c |4 +-- > drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ > drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- > drivers/usb/gadget/rk_otg_phy.c| 48 > > include/configs/rk3036_common.h| 20 7 > files changed, 107 insertions(+), 3 deletions(-) create mode 100644 > drivers/usb/gadget/rk_otg_phy.c > Best regards, Lukasz Majewski pgpaGble2yCkO.pgp Description: OpenPGP digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
Hi Lukasz, Friendly Ping! Could you help to review this series of patches in your free time? BR. Frank On 12/23/2015 08:10 AM, Marek Vasut wrote: On Tuesday, December 22, 2015 at 09:25:49 AM, Frank Wang wrote: [PATCH 1/3] Modified the check condition for max packet size of ep_in in high speed [PATCH 2/3] Fixed the error that the last packet transmission could not be terminated [PATCH 3/3] Add usb phy control to support fastboot for rk3036 Tested on RK3036 SDK board, it works Okay. board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 + drivers/usb/gadget/Makefile|1 + drivers/usb/gadget/dwc2_udc_otg.c |4 +-- drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- drivers/usb/gadget/rk_otg_phy.c| 48 include/configs/rk3036_common.h| 20 7 files changed, 107 insertions(+), 3 deletions(-) create mode 100644 drivers/usb/gadget/rk_otg_phy.c Series looks sensible to me, but I'd like to have Lukasz take a look at it and review it thoroughly too. Thanks! Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
On Tuesday, December 22, 2015 at 09:25:49 AM, Frank Wang wrote: > [PATCH 1/3] Modified the check condition for max packet size of ep_in in > high speed > > [PATCH 2/3] Fixed the error that the last packet transmission could not be > terminated > > [PATCH 3/3] Add usb phy control to support fastboot for rk3036 > > Tested on RK3036 SDK board, it works Okay. > > board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 + > drivers/usb/gadget/Makefile|1 + > drivers/usb/gadget/dwc2_udc_otg.c |4 +-- > drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ > drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- > drivers/usb/gadget/rk_otg_phy.c| 48 > include/configs/rk3036_common.h| > 20 > 7 files changed, 107 insertions(+), 3 deletions(-) > create mode 100644 drivers/usb/gadget/rk_otg_phy.c Series looks sensible to me, but I'd like to have Lukasz take a look at it and review it thoroughly too. Thanks! Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/3] This series adds support for fastboot related to USB.
[PATCH 1/3] Modified the check condition for max packet size of ep_in in high speed [PATCH 2/3] Fixed the error that the last packet transmission could not be terminated [PATCH 3/3] Add usb phy control to support fastboot for rk3036 Tested on RK3036 SDK board, it works Okay. board/evb_rk3036/evb_rk3036/evb_rk3036.c | 30 + drivers/usb/gadget/Makefile|1 + drivers/usb/gadget/dwc2_udc_otg.c |4 +-- drivers/usb/gadget/dwc2_udc_otg_regs.h |5 +++ drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c |2 +- drivers/usb/gadget/rk_otg_phy.c| 48 include/configs/rk3036_common.h| 20 7 files changed, 107 insertions(+), 3 deletions(-) create mode 100644 drivers/usb/gadget/rk_otg_phy.c -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
