Re: [U-Boot] [PATCH 0/4] nand: davinci: enable driver model for NAND
On Wed, Jul 03, 2019 at 03:01:15PM +0200, Bartosz Golaszewski wrote: > pt., 7 cze 2019 o 10:16 Bartosz Golaszewski napisał(a): > > > > czw., 6 cze 2019 o 17:58 Adam Ford napisał(a): > > > > > > On Thu, Jun 6, 2019 at 10:50 AM Bartosz Golaszewski wrote: > > > > > > > > From: Bartosz Golaszewski > > > > > > > > This series enables the driver model for NAND on davinci da850 boards. > > > > > > > > The first patch is a simple tweak for an unnecessarily exported > > > > function. > > > > > > > > The second patch extends the NAND driver to support both legacy and > > > > driver-model users. For now we don't parse the device-tree as it's a > > > > bit complicated on da850, namely: the nand node is a child of the > > > > aemif node for which we don't have a driver in u-boot (unlike on linux > > > > where the aemif driver populates all its subnodes). In order for the > > > > nand device to be probed, we're adding a dummy node to the u-boot dts > > > > extensions with an appropriate compatible. > > > > > > > > Two last patches enable driver model for NAND on da850-lcdk and > > > > da850-evm. > > > > We don't enable the driver model in SPL as first: the patches enabling > > > > CONFIG_SPL_DM are still waiting to be merged, and second: the > > > > nand_spl_simple driver used by davinci SPL doesn't support driver model > > > > users. This is planned for future series once some basic support is > > > > merged. > > > > > > What happens when the board is booting SPL from NAND? Will it still > > > work as expected? I know the da850-evm has at least one configuration > > > which this is intended to boot from NAND instead of the default SPI > > > flash. > > > > > > > The driver works just like before in SPL. The support for the driver > > model is added incrementally. In fact I tested it on da850-lcdk with > > SPL loading u-boot from NAND. > > > > On da850-evm we could probably enable driver-model in SPL as well for > > NAND, but I prefer to do it at once for both boards. > > > > Bart > > > > > adam > > > > > > > > > > > Bartosz Golaszewski (4): > > > > nand: davinci: make davinci_nand_init() static > > > > nand: davinci: add support for driver model > > > > davinci: omapl138-lcdk: enable driver model for NAND > > > > davinci: da850-evm: enable driver model for NAND > > > > > > > > arch/arm/dts/da850-evm-u-boot.dtsi| 4 ++ > > > > arch/arm/dts/da850-lcdk-u-boot.dtsi | 4 ++ > > > > arch/arm/include/asm/ti-common/davinci_nand.h | 2 - > > > > configs/da850evm_defconfig| 1 + > > > > configs/da850evm_direct_nor_defconfig | 1 + > > > > configs/da850evm_nand_defconfig | 1 + > > > > configs/omapl138_lcdk_defconfig | 1 + > > > > drivers/mtd/nand/raw/davinci_nand.c | 48 ++- > > > > include/configs/da850evm.h| 4 ++ > > > > include/configs/omapl138_lcdk.h | 4 ++ > > > > 10 files changed, 66 insertions(+), 4 deletions(-) > > > > > > > > -- > > > > 2.21.0 > > > > > > Hi Tom, > > can you pick up this series? Post-release, yes, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] nand: davinci: enable driver model for NAND
pt., 7 cze 2019 o 10:16 Bartosz Golaszewski napisał(a): > > czw., 6 cze 2019 o 17:58 Adam Ford napisał(a): > > > > On Thu, Jun 6, 2019 at 10:50 AM Bartosz Golaszewski wrote: > > > > > > From: Bartosz Golaszewski > > > > > > This series enables the driver model for NAND on davinci da850 boards. > > > > > > The first patch is a simple tweak for an unnecessarily exported function. > > > > > > The second patch extends the NAND driver to support both legacy and > > > driver-model users. For now we don't parse the device-tree as it's a > > > bit complicated on da850, namely: the nand node is a child of the > > > aemif node for which we don't have a driver in u-boot (unlike on linux > > > where the aemif driver populates all its subnodes). In order for the > > > nand device to be probed, we're adding a dummy node to the u-boot dts > > > extensions with an appropriate compatible. > > > > > > Two last patches enable driver model for NAND on da850-lcdk and da850-evm. > > > We don't enable the driver model in SPL as first: the patches enabling > > > CONFIG_SPL_DM are still waiting to be merged, and second: the > > > nand_spl_simple driver used by davinci SPL doesn't support driver model > > > users. This is planned for future series once some basic support is > > > merged. > > > > What happens when the board is booting SPL from NAND? Will it still > > work as expected? I know the da850-evm has at least one configuration > > which this is intended to boot from NAND instead of the default SPI > > flash. > > > > The driver works just like before in SPL. The support for the driver > model is added incrementally. In fact I tested it on da850-lcdk with > SPL loading u-boot from NAND. > > On da850-evm we could probably enable driver-model in SPL as well for > NAND, but I prefer to do it at once for both boards. > > Bart > > > adam > > > > > > > > Bartosz Golaszewski (4): > > > nand: davinci: make davinci_nand_init() static > > > nand: davinci: add support for driver model > > > davinci: omapl138-lcdk: enable driver model for NAND > > > davinci: da850-evm: enable driver model for NAND > > > > > > arch/arm/dts/da850-evm-u-boot.dtsi| 4 ++ > > > arch/arm/dts/da850-lcdk-u-boot.dtsi | 4 ++ > > > arch/arm/include/asm/ti-common/davinci_nand.h | 2 - > > > configs/da850evm_defconfig| 1 + > > > configs/da850evm_direct_nor_defconfig | 1 + > > > configs/da850evm_nand_defconfig | 1 + > > > configs/omapl138_lcdk_defconfig | 1 + > > > drivers/mtd/nand/raw/davinci_nand.c | 48 ++- > > > include/configs/da850evm.h| 4 ++ > > > include/configs/omapl138_lcdk.h | 4 ++ > > > 10 files changed, 66 insertions(+), 4 deletions(-) > > > > > > -- > > > 2.21.0 > > > Hi Tom, can you pick up this series? Bart ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] nand: davinci: enable driver model for NAND
czw., 6 cze 2019 o 17:58 Adam Ford napisał(a): > > On Thu, Jun 6, 2019 at 10:50 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > This series enables the driver model for NAND on davinci da850 boards. > > > > The first patch is a simple tweak for an unnecessarily exported function. > > > > The second patch extends the NAND driver to support both legacy and > > driver-model users. For now we don't parse the device-tree as it's a > > bit complicated on da850, namely: the nand node is a child of the > > aemif node for which we don't have a driver in u-boot (unlike on linux > > where the aemif driver populates all its subnodes). In order for the > > nand device to be probed, we're adding a dummy node to the u-boot dts > > extensions with an appropriate compatible. > > > > Two last patches enable driver model for NAND on da850-lcdk and da850-evm. > > We don't enable the driver model in SPL as first: the patches enabling > > CONFIG_SPL_DM are still waiting to be merged, and second: the > > nand_spl_simple driver used by davinci SPL doesn't support driver model > > users. This is planned for future series once some basic support is > > merged. > > What happens when the board is booting SPL from NAND? Will it still > work as expected? I know the da850-evm has at least one configuration > which this is intended to boot from NAND instead of the default SPI > flash. > The driver works just like before in SPL. The support for the driver model is added incrementally. In fact I tested it on da850-lcdk with SPL loading u-boot from NAND. On da850-evm we could probably enable driver-model in SPL as well for NAND, but I prefer to do it at once for both boards. Bart > adam > > > > > Bartosz Golaszewski (4): > > nand: davinci: make davinci_nand_init() static > > nand: davinci: add support for driver model > > davinci: omapl138-lcdk: enable driver model for NAND > > davinci: da850-evm: enable driver model for NAND > > > > arch/arm/dts/da850-evm-u-boot.dtsi| 4 ++ > > arch/arm/dts/da850-lcdk-u-boot.dtsi | 4 ++ > > arch/arm/include/asm/ti-common/davinci_nand.h | 2 - > > configs/da850evm_defconfig| 1 + > > configs/da850evm_direct_nor_defconfig | 1 + > > configs/da850evm_nand_defconfig | 1 + > > configs/omapl138_lcdk_defconfig | 1 + > > drivers/mtd/nand/raw/davinci_nand.c | 48 ++- > > include/configs/da850evm.h| 4 ++ > > include/configs/omapl138_lcdk.h | 4 ++ > > 10 files changed, 66 insertions(+), 4 deletions(-) > > > > -- > > 2.21.0 > > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4] nand: davinci: enable driver model for NAND
On Thu, Jun 6, 2019 at 10:50 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > This series enables the driver model for NAND on davinci da850 boards. > > The first patch is a simple tweak for an unnecessarily exported function. > > The second patch extends the NAND driver to support both legacy and > driver-model users. For now we don't parse the device-tree as it's a > bit complicated on da850, namely: the nand node is a child of the > aemif node for which we don't have a driver in u-boot (unlike on linux > where the aemif driver populates all its subnodes). In order for the > nand device to be probed, we're adding a dummy node to the u-boot dts > extensions with an appropriate compatible. > > Two last patches enable driver model for NAND on da850-lcdk and da850-evm. > We don't enable the driver model in SPL as first: the patches enabling > CONFIG_SPL_DM are still waiting to be merged, and second: the > nand_spl_simple driver used by davinci SPL doesn't support driver model > users. This is planned for future series once some basic support is > merged. What happens when the board is booting SPL from NAND? Will it still work as expected? I know the da850-evm has at least one configuration which this is intended to boot from NAND instead of the default SPI flash. adam > > Bartosz Golaszewski (4): > nand: davinci: make davinci_nand_init() static > nand: davinci: add support for driver model > davinci: omapl138-lcdk: enable driver model for NAND > davinci: da850-evm: enable driver model for NAND > > arch/arm/dts/da850-evm-u-boot.dtsi| 4 ++ > arch/arm/dts/da850-lcdk-u-boot.dtsi | 4 ++ > arch/arm/include/asm/ti-common/davinci_nand.h | 2 - > configs/da850evm_defconfig| 1 + > configs/da850evm_direct_nor_defconfig | 1 + > configs/da850evm_nand_defconfig | 1 + > configs/omapl138_lcdk_defconfig | 1 + > drivers/mtd/nand/raw/davinci_nand.c | 48 ++- > include/configs/da850evm.h| 4 ++ > include/configs/omapl138_lcdk.h | 4 ++ > 10 files changed, 66 insertions(+), 4 deletions(-) > > -- > 2.21.0 > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 0/4] nand: davinci: enable driver model for NAND
From: Bartosz Golaszewski This series enables the driver model for NAND on davinci da850 boards. The first patch is a simple tweak for an unnecessarily exported function. The second patch extends the NAND driver to support both legacy and driver-model users. For now we don't parse the device-tree as it's a bit complicated on da850, namely: the nand node is a child of the aemif node for which we don't have a driver in u-boot (unlike on linux where the aemif driver populates all its subnodes). In order for the nand device to be probed, we're adding a dummy node to the u-boot dts extensions with an appropriate compatible. Two last patches enable driver model for NAND on da850-lcdk and da850-evm. We don't enable the driver model in SPL as first: the patches enabling CONFIG_SPL_DM are still waiting to be merged, and second: the nand_spl_simple driver used by davinci SPL doesn't support driver model users. This is planned for future series once some basic support is merged. Bartosz Golaszewski (4): nand: davinci: make davinci_nand_init() static nand: davinci: add support for driver model davinci: omapl138-lcdk: enable driver model for NAND davinci: da850-evm: enable driver model for NAND arch/arm/dts/da850-evm-u-boot.dtsi| 4 ++ arch/arm/dts/da850-lcdk-u-boot.dtsi | 4 ++ arch/arm/include/asm/ti-common/davinci_nand.h | 2 - configs/da850evm_defconfig| 1 + configs/da850evm_direct_nor_defconfig | 1 + configs/da850evm_nand_defconfig | 1 + configs/omapl138_lcdk_defconfig | 1 + drivers/mtd/nand/raw/davinci_nand.c | 48 ++- include/configs/da850evm.h| 4 ++ include/configs/omapl138_lcdk.h | 4 ++ 10 files changed, 66 insertions(+), 4 deletions(-) -- 2.21.0 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
