Re: [U-Boot] [PATCH 0/4 v2] Makefile: rework / cleanup
Wolfgang Denk wrote: > Dear Thomas Chou, > > In message <4bff1e99.8020...@wytron.com.tw> you wrote: >> Build and tested nios2 on boards. > > Thanks. > > Could you please send a formal "Tested-by:" ? Dear Wolfgang, I would suggest that we can remove the nios2-generic rule from the Makefile altogether. Then add this to boards.cfg. nios2-generic nios2 nios2 nios2-generic altera Instances of nios2-generic can be added to boards.cfg in the same way. Your solution is cleaner. I have tested this update, too. Tested-by: Thomas Chou ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4 v2] Makefile: rework / cleanup
Scott McNutt wrote: > Wolfgang Denk wrote: >> In message <4bff1e99.8020...@wytron.com.tw> you wrote: > >>> But old nios-32 arch is broken and will be removed soon. Shall I >>> perform the removal based on current head or after these patches >>> applied? >> >> I don't really care - the chages are simple enough. >> >> I see your patch - if this is OK with Scott I think we could / should >> even include this in the upcoming 2006.06 release. Scott, what do you >> think? > > Let's do it asap. Thomas, if you can rebase this to the nios next > branch, I'll pull it in and submit a pull request this afternoon > that will include the other pending patches. > > Thanks, > --Scott > > > Hi Scott, Great! Please pull the branch which is rebased to nios next. git://sopc.et.ntust.edu.tw/git/u-boot.git rm_nios32_v2 Cheers, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4 v2] Makefile: rework / cleanup
Wolfgang Denk wrote: > In message <4bff1e99.8020...@wytron.com.tw> you wrote: >> But old nios-32 arch is broken and will be removed soon. Shall I perform >> the removal based on current head or after these patches applied? > > I don't really care - the chages are simple enough. > > I see your patch - if this is OK with Scott I think we could / should > even include this in the upcoming 2006.06 release. Scott, what do you > think? Let's do it asap. Thomas, if you can rebase this to the nios next branch, I'll pull it in and submit a pull request this afternoon that will include the other pending patches. Thanks, --Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4 v2] Makefile: rework / cleanup
Dear Thomas Chou, In message <4bff1e99.8020...@wytron.com.tw> you wrote: > > Build and tested nios2 on boards. Thanks. Could you please send a formal "Tested-by:" ? > But old nios-32 arch is broken and will be removed soon. Shall I perform > the removal based on current head or after these patches applied? I don't really care - the chages are simple enough. I see your patch - if this is OK with Scott I think we could / should even include this in the upcoming 2006.06 release. Scott, what do you think? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Artificial Intelligence is the study of how to make real computers act like the ones in movies. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/4 v2] Makefile: rework / cleanup
Wolfgang Denk wrote: > The top level Makefile is growing and growing. Once, when we > supported only a few tens of boards, it was possible to implement > board configuration logic in the Makefile, but it quickly turned out > that this doesn't scale. Also, it is not really needed (at least not > any more) - we now have mechanisnms in place, that allow for more > efficient code. Dear Wolfgang, Build and tested nios2 on boards. But old nios-32 arch is broken and will be removed soon. Shall I perform the removal based on current head or after these patches applied? Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 0/4 v2] Makefile: rework / cleanup
The top level Makefile is growing and growing. Once, when we supported only a few tens of boards, it was possible to implement board configuration logic in the Makefile, but it quickly turned out that this doesn't scale. Also, it is not really needed (at least not any more) - we now have mechanisnms in place, that allow for more efficient code. The following patch series is an attempt to start some cleanup and reduce the size of the top level Makefile. The solution is neither perfect nor complete - there are quite a lot of boards that resist such a cleanup and need more thorough rework. But it's an initial step, showing what could and should be done, which boards have problems, and why this is the case. Eventually this paves the ground for a more friendly way to add new board configurations. The idea is to have all "board descriptions" in a single data base in form of a plain text file - no need to add anything to the top level Makefile, and eventually also tools like the "MAKEALL" script can be replaced / simplified because they can fetch all needed board information from that data base. 1/4: Fix printing of make targets, simplify Makefile Makefile | 740 - 1 files changed, 243 insertions(+), 497 deletions(-) 2/4: Makefile: simplify handling of build target names Makefile | 774 ++ mkconfig |6 +- 2 files changed, 380 insertions(+), 400 deletions(-) 3/4: Makefile: simplify handling of common board configurations Makefile | 1436 ++ 1 files changed, 607 insertions(+), 829 deletions(-) 4/4: Makefile/mkconfig: read simple board configurations from boards.cfg Makefile | 823 ++-- boards.cfg | 356 ++ mkconfig | 72 -- 3 files changed, 431 insertions(+), 820 deletions(-) create mode 100644 boards.cfg ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
