Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On 03/03/2012 13:02, Marek Vasut wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. Hi Marek, Marek Vasut (18): CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c CHECKPATCH: ./board/esd/du405/fpgadata.c CHECKPATCH: ./board/esd/canbt/fpgadata.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c CHECKPATCH: ./board/esd/wuh405/fpgadata.c CHECKPATCH: ./board/esd/plu405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c CHECKPATCH: ./board/esd/ash405/fpgadata.c CHECKPATCH: ./board/esd/voh405/fpgadata.c CHECKPATCH: ./board/esd/apc405/fpgadata.c CHECKPATCH: ./board/esd/tasreg/fpgadata.c CHECKPATCH: ./board/esd/pci405/fpgadata.c CHECKPATCH: ./board/esd/hh405/fpgadata.c board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c| 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. Are you up for applying these ? :-) In the thread Wolfgang says that he is going to apply the whole patchset to the -next branch, and he has already done. Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Dear Stefano Babic, On 03/03/2012 13:02, Marek Vasut wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. Hi Marek, Marek Vasut (18): CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c CHECKPATCH: ./board/esd/du405/fpgadata.c CHECKPATCH: ./board/esd/canbt/fpgadata.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c CHECKPATCH: ./board/esd/wuh405/fpgadata.c CHECKPATCH: ./board/esd/plu405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c CHECKPATCH: ./board/esd/ash405/fpgadata.c CHECKPATCH: ./board/esd/voh405/fpgadata.c CHECKPATCH: ./board/esd/apc405/fpgadata.c CHECKPATCH: ./board/esd/tasreg/fpgadata.c CHECKPATCH: ./board/esd/pci405/fpgadata.c CHECKPATCH: ./board/esd/hh405/fpgadata.c board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c | 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. Are you up for applying these ? :-) In the thread Wolfgang says that he is going to apply the whole patchset to the -next branch, and he has already done. Stefano I see, that's correct. Thanks! Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. Marek Vasut (18): CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c CHECKPATCH: ./board/esd/du405/fpgadata.c CHECKPATCH: ./board/esd/canbt/fpgadata.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c CHECKPATCH: ./board/esd/wuh405/fpgadata.c CHECKPATCH: ./board/esd/plu405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c CHECKPATCH: ./board/esd/ash405/fpgadata.c CHECKPATCH: ./board/esd/voh405/fpgadata.c CHECKPATCH: ./board/esd/apc405/fpgadata.c CHECKPATCH: ./board/esd/tasreg/fpgadata.c CHECKPATCH: ./board/esd/pci405/fpgadata.c CHECKPATCH: ./board/esd/hh405/fpgadata.c board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c| 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. Are you up for applying these ? :-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Dear Stefan Roese, In message 201112151715.35434...@denx.de you wrote: Okay. If nobody objects I'll queue these patches up in u-boot-ppc4xx/next in the next few days. Hm... I think I will just pull this whole list of checkpatch patches directly into next. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Men of peace usually are [brave]. -- Spock, The Savage Curtain, stardate 5906.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Dear Matthias Fuchs, In message 4eea14e6.2020...@esd.eu you wrote: Hi Marek, thanks for that work. The patches against the esd files are Acked-by: Matthias Fuchs matthias.fu...@esd.eu Sorry, but doing it this way is a pretty reliable way that your Acked-by: gets _lost_. We don't add these manually, instead we trust that PatchWork will collect this information for us, so it is essential that you sned proper replies to the patches you are actually ACKing. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Conceptual integrity in turn dictates that the design must proceed from one mind, or from a very small number of agreeing resonant minds. - Frederick Brooks Jr., The Mythical Man Month ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Dear Anatolij Gustschin, In message 20111215181509.57c6535d@wker you wrote: On Thu, 15 Dec 2011 14:26:41 +0100 Marek Vasut marek.va...@gmail.com wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. ... For all 18 patches: Acked-by: Anatolij Gustschin ag...@denx.de Sorry, this information gets lost, too. See http://article.gmane.org/gmane.comp.boot-loaders.u-boot/120706 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Keep your head and your heart going in the right direction and you will not have to worry about your feet. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Thursday 15 December 2011 08:26:41 Marek Vasut wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. i don't really see any point in touching the fpgadata.c files. they're clearly generated files and not meant to be read at all let alone modified after the fact ... of course, i'd wonder what created these in the first place, and apply any style tastes to that tool and then regenerate the result ... -mike Well when the person updates these, he will hit a problem and fix his tool. Though last update of these is 3 years ago (maybe four). Most of them date back to 2003 though. The reason is to make it all checkpatch clean. M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Friday 16 December 2011 04:54:42 Marek Vasut wrote: On Thursday 15 December 2011 08:26:41 Marek Vasut wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. i don't really see any point in touching the fpgadata.c files. they're clearly generated files and not meant to be read at all let alone modified after the fact ... of course, i'd wonder what created these in the first place, and apply any style tastes to that tool and then regenerate the result ... Well when the person updates these, he will hit a problem and fix his tool. no he won't. these files get clobbered and committed, not inline merged. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Friday 16 December 2011 04:54:42 Marek Vasut wrote: The reason is to make it all checkpatch clean. also, it's questionable whether this goal even makes sense. but i've said this many times in the past, and people don't seem to care. they've got their useless blinders on. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. Marek Vasut (18): CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c CHECKPATCH: ./board/esd/du405/fpgadata.c CHECKPATCH: ./board/esd/canbt/fpgadata.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c CHECKPATCH: ./board/esd/wuh405/fpgadata.c CHECKPATCH: ./board/esd/plu405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c CHECKPATCH: ./board/esd/ash405/fpgadata.c CHECKPATCH: ./board/esd/voh405/fpgadata.c CHECKPATCH: ./board/esd/apc405/fpgadata.c CHECKPATCH: ./board/esd/tasreg/fpgadata.c CHECKPATCH: ./board/esd/pci405/fpgadata.c CHECKPATCH: ./board/esd/hh405/fpgadata.c board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c| 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. -- 1.7.7.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. Marek Vasut (18): CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c CHECKPATCH: ./board/esd/du405/fpgadata.c CHECKPATCH: ./board/esd/canbt/fpgadata.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c CHECKPATCH: ./board/esd/wuh405/fpgadata.c CHECKPATCH: ./board/esd/plu405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c CHECKPATCH: ./board/esd/ash405/fpgadata.c CHECKPATCH: ./board/esd/voh405/fpgadata.c CHECKPATCH: ./board/esd/apc405/fpgadata.c CHECKPATCH: ./board/esd/tasreg/fpgadata.c CHECKPATCH: ./board/esd/pci405/fpgadata.c CHECKPATCH: ./board/esd/hh405/fpgadata.c board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c| 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. Stefan, adding you to CC, can you please review this patches ? Thanks! M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, On Thursday 15 December 2011 14:34:08 Marek Vasut wrote: board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c| 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. Stefan, adding you to CC, can you please review this patches ? Matthias from esd is responsible for this code now (added to Cc). IIRC, then this code was automatically generated by some tool (FPGA binary data - C code). But still: Acked-by: Stefan Roese s...@denx.de Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, On Thursday 15 December 2011 14:34:08 Marek Vasut wrote: board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c | 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. Stefan, adding you to CC, can you please review this patches ? Matthias from esd is responsible for this code now (added to Cc). IIRC, then this code was automatically generated by some tool (FPGA binary data - C code). But still: Acked-by: Stefan Roese s...@denx.de Thanks for adding him. Also, I submitted further set of realignment patches. Who will merge this, shall I do and push or will you do it ? Thanks! M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, On Thu, 15 Dec 2011 14:26:41 +0100 Marek Vasut marek.va...@gmail.com wrote: ... 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. I'll look at these patches. Yes, some video drivers files are on my checkpatch cleanup TODO list. Thanks, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Thursday 15 December 2011 14:50:16 Marek Vasut wrote: Matthias from esd is responsible for this code now (added to Cc). IIRC, then this code was automatically generated by some tool (FPGA binary data - C code). But still: Acked-by: Stefan Roese s...@denx.de Thanks for adding him. Also, I submitted further set of realignment patches. Yes, saw them: Acked-by: Stefan Roese s...@denx.de Who will merge this, shall I do and push or will you do it ? Please go ahead and merge yourself. Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, On Thu, 15 Dec 2011 14:26:41 +0100 Marek Vasut marek.va...@gmail.com wrote: ... 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. I'll look at these patches. Yes, some video drivers files are on my checkpatch cleanup TODO list. Well I can share the complete list of files that fail checkpatch. I ran checkpatch -f on the whole tree (.c and .h files) a few days ago :-) It ran for 5+ hours ;-) M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Dear Stefan Roese, In message 201112151502.30771...@denx.de you wrote: Who will merge this, shall I do and push or will you do it ? Please go ahead and merge yourself. No. I want to maintain a 4 eye principle for all patches. Custodians can push any patches _but_their_own_ to u-boot-staging. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Reader, suppose you were an idiot. And suppose you were a member of Congress. But I repeat myself. - Mark Twain ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, On Thu, 15 Dec 2011 14:26:41 +0100 Marek Vasut marek.va...@gmail.com wrote: ... 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. I'll look at these patches. Yes, some video drivers files are on my checkpatch cleanup TODO list. Well I can share the complete list of files that fail checkpatch. I ran checkpatch -f on the whole tree (.c and .h files) a few days ago :-) It ran for 5+ hours ;-) http://marex.hackndev.com/fail-list.txt This is after applying these two patchsets (logo and fpga) and partly cleaning up board/esd/) btw. let's queue these (both logo and fpga) patches for -next please. They are not urgent and I'd like to see my stats for this release not tainted by this patchbomb. Also, I'll share the partial cleanup of ESD boards if Matthias/Stefan is interested. I checked how arch/arm is also broken and me being mostly ARM guy, I'd like to continue cleaning up there. Thanks M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, thanks for that work. The patches against the esd files are Acked-by: Matthias Fuchs matthias.fu...@esd.eu Matthias On 15.12.2011 14:26, Marek Vasut wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. Marek Vasut (18): CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c CHECKPATCH: ./board/esd/du405/fpgadata.c CHECKPATCH: ./board/esd/canbt/fpgadata.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c CHECKPATCH: ./board/esd/wuh405/fpgadata.c CHECKPATCH: ./board/esd/plu405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c CHECKPATCH: ./board/esd/ash405/fpgadata.c CHECKPATCH: ./board/esd/voh405/fpgadata.c CHECKPATCH: ./board/esd/apc405/fpgadata.c CHECKPATCH: ./board/esd/tasreg/fpgadata.c CHECKPATCH: ./board/esd/pci405/fpgadata.c CHECKPATCH: ./board/esd/hh405/fpgadata.c board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c| 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. -- Dipl.-Ing. Matthias Fuchs Head of System Design esd electronic system design gmbh Vahrenwalder Str. 207 - 30165 Hannover - GERMANY Phone: +49-511-37298-0 - Fax: +49-511-37298-68 Please visit our homepage http://www.esd.eu Quality Products - Made in Germany Besuchen Sie uns auf der embedded world 2012 in Halle 4, Stand 129 vom 28. Februar - 01. März 2012 in Nürnberg! Geschäftsführer: Klaus Detering Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832 - ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, On 15.12.2011 16:17, Marek Vasut wrote: Hi Marek, On Thu, 15 Dec 2011 14:26:41 +0100 Marek Vasut marek.va...@gmail.com wrote: ... 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. I'll look at these patches. Yes, some video drivers files are on my checkpatch cleanup TODO list. Well I can share the complete list of files that fail checkpatch. I ran checkpatch -f on the whole tree (.c and .h files) a few days ago :-) It ran for 5+ hours ;-) http://marex.hackndev.com/fail-list.txt This is after applying these two patchsets (logo and fpga) and partly cleaning up board/esd/) btw. let's queue these (both logo and fpga) patches for -next please. They are not urgent and I'd like to see my stats for this release not tainted by this patchbomb. Also, I'll share the partial cleanup of ESD boards if Matthias/Stefan is interested. I checked how arch/arm is also broken and me being mostly ARM guy, I'd like to continue cleaning up there. I would do that clean up by myself for the esd files. As long as we do not have a strict timeline for this, I will see if I could start with that in January. I will also check if we could get rid of some boards that are not active anymore. Matthias ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Thursday 15 December 2011 16:17:06 Marek Vasut wrote: Well I can share the complete list of files that fail checkpatch. I ran checkpatch -f on the whole tree (.c and .h files) a few days ago :-) It ran for 5+ hours ;-) http://marex.hackndev.com/fail-list.txt This is after applying these two patchsets (logo and fpga) and partly cleaning up board/esd/) btw. let's queue these (both logo and fpga) patches for -next please. They are not urgent and I'd like to see my stats for this release not tainted by this patchbomb. Okay. If nobody objects I'll queue these patches up in u-boot-ppc4xx/next in the next few days. Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Thu, 15 Dec 2011 14:26:41 +0100 Marek Vasut marek.va...@gmail.com wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. Marek Vasut (18): CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c CHECKPATCH: ./board/esd/du405/fpgadata.c CHECKPATCH: ./board/esd/canbt/fpgadata.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c CHECKPATCH: ./board/esd/wuh405/fpgadata.c CHECKPATCH: ./board/esd/plu405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata.c CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c CHECKPATCH: ./board/esd/ash405/fpgadata.c CHECKPATCH: ./board/esd/voh405/fpgadata.c CHECKPATCH: ./board/esd/apc405/fpgadata.c CHECKPATCH: ./board/esd/tasreg/fpgadata.c CHECKPATCH: ./board/esd/pci405/fpgadata.c CHECKPATCH: ./board/esd/hh405/fpgadata.c board/dave/PPChameleonEVB/fpgadata.c | 3416 +--- board/esd/apc405/fpgadata.c| 6012 board/esd/ar405/fpgadata.c | 8250 +++-- board/esd/ar405/fpgadata_xl30.c| 7308 ++- board/esd/ash405/fpgadata.c| 7475 ++- board/esd/canbt/fpgadata.c | 1211 ++- board/esd/cpci405/fpgadata_cpci405.c | 1025 ++- board/esd/cpci405/fpgadata_cpci4052.c | 2294 +++-- board/esd/cpci405/fpgadata_cpci405ab.c | 3854 +--- board/esd/cpciiser4/fpgadata.c | 6204 +- board/esd/dasa_sim/fpgadata.c | 5855 board/esd/du405/fpgadata.c | 2108 +++-- board/esd/hh405/fpgadata.c | 7551 ++- board/esd/pci405/fpgadata.c| 2238 +++-- board/esd/plu405/fpgadata.c| 3537 +--- board/esd/tasreg/fpgadata.c|15992 +--- board/esd/voh405/fpgadata.c| 6032 board/esd/wuh405/fpgadata.c| 5454 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. For all 18 patches: Acked-by: Anatolij Gustschin ag...@denx.de Thanks, Anatolij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
Hi Marek, On 15.12.2011 16:17, Marek Vasut wrote: Hi Marek, On Thu, 15 Dec 2011 14:26:41 +0100 Marek Vasut marek.va...@gmail.com wrote: ... 18 files changed, 63874 insertions(+), 31942 deletions(-) V2: Align to 8 bytes per line. Cc: Anatolij Gustschin ag...@denx.de Cc: Stefano Babic sba...@denx.de Anatolij, Stefano, can you skim through these and give me your ACK so I can push them through staging ? Still, there is around three thousand files that don't conform to checkpatch style. I'll look at these patches. Yes, some video drivers files are on my checkpatch cleanup TODO list. Well I can share the complete list of files that fail checkpatch. I ran checkpatch -f on the whole tree (.c and .h files) a few days ago :-) It ran for 5+ hours ;-) http://marex.hackndev.com/fail-list.txt This is after applying these two patchsets (logo and fpga) and partly cleaning up board/esd/) btw. let's queue these (both logo and fpga) patches for -next please. They are not urgent and I'd like to see my stats for this release not tainted by this patchbomb. Also, I'll share the partial cleanup of ESD boards if Matthias/Stefan is interested. I checked how arch/arm is also broken and me being mostly ARM guy, I'd like to continue cleaning up there. I would do that clean up by myself for the esd files. As long as we do not have a strict timeline for this, I will see if I could start with that in January. I will also check if we could get rid of some boards that are not active anymore. Hi Matthias, ping me when you're ready to start working on it. I might be done by that time even ... I just wrote a script to cleanup basic problems :-) M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Thursday 15 December 2011 16:17:06 Marek Vasut wrote: Well I can share the complete list of files that fail checkpatch. I ran checkpatch -f on the whole tree (.c and .h files) a few days ago :-) It ran for 5+ hours ;-) http://marex.hackndev.com/fail-list.txt This is after applying these two patchsets (logo and fpga) and partly cleaning up board/esd/) btw. let's queue these (both logo and fpga) patches for -next please. They are not urgent and I'd like to see my stats for this release not tainted by this patchbomb. Okay. If nobody objects I'll queue these patches up in u-boot-ppc4xx/next in the next few days. Thanks! M ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 00/18 V2] CHECKPATCH: fpgadata.c cleanup
On Thursday 15 December 2011 08:26:41 Marek Vasut wrote: First of the CHECKPATCH series of patches with per-file checkpatch fixes. This series fixes all files fpgadata.c, which contains PPC FPGA firmwares. There are no functional changes, only CHECKPATCH fixes. i don't really see any point in touching the fpgadata.c files. they're clearly generated files and not meant to be read at all let alone modified after the fact ... of course, i'd wonder what created these in the first place, and apply any style tastes to that tool and then regenerate the result ... -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
