Re: [U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
Hi, Thank you for the input, I will resend the patch with Magnus as author. Daniel Mike Frysinger wrote: the subject line is incorrect. you dont credit people via summary/changelogs, you do it via the tags. so if Magnus wrote this patch, he should be credited with authorship (so use --author when committing). if he gave tips or something, then perhaps use Reported-by. -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
the subject line is incorrect. you dont credit people via summary/changelogs, you do it via the tags. so if Magnus wrote this patch, he should be credited with authorship (so use --author when committing). if he gave tips or something, then perhaps use Reported-by. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
Signed-off-by: Daniel Hellstrom dan...@gaisler.com --- arch/sparc/include/asm/byteorder.h |1 + arch/sparc/include/asm/unaligned.h | 10 ++ 2 files changed, 11 insertions(+), 0 deletions(-) create mode 100644 arch/sparc/include/asm/unaligned.h diff --git a/arch/sparc/include/asm/byteorder.h b/arch/sparc/include/asm/byteorder.h index b9fc656..e3b3dec 100644 --- a/arch/sparc/include/asm/byteorder.h +++ b/arch/sparc/include/asm/byteorder.h @@ -32,6 +32,7 @@ #if defined(__GNUC__) !defined(__STRICT_ANSI__) #define __BYTEORDER_HAS_U64__ +#define __SWAB_64_THRU_32__ #endif #include linux/byteorder/big_endian.h #endif /* _SPARC_BYTEORDER_H */ diff --git a/arch/sparc/include/asm/unaligned.h b/arch/sparc/include/asm/unaligned.h new file mode 100644 index 000..0e646f7 --- /dev/null +++ b/arch/sparc/include/asm/unaligned.h @@ -0,0 +1,10 @@ +#ifndef _ASM_SPARC_UNALIGNED_H +#define _ASM_SPARC_UNALIGNED_H + +/* + * The SPARC can not do unaligned accesses, it must be split into multiple + * byte accesses. The SPARC is in big endian mode. + */ +#include asm-generic/unaligned.h + +#endif /* _ASM_SPARC_UNALIGNED_H */ -- 1.5.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
Dear Wolfgang, I had some minor remarks on patch 1 and 2 as I recall, and a minor change on another patch I discovered myself. Unfortunately I have been very busy, I am really sorry for that. I will try to pull my self together and finish them in the weekend. Do I have to repost the patches, now that they are so delayed? Thank you for your interest, that really helps, Daniel Hellstrom Wolfgang Denk wrote: Dear Daniel Hellstrom, In message 1264680996-13804-1-git-send-email-dan...@gaisler.com you wrote: Signed-off-by: Daniel Hellstrom dan...@gaisler.com --- include/asm-sparc/unaligned.h | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) create mode 100644 include/asm-sparc/unaligned.h This whole patch series has been out there for many months, but I'm still waiting for a pull request from you. Do you have any such plans? Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
Dear Daniel Hellstrom, In message 4be263ad.7020...@gaisler.com you wrote: I had some minor remarks on patch 1 and 2 as I recall, and a minor change on another patch I discovered myself. Unfortunately I have been very busy, I am really sorry for that. I will try to pull my self together and finish them in the weekend. Do I have to repost the patches, now that they are so delayed? You will probably have to rebase these anyway, so please also repost. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A fractal is by definition a set for which the Hausdorff Besicovitch dimension strictly exceeds the topological dimension. - Mandelbrot, _The Fractal Geometry of Nature_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
Dear Daniel Hellstrom, In message 1264680996-13804-1-git-send-email-dan...@gaisler.com you wrote: Signed-off-by: Daniel Hellstrom dan...@gaisler.com --- include/asm-sparc/unaligned.h | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) create mode 100644 include/asm-sparc/unaligned.h This whole patch series has been out there for many months, but I'm still waiting for a pull request from you. Do you have any such plans? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Sorry, but my karma just ran over your dogma. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
On Monday 01 February 2010 12:08:51 Daniel Hellstrom wrote: Mike Frysinger wrote: there is a proposed asm-generic/unaligned.h on the mailing list which i think you could use. you'd just need: #include asm-generic/unaligned.h Thank you for your comment, I will update this patch. the generic unaligned.h has been merged if you want to post your one-line patch now ... -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
Mike Frysinger wrote: On Thursday 28 January 2010 07:16:20 Daniel Hellstrom wrote: Signed-off-by: Daniel Hellstrom dan...@gaisler.com --- include/asm-sparc/unaligned.h | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) create mode 100644 include/asm-sparc/unaligned.h diff --git a/include/asm-sparc/unaligned.h b/include/asm-sparc/unaligned.h new file mode 100644 index 000..4e604c1 --- /dev/null +++ b/include/asm-sparc/unaligned.h @@ -0,0 +1,17 @@ +#ifndef _ASM_SPARC_UNALIGNED_H +#define _ASM_SPARC_UNALIGNED_H + +#ifdef __KERNEL__ + +/* + * The SPARC can not do unaligned accesses, it must be split into multiple + * byte accesses. The SPARC is in big endian mode. + */ +#include linux/unaligned/be_byteshift.h +#include linux/unaligned/generic.h + +#define get_unaligned__get_unaligned_be +#define put_unaligned__put_unaligned_be + +#endif /* __KERNEL__ */ +#endif /* _ASM_SPARC_UNALIGNED_H */ there is a proposed asm-generic/unaligned.h on the mailing list which i think you could use. you'd just need: #include asm-generic/unaligned.h -mike Thank you for your comment, I will update this patch. Daniel ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 01/17] SPARC: added unaligned definitions, patch supplied by Magnus Sjalander.
Signed-off-by: Daniel Hellstrom dan...@gaisler.com --- include/asm-sparc/unaligned.h | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) create mode 100644 include/asm-sparc/unaligned.h diff --git a/include/asm-sparc/unaligned.h b/include/asm-sparc/unaligned.h new file mode 100644 index 000..4e604c1 --- /dev/null +++ b/include/asm-sparc/unaligned.h @@ -0,0 +1,17 @@ +#ifndef _ASM_SPARC_UNALIGNED_H +#define _ASM_SPARC_UNALIGNED_H + +#ifdef __KERNEL__ + +/* + * The SPARC can not do unaligned accesses, it must be split into multiple + * byte accesses. The SPARC is in big endian mode. + */ +#include linux/unaligned/be_byteshift.h +#include linux/unaligned/generic.h + +#define get_unaligned __get_unaligned_be +#define put_unaligned __put_unaligned_be + +#endif /* __KERNEL__ */ +#endif /* _ASM_SPARC_UNALIGNED_H */ -- 1.5.4 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
