Re: [U-Boot] [PATCH 02/20] dm: i2c: sandbox: Add debugging to the speed limit

2015-05-04 Thread Simon Glass 
On 23 April 2015 at 23:14, Heiko Schocher  wrote:
> Hello Simon,
>
>
> Am 23.04.2015 17:12, schrieb Simon Glass:
>>
>> Hi Heiko,
>>
>> On 20 April 2015 at 23:04, Heiko Schocher  wrote:
>>>
>>> Hello Simon,
>>>
>>>
>>> Am 20.04.2015 20:37, schrieb Simon Glass:


 Print a debug() message with the I2C speed is exceeded.

 Signed-off-by: Simon Glass 
 ---

drivers/i2c/sandbox_i2c.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

 diff --git a/drivers/i2c/sandbox_i2c.c b/drivers/i2c/sandbox_i2c.c
 index d6adc0f..621caec 100644
 --- a/drivers/i2c/sandbox_i2c.c
 +++ b/drivers/i2c/sandbox_i2c.c
 @@ -73,8 +73,10 @@ static int sandbox_i2c_xfer(struct udevice *bus,
 struct
 i2c_msg *msg,
   * 400KHz for reads
   */
  is_read = nmsgs > 1;
 -   if (i2c->speed_hz > (is_read ? 40 : 10))
 +   if (i2c->speed_hz > (is_read ? 40 : 10)) {
 +   debug("%s: Max speed exceeded\n", __func__);
  return -EINVAL;
 +   }
>>>
>>>
>>>
>>> Why different speeds for reading/writing?
>>
>>
>> This is just test code - in fact a later patch adds a flag to enable
>> it only when running tests. See test/dm/i2c.c.
>
>
> Ah, thanks for the clarification, so:
>
> Acked-by: Heiko Schocher 

Applied to u-boot-dm.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 02/20] dm: i2c: sandbox: Add debugging to the speed limit

2015-04-24 Thread Heiko Schocher 

Hello Simon,

Am 23.04.2015 17:12, schrieb Simon Glass:

Hi Heiko,

On 20 April 2015 at 23:04, Heiko Schocher  wrote:

Hello Simon,


Am 20.04.2015 20:37, schrieb Simon Glass:


Print a debug() message with the I2C speed is exceeded.

Signed-off-by: Simon Glass 
---

   drivers/i2c/sandbox_i2c.c | 4 +++-
   1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/sandbox_i2c.c b/drivers/i2c/sandbox_i2c.c
index d6adc0f..621caec 100644
--- a/drivers/i2c/sandbox_i2c.c
+++ b/drivers/i2c/sandbox_i2c.c
@@ -73,8 +73,10 @@ static int sandbox_i2c_xfer(struct udevice *bus, struct
i2c_msg *msg,
  * 400KHz for reads
  */
 is_read = nmsgs > 1;
-   if (i2c->speed_hz > (is_read ? 40 : 10))
+   if (i2c->speed_hz > (is_read ? 40 : 10)) {
+   debug("%s: Max speed exceeded\n", __func__);
 return -EINVAL;
+   }



Why different speeds for reading/writing?


This is just test code - in fact a later patch adds a flag to enable
it only when running tests. See test/dm/i2c.c.


Ah, thanks for the clarification, so:

Acked-by: Heiko Schocher 

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 02/20] dm: i2c: sandbox: Add debugging to the speed limit

2015-04-23 Thread Simon Glass 
Hi Heiko,

On 20 April 2015 at 23:04, Heiko Schocher  wrote:
> Hello Simon,
>
>
> Am 20.04.2015 20:37, schrieb Simon Glass:
>>
>> Print a debug() message with the I2C speed is exceeded.
>>
>> Signed-off-by: Simon Glass 
>> ---
>>
>>   drivers/i2c/sandbox_i2c.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/sandbox_i2c.c b/drivers/i2c/sandbox_i2c.c
>> index d6adc0f..621caec 100644
>> --- a/drivers/i2c/sandbox_i2c.c
>> +++ b/drivers/i2c/sandbox_i2c.c
>> @@ -73,8 +73,10 @@ static int sandbox_i2c_xfer(struct udevice *bus, struct
>> i2c_msg *msg,
>>  * 400KHz for reads
>>  */
>> is_read = nmsgs > 1;
>> -   if (i2c->speed_hz > (is_read ? 40 : 10))
>> +   if (i2c->speed_hz > (is_read ? 40 : 10)) {
>> +   debug("%s: Max speed exceeded\n", __func__);
>> return -EINVAL;
>> +   }
>
>
> Why different speeds for reading/writing?

This is just test code - in fact a later patch adds a flag to enable
it only when running tests. See test/dm/i2c.c.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 02/20] dm: i2c: sandbox: Add debugging to the speed limit

2015-04-20 Thread Heiko Schocher 

Hello Simon,

Am 20.04.2015 20:37, schrieb Simon Glass:

Print a debug() message with the I2C speed is exceeded.

Signed-off-by: Simon Glass 
---

  drivers/i2c/sandbox_i2c.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/sandbox_i2c.c b/drivers/i2c/sandbox_i2c.c
index d6adc0f..621caec 100644
--- a/drivers/i2c/sandbox_i2c.c
+++ b/drivers/i2c/sandbox_i2c.c
@@ -73,8 +73,10 @@ static int sandbox_i2c_xfer(struct udevice *bus, struct 
i2c_msg *msg,
 * 400KHz for reads
 */
is_read = nmsgs > 1;
-   if (i2c->speed_hz > (is_read ? 40 : 10))
+   if (i2c->speed_hz > (is_read ? 40 : 10)) {
+   debug("%s: Max speed exceeded\n", __func__);
return -EINVAL;
+   }


Why different speeds for reading/writing?

bye,
Heiko

return ops->xfer(emul, msg, nmsgs);
  }




--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 02/20] dm: i2c: sandbox: Add debugging to the speed limit

2015-04-20 Thread Simon Glass 
Print a debug() message with the I2C speed is exceeded.

Signed-off-by: Simon Glass 
---

 drivers/i2c/sandbox_i2c.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/sandbox_i2c.c b/drivers/i2c/sandbox_i2c.c
index d6adc0f..621caec 100644
--- a/drivers/i2c/sandbox_i2c.c
+++ b/drivers/i2c/sandbox_i2c.c
@@ -73,8 +73,10 @@ static int sandbox_i2c_xfer(struct udevice *bus, struct 
i2c_msg *msg,
 * 400KHz for reads
 */
is_read = nmsgs > 1;
-   if (i2c->speed_hz > (is_read ? 40 : 10))
+   if (i2c->speed_hz > (is_read ? 40 : 10)) {
+   debug("%s: Max speed exceeded\n", __func__);
return -EINVAL;
+   }
return ops->xfer(emul, msg, nmsgs);
 }
 
-- 
2.2.0.rc0.207.ga3a616c

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot