Re: [U-Boot] [PATCH 03/10] ARM Add New Board GEC2410

2009-10-31 Thread Wolfgang Denk
Dear "Hui.Tang",

In message 
 
you wrote:
> Add GEC2410 default config.

Note: it makes no sense to split board support in so many separate
patches. Submit it as one commit, please.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
If I can have honesty, it's easier to overlook mistakes.
-- Kirk, "Space Seed", stardate 3141.9
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 03/10] ARM Add New Board GEC2410

2009-10-31 Thread Wolfgang Denk
Dear "Hui.Tang",

In message 
 
you wrote:
> Add GEC2410 default config.
...
> diff --git a/include/configs/gec2410.h b/include/configs/gec2410.h
> new file mode 100644
> index 000..98c8040
> --- /dev/null
> +++ b/include/configs/gec2410.h
...
> +#undef CONFIG_USE_IRQ/* we don't need IRQ/FIQ stuff 
> */
> +
> +#undef CONFIG_SKIP_RELOCATE_UBOOT

Don't #undef what is not defined anyway.


> +/*#define CONFIG_BOOTARGS"root=ramfs devfs=mount console=ttySA0,9600" */

Don;t add dead code.

> +#define CONFIG_ETHADDR   08:00:3e:26:0a:5b
> +#define CONFIG_NETMASK  255.255.255.0
> +#define CONFIG_IPADDR192.168.1.10
> +#define CONFIG_SERVERIP  192.168.1.254

As Ben already commented: strict NAK on this.

> +/*#define CONFIG_BOOTFILE"elinos-lart" */
> +/*#define CONFIG_BOOTCOMMAND "tftp; bootm" */

Don';t add dead code - please fix globally.

> +/* what's this ? it's not used anywhere */
> +#define CONFIG_KGDB_SER_INDEX1   /* which serial port to 
> use */

Then why do you add it?

> +/* the PWM TImer 4 uses a counter of 15625 for 10 ms, so we need */
> +/* it to wrap 100 times (total 1562500) to get 1 sec. */
> +#define CONFIG_SYS_HZ1562500

NAK.

CONFIG_SYS_HZ is a constant and must be defined as 1000 on all
systems.


> +/* Use drivers/cfi_flash.c, even though the flash is not CFI-compliant   
> */



Didn't you add your own driver board/gec/gec2410/flash.c ?

So does the CFI driver work, or not? And if not, then why exactly not?

> +#define CONFIG_ENV_SIZE  0x4000  /* Total Size of Environment 
> Sector */

Wrong comment? CONFIG_ENV_SIZE is the size of the envrionment, NOT
the sector size.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Anything free is worth what you pay for it.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 03/10] ARM Add New Board GEC2410

2009-10-30 Thread Ben Warren
Hui.Tang,

On Fri, Oct 30, 2009 at 3:39 AM, Hui.Tang  wrote:

> Add GEC2410 default config.
>
> Signed-off-by: Hui.Tang 
> ---
>  include/configs/gec2410.h |  275
> +
>


+
+#define CONFIG_BOOTDELAY   3
+/*#define CONFIG_BOOTARGS  "root=ramfs devfs=mount console=ttySA0,9600"
*/
+#define CONFIG_ETHADDR 08:00:3e:26:0a:5b
+#define CONFIG_NETMASK  255.255.255.0
+#define CONFIG_IPADDR  192.168.1.10
+#define CONFIG_SERVERIP192.168.1.254
Please remove all default network parameters.


regards,
Ben
1.6.0.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 03/10] ARM Add New Board GEC2410

2009-10-30 Thread Hui.Tang
Add GEC2410 default config.

Signed-off-by: Hui.Tang 
---
 include/configs/gec2410.h |  275 +
 1 files changed, 275 insertions(+), 0 deletions(-)
 create mode 100644 include/configs/gec2410.h

diff --git a/include/configs/gec2410.h b/include/configs/gec2410.h
new file mode 100644
index 000..98c8040
--- /dev/null
+++ b/include/configs/gec2410.h
@@ -0,0 +1,275 @@
+/*
+ * (C) Copyright 2002
+ * Sysgo Real-Time Solutions, GmbH 
+ * Marius Groeger 
+ * Gary Jennejohn 
+ * David Mueller 
+ *
+ * Configuation settings for the GD-Embedded Software Center GEC2410 board.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/*
+ * High Level Configuration Options
+ * (easy to change)
+ */
+#define CONFIG_ARM920T 1   /* This is an ARM920T Core  */
+#define CONFIG_S3C2410 1   /* in a SAMSUNG S3C2410 SoC */
+#define CONFIG_GEC2410 1   /* on a GD-Embedded Software Center 
GEC2410 Board  */
+
+#define CONFIG_SYS_SDRAM_BASE  0x3000
+
+/* input clock of PLL */
+#define CONFIG_SYS_CLK_FREQ1200/* the GEC2410 has 12MHz input clock */
+
+#if !defined(CONFIG_NAND_SPL) && (TEXT_BASE >= 0xc000)
+#define CONFIG_ENABLE_MMU
+#endif
+
+#define CONFIG_MEMORY_UPPER_CODE
+
+#define CONFIG_SETUP_MEMORY_TAGS
+#define CONFIG_CMDLINE_TAG
+#define CONFIG_INITRD_TAG
+
+#define USE_920T_MMU   1
+#undef CONFIG_USE_IRQ  /* we don't need IRQ/FIQ stuff */
+
+#undef CONFIG_SKIP_RELOCATE_UBOOT
+
+/*
+ * Size of malloc() pool
+ */
+#define CONFIG_SYS_MALLOC_LEN  (CONFIG_ENV_SIZE + 1024 * 1024)
+#define CONFIG_SYS_GBL_DATA_SIZE   128 /* size in bytes reserved for 
initial data */
+
+/*
+ * Hardware drivers
+ */
+#define CONFIG_NET_MULTI
+#define CONFIG_CS8900  /* we have a CS8900 on-board */
+#define CONFIG_CS8900_BASE 0x19000300
+#define CONFIG_CS8900_BUS16/* the Linux driver does accesses as shorts */
+
+/*
+ * select serial console configuration
+ */
+#define CONFIG_S3C24X0_SERIAL  1
+#define CONFIG_SERIAL1  1  /* we use SERIAL 1 on GEC2410 */
+
+/
+ * RTC
+ /
+#defineCONFIG_RTC_S3C24X0  1
+
+/* allow to overwrite serial and ethaddr */
+#define CONFIG_ENV_OVERWRITE
+
+#define CONFIG_BAUDRATE115200
+
+
+/*
+ * BOOTP options
+ */
+#define CONFIG_BOOTP_BOOTFILESIZE
+#define CONFIG_BOOTP_BOOTPATH
+#define CONFIG_BOOTP_GATEWAY
+#define CONFIG_BOOTP_HOSTNAME
+
+
+/*
+ * Command line configuration.
+ */
+#include 
+
+#define CONFIG_CMD_CACHE
+#define CONFIG_CMD_SAVEENV
+#define CONFIG_CMD_NAND
+#if defined(CONFIG_BOOT_ONENAND)
+#define CONFIG_CMD_ONENAND
+#endif
+#define CONFIG_CMD_PING
+#define CONFIG_CMD_ELF
+#define CONFIG_CMD_FAT
+
+#define CONFIG_BOOTDELAY   3
+/*#define CONFIG_BOOTARGS  "root=ramfs devfs=mount console=ttySA0,9600" */
+#define CONFIG_ETHADDR 08:00:3e:26:0a:5b
+#define CONFIG_NETMASK  255.255.255.0
+#define CONFIG_IPADDR  192.168.1.10
+#define CONFIG_SERVERIP192.168.1.254
+/*#define CONFIG_BOOTFILE  "elinos-lart" */
+/*#define CONFIG_BOOTCOMMAND   "tftp; bootm" */
+
+#if defined(CONFIG_CMD_KGDB)
+#define CONFIG_KGDB_BAUDRATE   115200  /* speed to run kgdb serial 
port */
+/* what's this ? it's not used anywhere */
+#define CONFIG_KGDB_SER_INDEX  1   /* which serial port to use */
+#endif
+
+/*
+ * Miscellaneous configurable options
+ */
+#define CONFIG_SYS_LONGHELP/* undef to save memory 
  */
+#define CONFIG_SYS_PROMPT  "GEC2410#"  /* Monitor Command 
Prompt */
+#define CONFIG_SYS_CBSIZE  256 /* Console I/O Buffer 
Size*/
+#define CONFIG_SYS_PBSIZE  384 /* Print Buffer Size
  */
+#define CONFIG_SYS_MAXARGS 16  /* max number of 
command args */
+#define CONFIG_SYS_BARGSIZECONFIG_SYS_CBSIZE   /* Boot 
Argument Buffer Size  */
+
+#define CONFIG_SYS_MEMTEST_START   CONFIG_SYS_SDRAM_BASE   /* memtest 
wo