Re: [U-Boot] [PATCH 03/10] samsung: common: Add misc file and common function misc_init_r().

2013-12-11 Thread Minkyu Kang 
On 04/12/13 03:03, Przemyslaw Marczak wrote:
 Config options:
 - CONFIG_SAMSUNG - misc.c
 - CONFIG_MISC_INIT_R - function misc_init_r();
 
 New file:
 - board/samsung/common/misc.c
 
 Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com
 ---
  board/samsung/common/Makefile |1 +
  board/samsung/common/misc.c   |   16 
  2 files changed, 17 insertions(+)
  create mode 100644 board/samsung/common/misc.c
 
 diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
 index 501d974..d1eb63f 100644
 --- a/board/samsung/common/Makefile
 +++ b/board/samsung/common/Makefile
 @@ -8,3 +8,4 @@
  obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
  obj-$(CONFIG_THOR_FUNCTION) += thor.o
  obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
 +obj-$(CONFIG_SAMSUNG) += misc.o

Why CONFIG_SAMSUNG?
We know this Makefile is for samsung boards.

 diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
 new file mode 100644
 index 000..465895b
 --- /dev/null
 +++ b/board/samsung/common/misc.c
 @@ -0,0 +1,16 @@
 +/*
 + * Copyright (C) 2013 Samsung Electronics
 + * Przemyslaw Marczak p.marc...@samsung.com
 + *
 + * SPDX-License-Identifier:  GPL-2.0+
 + */
 +
 +#include common.h
 +
 +#ifdef CONFIG_MISC_INIT_R
 +/* Common for Samsung boards */
 +int misc_init_r(void)
 +{
 + return 0;
 +}
 +#endif /* CONFIG_MISC_INIT_R */
 

Thanks,
Minkyu Kang.

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 03/10] samsung: common: Add misc file and common function misc_init_r().

2013-12-11 Thread Przemyslaw Marczak 

Hello Minkyu,

On 12/11/2013 09:16 AM, Minkyu Kang wrote:

On 04/12/13 03:03, Przemyslaw Marczak wrote:

Config options:
- CONFIG_SAMSUNG - misc.c
- CONFIG_MISC_INIT_R - function misc_init_r();

New file:
- board/samsung/common/misc.c

Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com
---
  board/samsung/common/Makefile |1 +
  board/samsung/common/misc.c   |   16 
  2 files changed, 17 insertions(+)
  create mode 100644 board/samsung/common/misc.c

diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
index 501d974..d1eb63f 100644
--- a/board/samsung/common/Makefile
+++ b/board/samsung/common/Makefile
@@ -8,3 +8,4 @@
  obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
  obj-$(CONFIG_THOR_FUNCTION) += thor.o
  obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
+obj-$(CONFIG_SAMSUNG) += misc.o


Why CONFIG_SAMSUNG?
We know this Makefile is for samsung boards.

Right, I will change it to CONFIG_MISC_INIT_R, and this ifdef will be 
removed from misc.c.



diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
new file mode 100644
index 000..465895b
--- /dev/null
+++ b/board/samsung/common/misc.c
@@ -0,0 +1,16 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ * Przemyslaw Marczak p.marc...@samsung.com
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include common.h
+
+#ifdef CONFIG_MISC_INIT_R
+/* Common for Samsung boards */
+int misc_init_r(void)
+{
+   return 0;
+}
+#endif /* CONFIG_MISC_INIT_R */



Thanks,
Minkyu Kang.




Regards
--
Przemyslaw Marczak
Samsung RD Institute Poland
Samsung Electronics
p.marc...@samsung.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 03/10] samsung: common: Add misc file and common function misc_init_r().

2013-12-03 Thread Przemyslaw Marczak 
Config options:
- CONFIG_SAMSUNG - misc.c
- CONFIG_MISC_INIT_R - function misc_init_r();

New file:
- board/samsung/common/misc.c

Signed-off-by: Przemyslaw Marczak p.marc...@samsung.com
---
 board/samsung/common/Makefile |1 +
 board/samsung/common/misc.c   |   16 
 2 files changed, 17 insertions(+)
 create mode 100644 board/samsung/common/misc.c

diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
index 501d974..d1eb63f 100644
--- a/board/samsung/common/Makefile
+++ b/board/samsung/common/Makefile
@@ -8,3 +8,4 @@
 obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
 obj-$(CONFIG_THOR_FUNCTION) += thor.o
 obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
+obj-$(CONFIG_SAMSUNG) += misc.o
diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
new file mode 100644
index 000..465895b
--- /dev/null
+++ b/board/samsung/common/misc.c
@@ -0,0 +1,16 @@
+/*
+ * Copyright (C) 2013 Samsung Electronics
+ * Przemyslaw Marczak p.marc...@samsung.com
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include common.h
+
+#ifdef CONFIG_MISC_INIT_R
+/* Common for Samsung boards */
+int misc_init_r(void)
+{
+   return 0;
+}
+#endif /* CONFIG_MISC_INIT_R */
-- 
1.7.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot