Re: [U-Boot] [PATCH 08/15] x86: Remove SMP limitation in lapic_setup()
On Mon, May 23, 2016 at 8:19 AM, Simon Glass wrote: > On 22 May 2016 at 02:45, Bin Meng wrote: >> At present LAPIC is enabled and configured as virtual wire mode >> in lapic_setup() only when CONFIG_SMP is on. This limitation is >> however not necessary as for uniprocessor this is still needed. >> >> Signed-off-by: Bin Meng >> --- >> >> arch/x86/cpu/lapic.c | 7 +-- >> 1 file changed, 1 insertion(+), 6 deletions(-) > > Reviewed-by: Simon Glass applied to u-boot-x86, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 08/15] x86: Remove SMP limitation in lapic_setup()
On 22 May 2016 at 02:45, Bin Meng wrote: > At present LAPIC is enabled and configured as virtual wire mode > in lapic_setup() only when CONFIG_SMP is on. This limitation is > however not necessary as for uniprocessor this is still needed. > > Signed-off-by: Bin Meng > --- > > arch/x86/cpu/lapic.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: Simon Glass ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 08/15] x86: Remove SMP limitation in lapic_setup()
At present LAPIC is enabled and configured as virtual wire mode in lapic_setup() only when CONFIG_SMP is on. This limitation is however not necessary as for uniprocessor this is still needed. Signed-off-by: Bin Meng --- arch/x86/cpu/lapic.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/x86/cpu/lapic.c b/arch/x86/cpu/lapic.c index dbb32c4..fbea2d1 100644 --- a/arch/x86/cpu/lapic.c +++ b/arch/x86/cpu/lapic.c @@ -124,7 +124,6 @@ int lapic_remote_read(int apicid, int reg, unsigned long *pvalue) void lapic_setup(void) { -#ifdef CONFIG_SMP /* Only Pentium Pro and later have those MSR stuff */ debug("Setting up local apic: "); @@ -154,11 +153,7 @@ void lapic_setup(void) LAPIC_DELIVERY_MODE_NMI)); debug("apic_id: 0x%02lx, ", lapicid()); -#else /* !CONFIG_SMP */ - /* Only Pentium Pro and later have those MSR stuff */ - debug("Disabling local apic: "); - disable_lapic(); -#endif /* CONFIG_SMP */ + debug("done.\n"); post_code(POST_LAPIC); } -- 1.8.2.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot