Re: [U-Boot] [PATCH 09/24 V2] arch/powerpc/*/config.mk: makeCONFIG_SYS_LDSCRIPT settings work

2010-11-25 Thread Haiying Wang
On Thu, 2010-11-25 at 09:00 -0700, Wolfgang Denk wrote:
 As we try to get rid of board specific config.mk files we must
 provide a way for board specific settings of the LDSCRIPT variable
 (path to the linker script) where needed.
 
 We now implement the following hierarchy:
 
 - Highest priority has a #define CONFIG_SYS_LDCONFIG in the board
   config file.
 - If CONFIG_SYS_LDCONFIG is not set, and the system is booting from
   NAND (CONFIG_NAND_U_BOOT is set), then a board specific linker
   script board/$(BOARDDIR)/u-boot-nand.lds gets use.

u-boot-nand.lds is not in board/$(BOARDDIR) for 85xx at least, it is in
$(SRCTREE)/$(CPUDIR)/

 - If we are not booting from NAND, we test if a processor specific
   linker script arch/powerpc/cpu/$(CPU)/u-boot.lds exists; if so we
   use that.
should we use $(CPUDIR) instead of arch/powerpc/cpu/$(CPU)?

Haiying


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 09/24 V2] arch/powerpc/*/config.mk: makeCONFIG_SYS_LDSCRIPT settings work

2010-11-25 Thread Wolfgang Denk
Dear Haiying Wang,

In message 1290702018.2007.4.ca...@haiying-laptop you wrote:

  - If CONFIG_SYS_LDCONFIG is not set, and the system is booting from
NAND (CONFIG_NAND_U_BOOT is set), then a board specific linker
script board/$(BOARDDIR)/u-boot-nand.lds gets use.
 
 u-boot-nand.lds is not in board/$(BOARDDIR) for 85xx at least, it is in
 $(SRCTREE)/$(CPUDIR)/

This is not correct - situation before applying my patches:

- find * -name u-boot-nand.lds
arch/powerpc/cpu/mpc85xx/u-boot-nand.lds
board/amcc/acadia/u-boot-nand.lds
board/amcc/bamboo/u-boot-nand.lds
board/amcc/canyonlands/u-boot-nand.lds
board/amcc/kilauea/u-boot-nand.lds
board/amcc/sequoia/u-boot-nand.lds
board/esd/pmc440/u-boot-nand.lds
board/samsung/smdk6400/u-boot-nand.lds

  - If we are not booting from NAND, we test if a processor specific
linker script arch/powerpc/cpu/$(CPU)/u-boot.lds exists; if so we
use that.
 should we use $(CPUDIR) instead of arch/powerpc/cpu/$(CPU)?

I'm not sure if CPUDIR is defined at that time.  Did you try it out?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The world is no nursery.  - Sigmund Freud
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 09/24 V2] arch/powerpc/*/config.mk: makeCONFIG_SYS_LDSCRIPT settings work

2010-11-25 Thread Wolfgang Denk
Dear Haiying Wang,

In message 1290702018.2007.4.ca...@haiying-laptop you wrote:
 On Thu, 2010-11-25 at 09:00 -0700, Wolfgang Denk wrote:
  As we try to get rid of board specific config.mk files we must
  provide a way for board specific settings of the LDSCRIPT variable
  (path to the linker script) where needed.
  
  We now implement the following hierarchy:
  
  - Highest priority has a #define CONFIG_SYS_LDCONFIG in the board
config file.
  - If CONFIG_SYS_LDCONFIG is not set, and the system is booting from
NAND (CONFIG_NAND_U_BOOT is set), then a board specific linker
script board/$(BOARDDIR)/u-boot-nand.lds gets use.
 
 u-boot-nand.lds is not in board/$(BOARDDIR) for 85xx at least, it is in
 $(SRCTREE)/$(CPUDIR)/

What is incorrect is the description - it does not match the latest
code: we don't test  CONFIG_NAND_U_BOOT but CONFIG_NAND_SPL.

I will fix this when applying.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Good morning. This is the telephone company. Due  to  repairs,  we're
giving  you  advance notice that your service will be cut off indefi-
nitely at ten o'clock. That's two minutes from now.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot