Re: [U-Boot] [PATCH 09/39] x86: Remove board_init16() call which is not used
On 6 November 2014 19:57, Bin Meng wrote: > On Fri, Nov 7, 2014 at 4:20 AM, Simon Glass wrote: >> This allows a board to do very early init, but no boards need to do this. >> We may as well drop this feature. >> >> Signed-off-by: Simon Glass >> --- >> >> arch/x86/cpu/start16.S | 10 +- >> 1 file changed, 1 insertion(+), 9 deletions(-) >> >> diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S >> index 6968fda..e718d4b 100644 >> --- a/arch/x86/cpu/start16.S >> +++ b/arch/x86/cpu/start16.S >> @@ -24,15 +24,7 @@ start16: >> /* Set the Cold Boot / Hard Reset flag */ >> movl$GD_FLG_COLD_BOOT, %ebx >> >> - /* >> -* First we let the BSP do some early initialization >> -* this code have to map the flash to its final position >> -*/ >> - jmp board_init16 >> -.globl board_init16_ret >> -board_init16_ret: >> - >> - /* Turn of cache (this might require a 486-class CPU) */ >> + /* Turn off cache (this might require a 486-class CPU) */ >> movl%cr0, %eax >> orl $(X86_CR0_NW | X86_CR0_CD), %eax >> movl%eax, %cr0 >> -- > > Reviewed-by: Bin Meng Applied to u-boot-x86. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 09/39] x86: Remove board_init16() call which is not used
On Fri, Nov 7, 2014 at 4:20 AM, Simon Glass wrote: > This allows a board to do very early init, but no boards need to do this. > We may as well drop this feature. > > Signed-off-by: Simon Glass > --- > > arch/x86/cpu/start16.S | 10 +- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S > index 6968fda..e718d4b 100644 > --- a/arch/x86/cpu/start16.S > +++ b/arch/x86/cpu/start16.S > @@ -24,15 +24,7 @@ start16: > /* Set the Cold Boot / Hard Reset flag */ > movl$GD_FLG_COLD_BOOT, %ebx > > - /* > -* First we let the BSP do some early initialization > -* this code have to map the flash to its final position > -*/ > - jmp board_init16 > -.globl board_init16_ret > -board_init16_ret: > - > - /* Turn of cache (this might require a 486-class CPU) */ > + /* Turn off cache (this might require a 486-class CPU) */ > movl%cr0, %eax > orl $(X86_CR0_NW | X86_CR0_CD), %eax > movl%eax, %cr0 > -- Reviewed-by: Bin Meng ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 09/39] x86: Remove board_init16() call which is not used
This allows a board to do very early init, but no boards need to do this. We may as well drop this feature. Signed-off-by: Simon Glass --- arch/x86/cpu/start16.S | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/arch/x86/cpu/start16.S b/arch/x86/cpu/start16.S index 6968fda..e718d4b 100644 --- a/arch/x86/cpu/start16.S +++ b/arch/x86/cpu/start16.S @@ -24,15 +24,7 @@ start16: /* Set the Cold Boot / Hard Reset flag */ movl$GD_FLG_COLD_BOOT, %ebx - /* -* First we let the BSP do some early initialization -* this code have to map the flash to its final position -*/ - jmp board_init16 -.globl board_init16_ret -board_init16_ret: - - /* Turn of cache (this might require a 486-class CPU) */ + /* Turn off cache (this might require a 486-class CPU) */ movl%cr0, %eax orl $(X86_CR0_NW | X86_CR0_CD), %eax movl%eax, %cr0 -- 2.1.0.rc2.206.gedb03e5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
