Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE

[York Sun]

On 08/18/2017 02:47 AM, Santan Kumar wrote:
> CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay
> the prints of boardinfo late in cycle during uboot boot.
> This feature is not required in case of QSPI_BOOT.
> 
> Signed-off-by: Santan Kumar 
> Signed-off-by: Priyanka Jain 
> ---

Applied to fsl-qoriq mater. Thanks.

York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE

[Santan Kumar]

> -Original Message-
> From: Poonam Aggrwal
> Sent: Friday, August 18, 2017 4:17 PM
> To: Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>; Santan Kumar
> <santan.ku...@nxp.com>; u-boot@lists.denx.de; York Sun
> <york@nxp.com>
> Cc: Priyanka Jain <priyanka.j...@nxp.com>
> Subject: RE: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove
> CONFIG_DISPLAY_BOARDINFO_LATE
> 
> 
> 
> -Original Message-
> From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of
> Prabhakar Kushwaha
> Sent: Friday, August 18, 2017 3:53 PM
> To: Santan Kumar <santan.ku...@nxp.com>; u-boot@lists.denx.de; York
> Sun <york....@nxp.com>
> Cc: Priyanka Jain <priyanka.j...@nxp.com>
> Subject: Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove
> CONFIG_DISPLAY_BOARDINFO_LATE
> 
> 
> > -Original Message-
> > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Santan
> > Kumar
> > Sent: Friday, August 18, 2017 3:21 PM
> > To: u-boot@lists.denx.de; York Sun <york@nxp.com>
> > Cc: Priyanka Jain <priyanka.j...@nxp.com>
> > Subject: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove
> > CONFIG_DISPLAY_BOARDINFO_LATE
> >
> > CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay the prints of
> > boardinfo late in cycle during uboot boot.
> > This feature is not required in case of QSPI_BOOT.
> >
> I am not aware of the history of the change, but the patch description does
> not sufficiently describe why this change has been done. Why in case of QSPI
> Boot BOARD information is not required to be printed late.
[Santan] We can use any of one flag CONFIG_DISPLAY_BOARDINFO_LATE or 
CONFIG_DISPLAY_BOARDINFO
to display board info during boot. Since we are using CONFIG_DISPLAY_BOARDINFO 
in case of QSPI boot that's why this flag is removed. In some specific cases in 
which information was not ready at start we can should use
CONFIG_DISPLAY_BOARDINFO_LATE.

> > Signed-off-by: Santan Kumar <santan.ku...@nxp.com>
> > Signed-off-by: Priyanka Jain <priyanka.j...@nxp.com>
> > ---
> 
> Reviewed-by : Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE

[Poonam Aggrwal]

-Original Message-
From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Prabhakar 
Kushwaha
Sent: Friday, August 18, 2017 3:53 PM
To: Santan Kumar <santan.ku...@nxp.com>; u-boot@lists.denx.de; York Sun 
<york@nxp.com>
Cc: Priyanka Jain <priyanka.j...@nxp.com>
Subject: Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove 
CONFIG_DISPLAY_BOARDINFO_LATE


> -Original Message-
> From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Santan 
> Kumar
> Sent: Friday, August 18, 2017 3:21 PM
> To: u-boot@lists.denx.de; York Sun <york@nxp.com>
> Cc: Priyanka Jain <priyanka.j...@nxp.com>
> Subject: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove 
> CONFIG_DISPLAY_BOARDINFO_LATE
> 
> CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay the prints of 
> boardinfo late in cycle during uboot boot.
> This feature is not required in case of QSPI_BOOT.
> 
I am not aware of the history of the change, but the patch description does not 
sufficiently describe why this change has been done. Why in case of QSPI Boot 
BOARD information is not required to be printed late.
> Signed-off-by: Santan Kumar <santan.ku...@nxp.com>
> Signed-off-by: Priyanka Jain <priyanka.j...@nxp.com>
> ---

Reviewed-by : Prabhakar Kushwaha <prabhakar.kushw...@nxp.com> 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE

[Prabhakar Kushwaha]

> -Original Message-
> From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Santan
> Kumar
> Sent: Friday, August 18, 2017 3:21 PM
> To: u-boot@lists.denx.de; York Sun <york@nxp.com>
> Cc: Priyanka Jain <priyanka.j...@nxp.com>
> Subject: [U-Boot] [PATCH 1/1] board/ls2080ardb: Remove
> CONFIG_DISPLAY_BOARDINFO_LATE
> 
> CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay
> the prints of boardinfo late in cycle during uboot boot.
> This feature is not required in case of QSPI_BOOT.
> 
> Signed-off-by: Santan Kumar <santan.ku...@nxp.com>
> Signed-off-by: Priyanka Jain <priyanka.j...@nxp.com>
> ---

Reviewed-by : Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/1] board/ls2080ardb: Remove CONFIG_DISPLAY_BOARDINFO_LATE

[Santan Kumar]

CONFIG_DISPLAY_BOARDINFO_LATE config is used to delay
the prints of boardinfo late in cycle during uboot boot.
This feature is not required in case of QSPI_BOOT.

Signed-off-by: Santan Kumar 
Signed-off-by: Priyanka Jain 
---
This patch is split version of another patch
 https://patchwork.ozlabs.org/patch/779931/

 include/configs/ls2080ardb.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h
index 9b9a710..a5f7eea 100644
--- a/include/configs/ls2080ardb.h
+++ b/include/configs/ls2080ardb.h
@@ -18,7 +18,6 @@
 #define CONFIG_QIXIS_I2C_ACCESS
 #endif
 #define CONFIG_SYS_I2C_EARLY_INIT
-#define CONFIG_DISPLAY_BOARDINFO_LATE
 #endif
 
 #define I2C_MUX_CH_VOL_MONITOR 0xa
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot