Re: [U-Boot] [PATCH 1/1] fs/fat: remove distractive message in file_fat_read_at()

2018-01-03 Thread Simon Glass 
On 1 January 2018 at 13:31, Heinrich Schuchardt  wrote:
> The message "reading %s\n" may be interesting when
> debugging but otherwise it is superfluous.
>
> Only output the message when debugging.
>
> Signed-off-by: Heinrich Schuchardt 
> ---
>  fs/fat/fat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/1] fs/fat: remove distractive message in file_fat_read_at()

2018-01-01 Thread Heinrich Schuchardt 
The message "reading %s\n" may be interesting when
debugging but otherwise it is superfluous.

Only output the message when debugging.

Signed-off-by: Heinrich Schuchardt 
---
 fs/fat/fat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index d16883fa10..1283818761 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -1106,7 +1106,7 @@ int file_fat_read_at(const char *filename, loff_t pos, 
void *buffer,
if (ret)
goto out_free_both;
 
-   printf("reading %s\n", filename);
+   debug("reading %s\n", filename);
ret = get_contents(&fsdata, itr->dent, pos, buffer, maxsize, actread);
 
 out_free_both:
-- 
2.14.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot