[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

2008-08-28 Thread vgallardo 
From: Victor Gallardo [EMAIL PROTECTED]


Signed-off-by: Victor Gallardo [EMAIL PROTECTED]
---
 cpu/ppc4xx/uic.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpu/ppc4xx/uic.c b/cpu/ppc4xx/uic.c
index 7944c6c..a95d1cb 100644
--- a/cpu/ppc4xx/uic.c
+++ b/cpu/ppc4xx/uic.c
@@ -129,11 +129,11 @@ void external_interrupt(struct pt_regs *regs)
uic_interrupt(UIC3_DCR_BASE, 96);
 #endif
 
+   mtdcr(uic0sr, (uic_msr  UICB0_ALL));
+
if (uic_msr  ~(UICB0_ALL))
uic_interrupt(UIC0_DCR_BASE, 0);
 
-   mtdcr(uic0sr, uic_msr);
-
return;
 }
 
-- 
1.5.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

2008-08-28 Thread Feng Kan 
Hi Wolfgang:
  I send the patch out for Victor. In the original email the From 
field did indicate his name.
Am I missing something?

Thanks
Feng Kan
 Dear [EMAIL PROTECTED],

 Can you please provide a real name with your mail address when
 submitting patches?


   

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

2008-08-28 Thread Wolfgang Denk 
Dear Feng Kan,

In message [EMAIL PROTECTED] you wrote:

   I send the patch out for Victor. In the original email the From 
 field did indicate his name.
 Am I missing something?

I don't know what you did, but there were actually two semi-identical
postings:

--
Subject: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or
non-critical interrupt is set at the same time as a normal
interrupt is set on UIC0
From: [EMAIL PROTECTED]
Date: Thu, 28 Aug 2008 13:53:11 -0700 (22:53 MEST)
To: u-boot@lists.denx.de
Cc: [EMAIL PROTECTED]
--
Subject: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or
non-critical interrupt is set at the same time as a normal
interrupt is set on UIC0
From: [EMAIL PROTECTED]
Date: Thu, 28 Aug 2008 13:55:14 -0700 (22:55 MEST)
To: u-boot@lists.denx.de
Cc: [EMAIL PROTECTED]
--

As you can see, both were sent about two minutes apart, and  none  of
them had a realname in the From: field.

See also
http://lists.denx.de/pipermail/u-boot/2008-August/039566.html and
http://lists.denx.de/pipermail/u-boot/2008-August/039567.html

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
As long as we're going to reinvent the wheel again, we might as  well
try making it round this time.- Mike Dennison
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot