Re: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu
Dear Angelo Dureghello, In message 4e444780.9040...@gmail.com you wrote: Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files. Signed-off-by: Angelo Dureghello sysa...@gmail.com --- arch/m68k/cpu/mcf530x/Makefile | 48 +++ arch/m68k/cpu/mcf530x/config.mk| 25 arch/m68k/cpu/mcf530x/cpu.c| 48 +++ arch/m68k/cpu/mcf530x/cpu.h| 33 + arch/m68k/cpu/mcf530x/cpu_init.c | 164 +++ arch/m68k/cpu/mcf530x/interrupts.c | 42 ++ arch/m68k/cpu/mcf530x/speed.c | 36 + arch/m68k/cpu/mcf530x/start.S | 253 arch/m68k/include/asm/immap_5307.h | 78 +++ arch/m68k/include/asm/m5307.h | 119 + 10 files changed, 846 insertions(+), 0 deletions(-) create mode 100644 arch/m68k/cpu/mcf530x/Makefile create mode 100644 arch/m68k/cpu/mcf530x/config.mk create mode 100644 arch/m68k/cpu/mcf530x/cpu.c create mode 100644 arch/m68k/cpu/mcf530x/cpu.h create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.c create mode 100644 arch/m68k/cpu/mcf530x/start.S create mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h CamelCase identifiers are not allowed. Also, checkpatch says: total: 34 errors, 31 warnings, 846 lines checked Please clean up and resubmit. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Too much of anything, even love, isn't necessarily a good thing. -- Kirk, The Trouble with Tribbles, stardate 4525.6 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu
-Original Message- From: angelo [mailto:angel...@gmail.com] Sent: Friday, September 02, 2011 7:41 PM To: Jin Zhengxiong-R64188 Cc: U-Boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu Hi Jason and all, i am really interested to bring mcf5307 inside u-boot. But still waiting for your feedback/help on my comments below. Let me know your comments. Many thanks, Hi, angelo, Could you please try as seperate MCF530X family but send out the complete patchset? You previous patch seems only include the new files. Thanks. Regards, Jason Regards, angelo Hello Jason and all, i started to work to rewrite the patch. Starting from mcf532x/cpu.c, i am not sure this is the right place to add MCF5307. 1) On checkcpu, mcf5307 don't have ccm-cir where to read mask/ver. 2) About do_reset, here also mcf5307 don't have MMAP_RCM, memory map and reset \ procedure are different. 3) In general, as memory map, mcf5307 is much more similar \ to some mcf52x2 cpu. This is the reason why i thought to treat it as a separate \ family. Looking here: http://www.freescale.com/webapp/sps/site/taxonomy.jsp?code=68KCFV3 seems Freescale also treat it as the only cpu of the MCF530X family. I can still go ahead, but cpu.c should have a great #ifdef CONFIG_MCF5307 to handle \ separately this cpu. How do you think i should proceed ? regards angelo On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote: -Original Message- From: Angelo Dureghello [mailto:angel...@gmail.com]Sent: Friday, August 12, 2011 5:20 AMTo: U-Boot@lists.denx.deCc: Jin Zhengxiong-R64188Subject: [PATCH 1/1 V2] add support for mcf5307 cpu Add cpu related files and memory map includes. Apply the relatedminor changes to general coldfire architecture include files. Signed-off-by: Angelo Dureghellosysa...@gmail.com--- arch/m68k/cpu/mcf530x/Makefile | 48 +++ arch/m68k/cpu/mcf530x/config.mk| 25 arch/m68k/cpu/mcf530x/cpu.c| 48 +++ arch/m68k/cpu/mcf530x/cpu.h| 33 + arch/m68k/cpu/mcf530x/cpu_init.c | 164 +++ arch/m68k/cpu/mcf530x/interrupts.c | 42 ++ arch/m68k/cpu/mcf530x/speed.c | 36 + arch/m68k/cpu/mcf530x/start.S | 253 arch/m68k/include/asm/immap_5307.h | 78 +++ arch/m68k/include/asm/m5307.h | 119 + 10 files changed, 846 insertions(+), 0 deletions(-)create mode 100644 arch/m68k/cpu/mcf530x/Makefilecreate mode 100644 arch/m68k/cpu/mcf530x/config.mkcreate mode 100644 arch/m68k/cpu/mcf530x/cpu.ccreate mode 100644 arch/m68k/cpu/mcf530x/cpu.hcreate mode 100644 arch/m68k/cpu/mcf530x/cpu_init.ccreate mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.ccreate mode 100644 arch/m68k/cpu/mcf530x/start.Screate mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h [Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such \ as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 \ boards except the cpu_init.c file. Thanks. Jason ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu
Hi Jason and all, i am really interested to bring mcf5307 inside u-boot. But still waiting for your feedback/help on my comments below. Let me know your comments. Many thanks, Regards, angelo Hello Jason and all, i started to work to rewrite the patch. Starting from mcf532x/cpu.c, i am not sure this is the right place to add MCF5307. 1) On checkcpu, mcf5307 don't have ccm-cir where to read mask/ver. 2) About do_reset, here also mcf5307 don't have MMAP_RCM, memory map and reset \ procedure are different. 3) In general, as memory map, mcf5307 is much more similar \ to some mcf52x2 cpu. This is the reason why i thought to treat it as a separate \ family. Looking here: http://www.freescale.com/webapp/sps/site/taxonomy.jsp?code=68KCFV3 seems Freescale also treat it as the only cpu of the MCF530X family. I can still go ahead, but cpu.c should have a great #ifdef CONFIG_MCF5307 to handle \ separately this cpu. How do you think i should proceed ? regards angelo On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote: -Original Message- From: Angelo Dureghello [mailto:angel...@gmail.com] Sent: Friday, August 12, 2011 5:20 AM To: U-Boot@lists.denx.de Cc: Jin Zhengxiong-R64188 Subject: [PATCH 1/1 V2] add support for mcf5307 cpu Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files. Signed-off-by: Angelo Dureghellosysa...@gmail.com --- arch/m68k/cpu/mcf530x/Makefile | 48 +++ arch/m68k/cpu/mcf530x/config.mk| 25 arch/m68k/cpu/mcf530x/cpu.c| 48 +++ arch/m68k/cpu/mcf530x/cpu.h| 33 + arch/m68k/cpu/mcf530x/cpu_init.c | 164 +++ arch/m68k/cpu/mcf530x/interrupts.c | 42 ++ arch/m68k/cpu/mcf530x/speed.c | 36 + arch/m68k/cpu/mcf530x/start.S | 253 arch/m68k/include/asm/immap_5307.h | 78 +++ arch/m68k/include/asm/m5307.h | 119 + 10 files changed, 846 insertions(+), 0 deletions(-) create mode 100644 arch/m68k/cpu/mcf530x/Makefile create mode 100644 arch/m68k/cpu/mcf530x/config.mk create mode 100644 arch/m68k/cpu/mcf530x/cpu.c create mode 100644 arch/m68k/cpu/mcf530x/cpu.h create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.c create mode 100644 arch/m68k/cpu/mcf530x/start.S create mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h [Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such \ as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 \ boards except the cpu_init.c file. Thanks. Jason ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu
Hello Jason and all, i started to work to rewrite the patch. Starting from mcf532x/cpu.c, i am not sure this is the right place to add MCF5307. 1) On checkcpu, mcf5307 don't have ccm-cir where to read mask/ver. 2) About do_reset, here also mcf5307 don't have MMAP_RCM, memory map and reset procedure are different. 3) In general, as memory map, mcf5307 is much more similar to some mcf52x2 cpu. This is the reason why i thought to treat it as a separate family. Looking here: http://www.freescale.com/webapp/sps/site/taxonomy.jsp?code=68KCFV3 seems Freescale also treat it as the only cpu of the MCF530X family. I can still go ahead, but cpu.c should have a great #ifdef CONFIG_MCF5307 to handle separately this cpu. How do you think i should proceed ? regards angelo On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote: -Original Message- From: Angelo Dureghello [mailto:angel...@gmail.com] Sent: Friday, August 12, 2011 5:20 AM To: U-Boot@lists.denx.de Cc: Jin Zhengxiong-R64188 Subject: [PATCH 1/1 V2] add support for mcf5307 cpu Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files. Signed-off-by: Angelo Dureghello sysa...@gmail.com --- arch/m68k/cpu/mcf530x/Makefile | 48 +++ arch/m68k/cpu/mcf530x/config.mk| 25 arch/m68k/cpu/mcf530x/cpu.c| 48 +++ arch/m68k/cpu/mcf530x/cpu.h| 33 + arch/m68k/cpu/mcf530x/cpu_init.c | 164 +++ arch/m68k/cpu/mcf530x/interrupts.c | 42 ++ arch/m68k/cpu/mcf530x/speed.c | 36 + arch/m68k/cpu/mcf530x/start.S | 253 arch/m68k/include/asm/immap_5307.h | 78 +++ arch/m68k/include/asm/m5307.h | 119 + 10 files changed, 846 insertions(+), 0 deletions(-) create mode 100644 arch/m68k/cpu/mcf530x/Makefile create mode 100644 arch/m68k/cpu/mcf530x/config.mk create mode 100644 arch/m68k/cpu/mcf530x/cpu.c create mode 100644 arch/m68k/cpu/mcf530x/cpu.h create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.c create mode 100644 arch/m68k/cpu/mcf530x/start.S create mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h [Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 boards except the cpu_init.c file. Thanks. Jason ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu
On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote: -Original Message- From: Angelo Dureghello [mailto:angel...@gmail.com] Sent: Friday, August 12, 2011 5:20 AM To: U-Boot@lists.denx.de Cc: Jin Zhengxiong-R64188 Subject: [PATCH 1/1 V2] add support for mcf5307 cpu Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files. Signed-off-by: Angelo Dureghellosysa...@gmail.com --- arch/m68k/cpu/mcf530x/Makefile | 48 +++ arch/m68k/cpu/mcf530x/config.mk| 25 arch/m68k/cpu/mcf530x/cpu.c| 48 +++ arch/m68k/cpu/mcf530x/cpu.h| 33 + arch/m68k/cpu/mcf530x/cpu_init.c | 164 +++ arch/m68k/cpu/mcf530x/interrupts.c | 42 ++ arch/m68k/cpu/mcf530x/speed.c | 36 + arch/m68k/cpu/mcf530x/start.S | 253 arch/m68k/include/asm/immap_5307.h | 78 +++ arch/m68k/include/asm/m5307.h | 119 + 10 files changed, 846 insertions(+), 0 deletions(-) create mode 100644 arch/m68k/cpu/mcf530x/Makefile create mode 100644 arch/m68k/cpu/mcf530x/config.mk create mode 100644 arch/m68k/cpu/mcf530x/cpu.c create mode 100644 arch/m68k/cpu/mcf530x/cpu.h create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.c create mode 100644 arch/m68k/cpu/mcf530x/start.S create mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h [Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 boards except the cpu_init.c file. Thanks. Jason Hi Jason, thanks for the feedbacks, sure i can review the patch as you suggest. Will repost the patch asap, in some days. Regards, angelo http://www.sysam.it ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu
-Original Message- From: Angelo Dureghello [mailto:angel...@gmail.com] Sent: Friday, August 12, 2011 5:20 AM To: U-Boot@lists.denx.de Cc: Jin Zhengxiong-R64188 Subject: [PATCH 1/1 V2] add support for mcf5307 cpu Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files. Signed-off-by: Angelo Dureghello sysa...@gmail.com --- arch/m68k/cpu/mcf530x/Makefile | 48 +++ arch/m68k/cpu/mcf530x/config.mk| 25 arch/m68k/cpu/mcf530x/cpu.c| 48 +++ arch/m68k/cpu/mcf530x/cpu.h| 33 + arch/m68k/cpu/mcf530x/cpu_init.c | 164 +++ arch/m68k/cpu/mcf530x/interrupts.c | 42 ++ arch/m68k/cpu/mcf530x/speed.c | 36 + arch/m68k/cpu/mcf530x/start.S | 253 arch/m68k/include/asm/immap_5307.h | 78 +++ arch/m68k/include/asm/m5307.h | 119 + 10 files changed, 846 insertions(+), 0 deletions(-) create mode 100644 arch/m68k/cpu/mcf530x/Makefile create mode 100644 arch/m68k/cpu/mcf530x/config.mk create mode 100644 arch/m68k/cpu/mcf530x/cpu.c create mode 100644 arch/m68k/cpu/mcf530x/cpu.h create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.c create mode 100644 arch/m68k/cpu/mcf530x/start.S create mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h [Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 boards except the cpu_init.c file. Thanks. Jason ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu
Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files. Signed-off-by: Angelo Dureghello sysa...@gmail.com --- arch/m68k/cpu/mcf530x/Makefile | 48 +++ arch/m68k/cpu/mcf530x/config.mk| 25 arch/m68k/cpu/mcf530x/cpu.c| 48 +++ arch/m68k/cpu/mcf530x/cpu.h| 33 + arch/m68k/cpu/mcf530x/cpu_init.c | 164 +++ arch/m68k/cpu/mcf530x/interrupts.c | 42 ++ arch/m68k/cpu/mcf530x/speed.c | 36 + arch/m68k/cpu/mcf530x/start.S | 253 arch/m68k/include/asm/immap_5307.h | 78 +++ arch/m68k/include/asm/m5307.h | 119 + 10 files changed, 846 insertions(+), 0 deletions(-) create mode 100644 arch/m68k/cpu/mcf530x/Makefile create mode 100644 arch/m68k/cpu/mcf530x/config.mk create mode 100644 arch/m68k/cpu/mcf530x/cpu.c create mode 100644 arch/m68k/cpu/mcf530x/cpu.h create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.c create mode 100644 arch/m68k/cpu/mcf530x/start.S create mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h diff --git a/arch/m68k/cpu/mcf530x/Makefile b/arch/m68k/cpu/mcf530x/Makefile new file mode 100644 index 000..3c5a1c2 --- /dev/null +++ b/arch/m68k/cpu/mcf530x/Makefile @@ -0,0 +1,48 @@ +# +# Copyright (c) 2011 Angelo Dureghello sysa...@gmail.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +# CFLAGS += -DET_DEBUG + +LIB= $(obj)lib$(CPU).o + +START = start.o +COBJS = interrupts.o cpu.o speed.o cpu_init.o + +SRCS := $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(SOBJS) $(COBJS)) +START := $(addprefix $(obj),$(START)) + +all: $(obj).depend $(START) $(LIB) + +$(LIB):$(OBJS) + $(call cmd_link_o_target, $(OBJS)) + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/arch/m68k/cpu/mcf530x/config.mk b/arch/m68k/cpu/mcf530x/config.mk new file mode 100644 index 000..2ba1644 --- /dev/null +++ b/arch/m68k/cpu/mcf530x/config.mk @@ -0,0 +1,25 @@ +# +# Copyright (c) 2011 Angelo Dureghello sysa...@gmail.com +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +PLATFORM_RELFLAGS += -ffixed-d7 -msep-data + +PLATFORM_CPPFLAGS += -m5307 -fPIC diff --git a/arch/m68k/cpu/mcf530x/cpu.c b/arch/m68k/cpu/mcf530x/cpu.c new file mode 100644 index 000..efd9cbd --- /dev/null +++ b/arch/m68k/cpu/mcf530x/cpu.c @@ -0,0 +1,48 @@ +/* + * Copyright (c) 2011 Angelo Dureghello sysa...@gmail.com + * + * See file CREDITS for list of people who contributed to this + * project. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You
