Re: [U-Boot] [PATCH 1/2] Add GPIO Driver and IOMUX definition for S3C2440

2012-04-30 Thread Gabriel Huau
On Mon, Apr 30, 2012 at 01:29:37AM +0200, Marek Vasut wrote:
 Dear Gabriel Huau,
 
 Commit message got lost ? :p

It's strange, I have the commit message in my log, but when I
format-patch, The commit message is set only in the subject, not
in the body.

Any idea ?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/2] Add GPIO Driver and IOMUX definition for S3C2440

2012-04-30 Thread Marek Vasut
Dear Gabriel Huau,

 On Mon, Apr 30, 2012 at 01:29:37AM +0200, Marek Vasut wrote:
  Dear Gabriel Huau,
  
  Commit message got lost ? :p
 
 It's strange, I have the commit message in my log, but when I
 format-patch, The commit message is set only in the subject, not
 in the body.

Are you sure you sent the correct patch ? ;-)

 
 Any idea ?

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/2] Add GPIO Driver and IOMUX definition for S3C2440

2012-04-30 Thread Gabriel Huau
On Mon, Apr 30, 2012 at 02:25:20PM +0200, Marek Vasut wrote:
 Dear Gabriel Huau,
 
  On Mon, Apr 30, 2012 at 01:29:37AM +0200, Marek Vasut wrote:
   Dear Gabriel Huau,
   
   Commit message got lost ? :p
  
  It's strange, I have the commit message in my log, but when I
  format-patch, The commit message is set only in the subject, not
  in the body.
 
 Are you sure you sent the correct patch ? ;-)

Yeap, I just did some tests, it seems that the commit message in the
body text is only from line 2. The line 1 is in the subject :)
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/2] Add GPIO Driver and IOMUX definition for S3C2440

2012-04-29 Thread Gabriel Huau
Signed-off-by: Gabriel Huau cont...@huau-gabriel.fr
---
 arch/arm/include/asm/arch-s3c24x0/gpio.h  |  183 +++
 arch/arm/include/asm/arch-s3c24x0/iomux.h |  197 +
 drivers/gpio/Makefile |1 +
 drivers/gpio/s3c2440_gpio.c   |   74 +++
 4 files changed, 455 insertions(+)
 create mode 100644 arch/arm/include/asm/arch-s3c24x0/gpio.h
 create mode 100644 arch/arm/include/asm/arch-s3c24x0/iomux.h
 create mode 100644 drivers/gpio/s3c2440_gpio.c

diff --git a/arch/arm/include/asm/arch-s3c24x0/gpio.h 
b/arch/arm/include/asm/arch-s3c24x0/gpio.h
new file mode 100644
index 000..e7fbefe
--- /dev/null
+++ b/arch/arm/include/asm/arch-s3c24x0/gpio.h
@@ -0,0 +1,183 @@
+/*
+ * Copyright (c) 2012, Gabriel Huau. All rights reserved.
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#ifndef _S3C24X0_GPIO_H_
+#define _S3C24X0_GPIO_H_
+
+#define GPIO_INPUT  0x0
+#define GPIO_OUTPUT 0x1
+
+/* 0x4 means that we can DAT and not CON register */
+#define GPIO_PORT(x)   x)  5)  0x3) + 0x4)
+#define GPIO_BIT(x)((x)  0x3f)
+
+/*
+ * It's how we calculate the full port address
+ * We have to get the number of the port + 1 (Port A is at 0x5601 ...)
+ * We move it at the second digit, and finally we add 0x4 because we want
+ * to modify GPIO DAT and not CON
+ */
+#define GPIO_FULLPORT(x) (S3C24X0_GPIO_BASE | ((GPIO_PORT(gpio) + 1)  1))
+
+typedef enum s3c2440_gpio {
+   GPA0,
+   GPA1,
+   GPA2,
+   GPA3,
+   GPA4,
+   GPA5,
+   GPA6,
+   GPA7,
+   GPA8,
+   GPA9,
+   GPA10,
+   GPA11,
+   GPA12,
+   GPA13,
+   GPA14,
+   GPA15,
+   GPA16,
+   GPA17,
+   GPA18,
+   GPA19,
+   GPA20,
+   GPA21,
+   GPA22,
+   GPA23,
+   GPA24,
+
+   GPB0 = 32,
+   GPB1,
+   GPB2,
+   GPB3,
+   GPB4,
+   GPB5,
+   GPB6,
+   GPB7,
+   GPB8,
+   GPB9,
+   GPB10,
+
+   GPC0 = 64,
+   GPC1,
+   GPC2,
+   GPC3,
+   GPC4,
+   GPC5,
+   GPC6,
+   GPC7,
+   GPC8,
+   GPC9,
+   GPC10,
+   GPC11,
+   GPC12,
+   GPC13,
+   GPC14,
+   GPC15,
+
+   GPD0 = 96,
+   GPD1,
+   GPD2,
+   GPD3,
+   GPD4,
+   GPD5,
+   GPD6,
+   GPD7,
+   GPD8,
+   GPD9,
+   GPD10,
+   GPD11,
+   GPD12,
+   GPD13,
+   GPD14,
+   GPD15,
+
+   GPE0 = 128,
+   GPE1,
+   GPE2,
+   GPE3,
+   GPE4,
+   GPE5,
+   GPE6,
+   GPE7,
+   GPE8,
+   GPE9,
+   GPE10,
+   GPE11,
+   GPE12,
+   GPE13,
+   GPE14,
+   GPE15,
+
+   GPF0 = 160,
+   GPF1,
+   GPF2,
+   GPF3,
+   GPF4,
+   GPF5,
+   GPF6,
+   GPF7,
+
+   GPG0 = 192,
+   GPG1,
+   GPG2,
+   GPG3,
+   GPG4,
+   GPG5,
+   GPG6,
+   GPG7,
+   GPG8,
+   GPG9,
+   GPG10,
+   GPG11,
+   GPG12,
+   GPG13,
+   GPG14,
+   GPG15,
+
+   GPH0 = 224,
+   GPH1,
+   GPH2,
+   GPH3,
+   GPH4,
+   GPH5,
+   GPH6,
+   GPH7,
+   GPH8,
+   GPH9,
+   GPH10,
+
+   GPJ0 = 256,
+   GPJ1,
+   GPJ2,
+   GPJ3,
+   GPJ4,
+   GPJ5,
+   GPJ6,
+   GPJ7,
+   GPJ8,
+   GPJ9,
+   GPJ10,
+   GPJ11,
+   GPJ12,
+} s3c2240_gpio;
+
+#endif
diff --git a/arch/arm/include/asm/arch-s3c24x0/iomux.h 
b/arch/arm/include/asm/arch-s3c24x0/iomux.h
new file mode 100644
index 000..2201cd3
--- /dev/null
+++ b/arch/arm/include/asm/arch-s3c24x0/iomux.h
@@ -0,0 +1,197 @@
+/*
+ * Copyright (c) 2012, Gabriel Huau. All rights reserved.
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * 

Re: [U-Boot] [PATCH 1/2] Add GPIO Driver and IOMUX definition for S3C2440

2012-04-29 Thread Marek Vasut
Dear Gabriel Huau,

Commit message got lost ? :p

 Signed-off-by: Gabriel Huau cont...@huau-gabriel.fr
 ---
  arch/arm/include/asm/arch-s3c24x0/gpio.h  |  183
 +++ arch/arm/include/asm/arch-s3c24x0/iomux.h | 
 197 + drivers/gpio/Makefile   
  |1 +
  drivers/gpio/s3c2440_gpio.c   |   74 +++
  4 files changed, 455 insertions(+)
  create mode 100644 arch/arm/include/asm/arch-s3c24x0/gpio.h
  create mode 100644 arch/arm/include/asm/arch-s3c24x0/iomux.h
  create mode 100644 drivers/gpio/s3c2440_gpio.c
 
 diff --git a/arch/arm/include/asm/arch-s3c24x0/gpio.h
 b/arch/arm/include/asm/arch-s3c24x0/gpio.h new file mode 100644
 index 000..e7fbefe
 --- /dev/null
 +++ b/arch/arm/include/asm/arch-s3c24x0/gpio.h
 @@ -0,0 +1,183 @@
 +/*
 + * Copyright (c) 2012, Gabriel Huau. All rights reserved.
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#ifndef _S3C24X0_GPIO_H_
 +#define _S3C24X0_GPIO_H_
 +
 +#define GPIO_INPUT  0x0
 +#define GPIO_OUTPUT 0x1
 +
 +/* 0x4 means that we can DAT and not CON register */
 +#define GPIO_PORT(x) x)  5)  0x3) + 0x4)
 +#define GPIO_BIT(x)  ((x)  0x3f)

Move this to driver?

 +
 +/*
 + * It's how we calculate the full port address
 + * We have to get the number of the port + 1 (Port A is at 0x5601 ...)
 + * We move it at the second digit, and finally we add 0x4 because we want
 + * to modify GPIO DAT and not CON
 + */
 +#define GPIO_FULLPORT(x) (S3C24X0_GPIO_BASE | ((GPIO_PORT(gpio) + 1) 
 1)) +
 +typedef enum s3c2440_gpio {
 + GPA0,
 + GPA1,
 + GPA2,
 + GPA3,
 + GPA4,
 + GPA5,
 + GPA6,
 + GPA7,
 + GPA8,
 + GPA9,
 + GPA10,
 + GPA11,
 + GPA12,
 + GPA13,
 + GPA14,
 + GPA15,
 + GPA16,
 + GPA17,
 + GPA18,
 + GPA19,
 + GPA20,
 + GPA21,
 + GPA22,
 + GPA23,
 + GPA24,
 +
 + GPB0 = 32,
 + GPB1,
 + GPB2,
 + GPB3,
 + GPB4,
 + GPB5,
 + GPB6,
 + GPB7,
 + GPB8,
 + GPB9,
 + GPB10,
 +
 + GPC0 = 64,
 + GPC1,
 + GPC2,
 + GPC3,
 + GPC4,
 + GPC5,
 + GPC6,
 + GPC7,
 + GPC8,
 + GPC9,
 + GPC10,
 + GPC11,
 + GPC12,
 + GPC13,
 + GPC14,
 + GPC15,
 +
 + GPD0 = 96,
 + GPD1,
 + GPD2,
 + GPD3,
 + GPD4,
 + GPD5,
 + GPD6,
 + GPD7,
 + GPD8,
 + GPD9,
 + GPD10,
 + GPD11,
 + GPD12,
 + GPD13,
 + GPD14,
 + GPD15,
 +
 + GPE0 = 128,
 + GPE1,
 + GPE2,
 + GPE3,
 + GPE4,
 + GPE5,
 + GPE6,
 + GPE7,
 + GPE8,
 + GPE9,
 + GPE10,
 + GPE11,
 + GPE12,
 + GPE13,
 + GPE14,
 + GPE15,
 +
 + GPF0 = 160,
 + GPF1,
 + GPF2,
 + GPF3,
 + GPF4,
 + GPF5,
 + GPF6,
 + GPF7,
 +
 + GPG0 = 192,
 + GPG1,
 + GPG2,
 + GPG3,
 + GPG4,
 + GPG5,
 + GPG6,
 + GPG7,
 + GPG8,
 + GPG9,
 + GPG10,
 + GPG11,
 + GPG12,
 + GPG13,
 + GPG14,
 + GPG15,
 +
 + GPH0 = 224,
 + GPH1,
 + GPH2,
 + GPH3,
 + GPH4,
 + GPH5,
 + GPH6,
 + GPH7,
 + GPH8,
 + GPH9,
 + GPH10,
 +
 + GPJ0 = 256,
 + GPJ1,
 + GPJ2,
 + GPJ3,
 + GPJ4,
 + GPJ5,
 + GPJ6,
 + GPJ7,
 + GPJ8,
 + GPJ9,
 + GPJ10,
 + GPJ11,
 + GPJ12,
 +} s3c2240_gpio;
 +
 +#endif
 diff --git a/arch/arm/include/asm/arch-s3c24x0/iomux.h
 b/arch/arm/include/asm/arch-s3c24x0/iomux.h new file mode 100644
 index 000..2201cd3
 --- /dev/null
 +++ b/arch/arm/include/asm/arch-s3c24x0/iomux.h
 @@ -0,0 +1,197 @@
 +/*
 + * Copyright (c) 2012, Gabriel Huau. All rights reserved.

Add your email address so I know where to send blackmail if this gets broken ;-)

 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that