Re: [U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation
Dear Masahiro, In message <20140116095004.e122.aa925...@jp.panasonic.com> you wrote: > > I do understand you want to use TABs for indentation. > But I don't understand why you want to use them in the > comment block. I think the part will not be changed often. > I'm talking about a TAB between > " U-Boot source tree." and "The remainders rest" > > > -be removed from the U-Boot source tree. The remainders rest in piece > > -in the imperishable depths of the git history. This document tries to > > +be removed from the U-Boot source tree. The remainders rest in piece > > +in the imperishable depths of the git history. This document tries to > > I mean, here. Ah, this was not intentionally. I was running the whole file through "unexpand -a", and this replaces multipe spaces at TAB positions by TABs. I did not notice this. > No. Shorter lines are better. > You are right. > (But I a little afraid someone who does not understand "TAB + 4 SPACE" > rule might break the format.) Yes - it is likely that later edits will re-introduce spaces, but the we can easily re-fix this by piping the file through "unexpand -a". Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Conceptual integrity in turn dictates that the design must proceed from one mind, or from a very small number of agreeing resonant minds. - Frederick Brooks Jr., "The Mythical Man Month" ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation
On 01/15/2014 01:48 AM, Wolfgang Denk wrote: > To make adding new entries a bit easier, we reformat the file to use > TABs for indentation. > > Also insert two now known commit IDs. > > Signed-off-by: Wolfgang Denk > --- > doc/README.scrapyard | 252 > +++ > 1 file changed, 154 insertions(+), 98 deletions(-) > > diff --git a/doc/README.scrapyard b/doc/README.scrapyard > index 604de0c..54756f3 100644 > --- a/doc/README.scrapyard > +++ b/doc/README.scrapyard > @@ -1,107 +1,163 @@ > Over time, support for more and more boards gets added to U-Boot - > while other board support code dies a silent death caused by > -negligence in combination with ordinary bitrot. Sometimes this goes > +negligence in combination with ordinary bitrot. Sometimes this goes > by unnoticed, but often build errors will result. If nobody cares any > more to resolve such problems, then the code is really dead and will > -be removed from the U-Boot source tree. The remainders rest in piece > -in the imperishable depths of the git history. This document tries to > +be removed from the U-Boot source tree. The remainders rest in piece > +in the imperishable depths of the git history. This document tries to > maintain a list of such former fellows, so archeologists can check ^^^ s/archeologists/archaeologists/ > easily if here is something they might want to dig for... ^^^ s/here/there/ Sincerely, Jesse Larrew Open Grid Computing ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation
Hello Wolfgang, > > Why did you insert TABs here? > > Because it requires less typing when adding new entries. I do understand you want to use TABs for indentation. But I don't understand why you want to use them in the comment block. I think the part will not be changed often. I'm talking about a TAB between " U-Boot source tree." and "The remainders rest" > -be removed from the U-Boot source tree. The remainders rest in piece > -in the imperishable depths of the git history. This document tries to > +be removed from the U-Boot source tree. The remainders rest in piece > +in the imperishable depths of the git history. This document tries to I mean, here. > > You are using TABs and SPACEs mixed-up. > > Correct. I decided to go for a minimal-invasive change that would not > result in some very long lines. So most columns are aligned by TAG, > and two of them by TAB + 4 x SPACE. Makes sense. > > If you do this refactoring, I'd like to request that only TABs are used > > consistently. > > I can do this - but then, this will result in very long lines. Do you > prefer that? No. Shorter lines are better. You are right. (But I a little afraid someone who does not understand "TAB + 4 SPACE" rule might break the format.) Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation
Dear Masahiro, In message <20140115174127.e118.aa925...@jp.panasonic.com> you wrote: > > Why did you insert TABs here? Because it requires less typing when adding new entries. > You are using TABs and SPACEs mixed-up. Correct. I decided to go for a minimal-invasive change that would not result in some very long lines. So most columns are aligned by TAG, and two of them by TAB + 4 x SPACE. > If you do this refactoring, I'd like to request that only TABs are used > consistently. I can do this - but then, this will result in very long lines. Do you prefer that? > And another thing , this series can not applied on the current > u-boot/master. The patches are against v2014.01-rc3 ; rebasing against current top of tree is trivial as only the two new entries for mx1ads and mini2440 need fixing. I can fix this, but let's ait until we see what happens with the actual 82xx removal patch. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Die meisten Menschen pflegen im Kindesalter vom Zeigen auf Gegenstän- de (Mausbewegung) und "ga" sagen (Mausklick) abzukommen, zugunsten eines mächtigeren und langwierig zu erlernenden Tools (Sprache). -- Achim Linder in de.comp.os.linux.misc ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation
Hello Wolfgang > Over time, support for more and more boards gets added to U-Boot - > while other board support code dies a silent death caused by > -negligence in combination with ordinary bitrot. Sometimes this goes > +negligence in combination with ordinary bitrot. Sometimes this goes > by unnoticed, but often build errors will result. If nobody cares any > more to resolve such problems, then the code is really dead and will > -be removed from the U-Boot source tree. The remainders rest in piece > -in the imperishable depths of the git history. This document tries to > +be removed from the U-Boot source tree. The remainders rest in piece > +in the imperishable depths of the git history. This document tries to > maintain a list of such former fellows, so archeologists can check > easily if here is something they might want to dig for... Why did you insert TABs here? > > -BoardArchCPUCommit Removed Last > known maintainer/contact > +BoardArchCPU Commit Removed > Last known maintainer/contact <> > +A3000powerpc mpc824x - - > +CU824powerpc mpc824x - - > Wolfgang Denk > +debris powerpc mpc824x - - > Sangmoon Kim > +eXalion powerpc mpc824x - - > Torsten Demke You are using TABs and SPACEs mixed-up. "ARCH" field is aligned by TAB. There are TABs between A3000 and powerpc. Whereas, "CPU" field is aligned by SPACE. There are some SPACEs between powerpc and mpc824x. If you do this refactoring, I'd like to request that only TABs are used consistently. And another thing , this series can not applied on the current u-boot/master. (I think Tom can resolve the conflict.) Best Regards Masahiro Yamada ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/2] doc/README.scrapyard: update commit IDs, use TAB for indentation
To make adding new entries a bit easier, we reformat the file to use TABs for indentation. Also insert two now known commit IDs. Signed-off-by: Wolfgang Denk --- doc/README.scrapyard | 252 +++ 1 file changed, 154 insertions(+), 98 deletions(-) diff --git a/doc/README.scrapyard b/doc/README.scrapyard index 604de0c..54756f3 100644 --- a/doc/README.scrapyard +++ b/doc/README.scrapyard @@ -1,107 +1,163 @@ Over time, support for more and more boards gets added to U-Boot - while other board support code dies a silent death caused by -negligence in combination with ordinary bitrot. Sometimes this goes +negligence in combination with ordinary bitrot. Sometimes this goes by unnoticed, but often build errors will result. If nobody cares any more to resolve such problems, then the code is really dead and will -be removed from the U-Boot source tree. The remainders rest in piece -in the imperishable depths of the git history. This document tries to +be removed from the U-Boot source tree. The remainders rest in piece +in the imperishable depths of the git history. This document tries to maintain a list of such former fellows, so archeologists can check easily if here is something they might want to dig for... -BoardArchCPUCommit Removed Last known maintainer/contact +Board ArchCPU Commit Removed Last known maintainer/contact = -omap730p2arm arm926ejs - 2013-11-11 -pn62 powerpc mpc824x- 2013-11-11 Wolfgang Grandegger -pdnb3arm ixp304db0b 2013-09-24 Stefan Roese -scpu arm ixp304db0b 2013-09-24 Stefan Roese -omap1510inn arm arm925t0610a16 2013-09-23 Kshitij Gupta -CANBTpowerpc 405CR fb8f4fd 2013-08-07 Matthias Fuchs -Alaska8220 powerpc mpc8220d6ed322 2013-05-11 -Yukon8220powerpc mpc8220d6ed322 2013-05-11 -sorcery powerpc mpc8220d6ed322 2013-05-11 -smdk6400 arm arm117652587f1 2013-04-12 Zhong Hongbo -ns9750devarm arm926ejs 4cfc611 2013-02-28 Markus Pietrek -AMX860 powerpc mpc860 1b0757e 2012-10-28 Wolfgang Denk -c2monpowerpc mpc855 1b0757e 2012-10-28 Wolfgang Denk -EP88xpowerpc mpc885 1b0757e 2012-10-28 -ETX094 powerpc mpc850 1b0757e 2012-10-28 Wolfgang Denk -IAD210 powerpc mpc860 1b0757e 2012-10-28 - -LANTEC powerpc mpc850 1b0757e 2012-10-28 Wolfgang Denk -SCM powerpc mpc82601b0757e 2012-10-28 Wolfgang Grandegger -SX1 arm arm925t53c4154 2012-10-26 -TQM85xx powerpc MPC85xxd923a5d 2012-10-04 Stefan Roese -apollon arm omap24xx 535c74f 2012-09-18 Kyungmin Park -tb0229 mipsmips32 3f3110d 2011-12-12 -rmu powerpc MPC850 fb82fd7 2011-12-07 Wolfgang Denk -OXC powerpc MPC8240309a292 2011-12-07 -BAB7xx powerpc MPC740/MPC750 c53043b 2011-12-07 Frank Gottschling -xm250arm pxac746cdd 2011-25-11 -pleb2arm pxab185a1c 2011-25-11 -cradle arm pxa4e24f8a 2011-25-11 Kyle Harris -cerf250 arm pxaa3f1241 2011-25-11 Prakash Kumar -mpq101 powerpc mpc85xxe877fab 2011-10-23 Alex Dubov -ixdpg425 arm ixp0ca8eb7 2011-09-22 Stefan Roese -ixdp425 arm ixp0ca8eb7 2011-09-22 Kyle Harris -zylonite arm pxab66521a 2011-09-05 -shannon arm sa1100 5df092d 2011-09-05 Rolf Offermanns -modnet50 arm arm720t9c62815 2011-09-05 Thomas Elste -lpc2292sodimmarm arm720td1a067a 2011-09-05 -lart arm sa1100 3d57573 2011-09-05 Alex Züpke -impa7arm arm720tc1f8750 2011-09-05 Marius Gröger -gcplus arm sa1100 2c650e2 2011-09-05 George G. Davis -evb4510 arm arm720t26e670e 2011-09-05 Curt Brune -ep7312 arm arm720tc8f63b4 2011-09-05 Marius Gröger -dnp1110 arm sa1100 fc5e5ce 2011-09-05 Alex Züpke -SMN42arm arm720t6a
