[U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
Factor out common DDR3 initialization code, allowing easier maintainance of such scripts. Signed-off-by: Fabio Estevam --- .../arm/imx-common/ddr/mx6q_ddr3.cfg |0 board/freescale/mx6qarm2/imximage.cfg | 173 boards.cfg |4 +- 3 files changed, 2 insertions(+), 175 deletions(-) rename board/freescale/mx6qsabrelite/imximage.cfg => arch/arm/imx-common/ddr/mx6q_ddr3.cfg (100%) delete mode 100644 board/freescale/mx6qarm2/imximage.cfg diff --git a/board/freescale/mx6qsabrelite/imximage.cfg b/arch/arm/imx-common/ddr/mx6q_ddr3.cfg similarity index 100% rename from board/freescale/mx6qsabrelite/imximage.cfg rename to arch/arm/imx-common/ddr/mx6q_ddr3.cfg diff --git a/board/freescale/mx6qarm2/imximage.cfg b/board/freescale/mx6qarm2/imximage.cfg deleted file mode 100644 index bf941a3..000 --- a/board/freescale/mx6qarm2/imximage.cfg +++ /dev/null @@ -1,173 +0,0 @@ -# Copyright (C) 2011 Freescale Semiconductor, Inc. -# Jason Liu -# -# See file CREDITS for list of people who contributed to this -# project. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License as -# published by the Free Software Foundation; either version 2 of -# the License or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not write to the Free Software -# Foundation Inc. 51 Franklin Street Fifth Floor Boston, -# MA 02110-1301 USA -# -# Refer docs/README.imxmage for more details about how-to configure -# and create imximage boot image -# -# The syntax is taken as close as possible with the kwbimage - -# image version - -IMAGE_VERSION 2 - -# Boot Device : one of -# spi, sd (the board has no nand neither onenand) - -BOOT_FROM sd - -# Device Configuration Data (DCD) -# -# Each entry must have the format: -# Addr-type AddressValue -# -# where: -# Addr-type register length (1,2 or 4 bytes) -# Address absolute address of the register -# value value to be stored in the register -DATA 4 0x020e05a8 0x0030 -DATA 4 0x020e05b0 0x0030 -DATA 4 0x020e0524 0x0030 -DATA 4 0x020e051c 0x0030 - -DATA 4 0x020e0518 0x0030 -DATA 4 0x020e050c 0x0030 -DATA 4 0x020e05b8 0x0030 -DATA 4 0x020e05c0 0x0030 - -DATA 4 0x020e05ac 0x00020030 -DATA 4 0x020e05b4 0x00020030 -DATA 4 0x020e0528 0x00020030 -DATA 4 0x020e0520 0x00020030 - -DATA 4 0x020e0514 0x00020030 -DATA 4 0x020e0510 0x00020030 -DATA 4 0x020e05bc 0x00020030 -DATA 4 0x020e05c4 0x00020030 - -DATA 4 0x020e056c 0x00020030 -DATA 4 0x020e0578 0x00020030 -DATA 4 0x020e0588 0x00020030 -DATA 4 0x020e0594 0x00020030 - -DATA 4 0x020e057c 0x00020030 -DATA 4 0x020e0590 0x3000 -DATA 4 0x020e0598 0x3000 -DATA 4 0x020e058c 0x - -DATA 4 0x020e059c 0x3030 -DATA 4 0x020e05a0 0x3030 -DATA 4 0x020e0784 0x0030 -DATA 4 0x020e0788 0x0030 - -DATA 4 0x020e0794 0x0030 -DATA 4 0x020e079c 0x0030 -DATA 4 0x020e07a0 0x0030 -DATA 4 0x020e07a4 0x0030 - -DATA 4 0x020e07a8 0x0030 -DATA 4 0x020e0748 0x0030 -DATA 4 0x020e074c 0x0030 -DATA 4 0x020e0750 0x0002 - -DATA 4 0x020e0758 0x -DATA 4 0x020e0774 0x0002 -DATA 4 0x020e078c 0x0030 -DATA 4 0x020e0798 0x000C - -DATA 4 0x021b081c 0x -DATA 4 0x021b0820 0x -DATA 4 0x021b0824 0x -DATA 4 0x021b0828 0x - -DATA 4 0x021b481c 0x -DATA 4 0x021b4820 0x -DATA 4 0x021b4824 0x -DATA 4 0x021b4828 0x - -DATA 4 0x021b0018 0x00081740 - -DATA 4 0x021b001c 0x8000 -DATA 4 0x021b000c 0x555A7975 -DATA 4 0x021b0010 0xFF538E64 -DATA 4 0x021b0014 0x01FF00DB -DATA 4 0x021b002c 0x26D2 - -DATA 4 0x021b0030 0x005B0E21 -DATA 4 0x021b0008 0x09444040 -DATA 4 0x021b0004 0x00025576 -DATA 4 0x021b0040 0x0027 -DATA 4 0x021b 0xC31A - -DATA 4 0x021b001c 0x04088032 -DATA 4 0x021b001c 0x0408803A -DATA 4 0x021b001c 0x8033 -DATA 4 0x021b001c 0x803B -DATA 4 0x021b001c 0x00428031 -DATA 4 0x021b001c 0x00428039 -DATA 4 0x021b001c 0x09408030 -DATA 4 0x021b001c 0x09408038 - -DATA 4 0x021b001c 0x04008040 -DATA 4 0x021b001c 0x04008048 -DATA 4 0x021b0800 0xA1380003 -DATA 4 0x021b4800 0xA1380003 -DATA 4 0x021b0020 0x5800 -DATA 4 0x021b0818 0x0007 -DATA 4 0x021b4818 0x0007 - -DATA 4 0x021b083c 0x434B0350 -DATA 4 0x021b0840 0x034C0359 -DATA 4 0x021b483c 0x434B0350 -DATA 4 0x021b4840 0x03650348 -DATA 4 0x021b0848 0x4436383B -DATA 4 0x021b4848 0x39393341 -DATA 4 0x021b0850 0x35373933 -DATA 4 0x021b4850 0x48254A36 - -DATA 4 0x021b080c 0x001F001F -DATA 4 0x021b0810 0x001F001F - -DATA 4 0x
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
>-Original Message- >From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] >On Behalf Of Fabio Estevam >Sent: Wednesday, September 12, 2012 2:33 AM >To: sba...@denx.de >Cc: Estevam Fabio-R49496; u-boot@lists.denx.de >Subject: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code > >Factor out common DDR3 initialization code, allowing easier maintainance of >such scripts. Are you sure that we can use on DDR3 script to cover 3 kind of boards: ARM2/Sabrelite/SabreSD? Did you do the DDR stress test? > >Signed-off-by: Fabio Estevam >--- > .../arm/imx-common/ddr/mx6q_ddr3.cfg |0 > board/freescale/mx6qarm2/imximage.cfg | 173 > boards.cfg |4 +- > 3 files changed, 2 insertions(+), 175 deletions(-) rename >board/freescale/mx6qsabrelite/imximage.cfg => arch/arm/imx- >common/ddr/mx6q_ddr3.cfg (100%) delete mode 100644 >board/freescale/mx6qarm2/imximage.cfg > >diff --git a/board/freescale/mx6qsabrelite/imximage.cfg b/arch/arm/imx- [...] >1.7.9.5 > > >___ >U-Boot mailing list >U-Boot@lists.denx.de >http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
On Tue, Sep 11, 2012 at 11:26 PM, Liu Hui-R64343 wrote: >>-Original Message- >>From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] >>On Behalf Of Fabio Estevam >>Sent: Wednesday, September 12, 2012 2:33 AM >>To: sba...@denx.de >>Cc: Estevam Fabio-R49496; u-boot@lists.denx.de >>Subject: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code >> >>Factor out common DDR3 initialization code, allowing easier maintainance of >>such scripts. > > Are you sure that we can use on DDR3 script to cover 3 kind of boards: > > ARM2/Sabrelite/SabreSD? Did you do the DDR stress test? Yes, mtest runs fine. I also plan to do the same for mx53 boards. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
On Tue, Sep 11, 2012 at 11:42 PM, Liu Hui-R64343 wrote: > mtest is not enough, you need run FSL DDR stress test tool. I will be glad to test it, if you port it to U-boot ;-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
Am 12/09/2012 04:42, schrieb Liu Hui-R64343: >> -Original Message- >> From: Fabio Estevam [mailto:feste...@gmail.com] >> Sent: Wednesday, September 12, 2012 10:33 AM >> To: Liu Hui-R64343 >> Cc: Estevam Fabio-R49496; sba...@denx.de; u-boot@lists.denx.de >> Subject: Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code >> >> On Tue, Sep 11, 2012 at 11:26 PM, Liu Hui-R64343 >> wrote: >>>> -Original Message- >>>> From: u-boot-boun...@lists.denx.de >>>> [mailto:u-boot-boun...@lists.denx.de] >>>> On Behalf Of Fabio Estevam >>>> Sent: Wednesday, September 12, 2012 2:33 AM >>>> To: sba...@denx.de >>>> Cc: Estevam Fabio-R49496; u-boot@lists.denx.de >>>> Subject: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code >>>> >>>> Factor out common DDR3 initialization code, allowing easier >>>> maintainance of such scripts. >>> >>> Are you sure that we can use on DDR3 script to cover 3 kind of boards: >>> >>> ARM2/Sabrelite/SabreSD? Did you do the DDR stress test? >> >> Yes, mtest runs fine. > > mtest is not enough, you need run FSL DDR stress test tool. Then you are saying the *current* configuration in u-boot is already buggy. Fabio has only moved the setup but the boards use now the same configuration. Can you tell us which problem you have found with the current code ? Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
Jason, On Tue, Sep 11, 2012 at 11:26 PM, Liu Hui-R64343 wrote: > Are you sure that we can use on DDR3 script to cover 3 kind of boards: > > ARM2/Sabrelite/SabreSD? Did you do the DDR stress test? Ok, looking more closely at this I will keep the ARM2 DDR3 init as is in my v2 series. sabrelite and sabresd does have the same DDR3 init as per the FSL U-boot source. arm2 has a different DDR3 density, so I will not touch this file. Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
Am 12/09/2012 20:22, schrieb Fabio Estevam: > Jason, > Hi Fabio, > On Tue, Sep 11, 2012 at 11:26 PM, Liu Hui-R64343 wrote: > >> Are you sure that we can use on DDR3 script to cover 3 kind of boards: >> >> ARM2/Sabrelite/SabreSD? Did you do the DDR stress test? > > Ok, looking more closely at this I will keep the ARM2 DDR3 init as is > in my v2 series. > > sabrelite and sabresd does have the same DDR3 init as per the FSL U-boot > source. > > arm2 has a different DDR3 density, so I will not touch this file. Ok - before you put your next version, is imx-common the right place fir it ? I mean, in imx-common we should put code that can be shared among different Freescale's SOCs. The imximage you want to share is common to some boards, not SOCs. Should we put it into a freescale's directory, let see something into boards/freescale ? There is already a boards/freescale/common, but it is PowerPC specific, so maybe it is not the right place, but we could add a new one. What do you think ? Best regards, Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
Hi Stefano, On Wed, Sep 12, 2012 at 7:06 PM, stefano babic wrote: > Ok - before you put your next version, is imx-common the right place fir > it ? I mean, in imx-common we should put code that can be shared among > different Freescale's SOCs. The imximage you want to share is common to > some boards, not SOCs. Should we put it into a freescale's directory, > let see something into boards/freescale ? There is already a > boards/freescale/common, but it is PowerPC specific, so maybe it is not > the right place, but we could add a new one. What do you think ? Ok, good point. What about boards/freescale/imx/ddr ? Regards, Fabio Estevam ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] mx6q: Factor out common DDR3 init code
Am 13/09/2012 06:57, schrieb Fabio Estevam: > Hi Stefano, > > On Wed, Sep 12, 2012 at 7:06 PM, stefano babic wrote: > >> Ok - before you put your next version, is imx-common the right place fir >> it ? I mean, in imx-common we should put code that can be shared among >> different Freescale's SOCs. The imximage you want to share is common to >> some boards, not SOCs. Should we put it into a freescale's directory, >> let see something into boards/freescale ? There is already a >> boards/freescale/common, but it is PowerPC specific, so maybe it is not >> the right place, but we could add a new one. What do you think ? > > Ok, good point. What about boards/freescale/imx/ddr ? It is fine with me Regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
