Re: [U-Boot] [PATCH 1/2] net: nfs: Drop CONFIG_NFS_READ_SIZE

[Joe Hershberger]

On Sun, Aug 20, 2017 at 9:40 PM, Tom Rini  wrote:
> In the general case, CONFIG_NFS_READ_SIZE is unchanged from the default
> of 1024.  There are in fact no in-tree users that increase this size.
> Adjust the comment to reflect what could be done in the future in
> conjunction with CONFIG_IP_DEFRAG.
>
> Cc: Joe Hershberger 
> Signed-off-by: Tom Rini 

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/2] net: nfs: Drop CONFIG_NFS_READ_SIZE

[Tom Rini]

In the general case, CONFIG_NFS_READ_SIZE is unchanged from the default
of 1024.  There are in fact no in-tree users that increase this size.
Adjust the comment to reflect what could be done in the future in
conjunction with CONFIG_IP_DEFRAG.

Cc: Joe Hershberger 
Signed-off-by: Tom Rini 
---
 net/nfs.h | 13 +
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/net/nfs.h b/net/nfs.h
index 70a1a6d554be..1aa06e8fb90f 100644
--- a/net/nfs.h
+++ b/net/nfs.h
@@ -36,16 +36,13 @@
 #define NFSERR_ISDIR21
 #define NFSERR_INVAL22
 
-/* Block size used for NFS read accesses.  A RPC reply packet (including  all
+/*
+ * Block size used for NFS read accesses.  A RPC reply packet (including  all
  * headers) must fit within a single Ethernet frame to avoid fragmentation.
- * However, if CONFIG_IP_DEFRAG is set, the config file may want to use a
- * bigger value. In any case, most NFS servers are optimized for a power of 2.
+ * However, if CONFIG_IP_DEFRAG is set, a bigger value could be used.  In any
+ * case, most NFS servers are optimized for a power of 2.
  */
-#ifdef CONFIG_NFS_READ_SIZE
-#define NFS_READ_SIZE CONFIG_NFS_READ_SIZE
-#else
-#define NFS_READ_SIZE 1024 /* biggest power of two that fits Ether frame */
-#endif
+#define NFS_READ_SIZE  1024/* biggest power of two that fits Ether frame */
 
 /* Values for Accept State flag on RPC answers (See: rfc1831) */
 enum rpc_accept_stat {
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot