[U-Boot] [PATCH 1/2 v3] net, fec_mxc: only setup the device enetaddr with eeprom value
only fill the device enetaddr with the contents of the eeprom, not program it in mac address registers Signed-off-by: Heiko Schocher --- - changes since v1 posted here: http://lists.denx.de/pipermail/u-boot/2010-March/069192.html - splitted in two patches as Wolfgang suggested - changes since v2 posted here: http://lists.denx.de/pipermail/u-boot/2010-March/069244.html - add comment from Ben and Mike: - not to look in content from "ethaddr" - only read the mac from eeprom to ethdevices enetaddr and do not program it in mac address registers drivers/net/fec_mxc.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 5af9cdb..8c4ade5 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -752,7 +752,6 @@ static int fec_probe(bd_t *bd) if (fec_get_hwaddr(edev, ethaddr) == 0) { printf("got MAC address from EEPROM: %pM\n", ethaddr); memcpy(edev->enetaddr, ethaddr, 6); - fec_set_hwaddr(edev); } return 0; -- 1.6.2.5 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2 v3] net, fec_mxc: only setup the device enetaddr with eeprom value
Hi Heiko, Much better. Thanks, and sorry again for not responding sooner. Wolfgang - please apply this to the current release. On Tue, Mar 30, 2010 at 11:34 PM, Heiko Schocher wrote: > only fill the device enetaddr with the contents of the eeprom, > not program it in mac address registers > > Signed-off-by: Heiko Schocher Acked-by: Ben Warren > --- > - changes since v1 posted here: > http://lists.denx.de/pipermail/u-boot/2010-March/069192.html > > - splitted in two patches as Wolfgang suggested > > - changes since v2 posted here: > > http://lists.denx.de/pipermail/u-boot/2010-March/069244.html > > - add comment from Ben and Mike: >- not to look in content from "ethaddr" >- only read the mac from eeprom to ethdevices enetaddr and > do not program it in mac address registers > > drivers/net/fec_mxc.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index 5af9cdb..8c4ade5 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -752,7 +752,6 @@ static int fec_probe(bd_t *bd) >if (fec_get_hwaddr(edev, ethaddr) == 0) { >printf("got MAC address from EEPROM: %pM\n", ethaddr); >memcpy(edev->enetaddr, ethaddr, 6); > - fec_set_hwaddr(edev); >} > >return 0; > -- > 1.6.2.5 > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2 v3] net, fec_mxc: only setup the device enetaddr with eeprom value
Dear Ben Warren, In message you wrote: > > Wolfgang - please apply this to the current release. > > On Tue, Mar 30, 2010 at 11:34 PM, Heiko Schocher wrote: > > > only fill the device enetaddr with the contents of the eeprom, > > not program it in mac address registers > > > > Signed-off-by: Heiko Schocher > > Acked-by: Ben Warren Done, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de As in certain cults it is possible to kill a process if you know its true name. -- Ken Thompson and Dennis M. Ritchie ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2 v3] net, fec_mxc: only setup the device enetaddr with eeprom value
Dear Heiko Schocher, In message <4bb2ed06.3010...@denx.de> you wrote: > only fill the device enetaddr with the contents of the eeprom, > not program it in mac address registers > > Signed-off-by: Heiko Schocher > --- > - changes since v1 posted here: > http://lists.denx.de/pipermail/u-boot/2010-March/069192.html > > - splitted in two patches as Wolfgang suggested > > - changes since v2 posted here: > > http://lists.denx.de/pipermail/u-boot/2010-March/069244.html > > - add comment from Ben and Mike: > - not to look in content from "ethaddr" > - only read the mac from eeprom to ethdevices enetaddr and > do not program it in mac address registers > > drivers/net/fec_mxc.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Thanks. Applied after reverting v2. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de An Elephant is a mouse with an Operating System. - Knuth ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot