Re: [U-Boot] [PATCH 1/3] board/amcc/common/flash.c: Fix GCC 4.6 build warning

2011-12-01 Thread Wolfgang Denk 
Dear Stefan,

In message 1321559401-26495-1-git-send-email...@denx.de I wrote:
 Fix:
 In file included from flash.c:45:0:
 ../common/flash.c: In function 'flash_erase':
 ../common/flash.c:399:24: warning: variable 'l_sect' set but not used
 [-Wunused-but-set-variable]
 
 Signed-off-by: Wolfgang Denk w...@denx.de
 Cc: Stefan Roese s...@denx.de
 ---
 total: 0 errors, 0 warnings, 46 lines checked
 NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
 MULTISTATEMENT_MACRO_USE_DO_WHILE
 0001-board-amcc-common-flash.c-Fix-GCC-4.6-build-warning.patch has no obvious 
 style problems and is ready for submission.
 
  board/amcc/common/flash.c |   10 ++
  1 files changed, 2 insertions(+), 8 deletions(-)

Ping for these patches:

11/17 To:u-boot@lists.d  [PATCH 1/3] board/amcc/common/flash.c: Fix GCC 4.6 
build warning
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/117300
IDStateName
---
126305 New  [U-Boot,1/3] board/amcc/common/flash.c: Fix GCC 4.6 build 
warning
11/17 To:u-boot@lists.d  [PATCH 2/3] board/amcc/yucca/flash.c: Fix GCC 4.6 
build warnings
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/117301
IDStateName
---
126306 New  [U-Boot,2/3] board/amcc/yucca/flash.c: Fix GCC 4.6 build 
warnings
11/17 To:u-boot@lists.d  [PATCH 3/3] board/amcc/taihu/flash.c: Fix GCC 4.6 
build warnings
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/117299
IDStateName
---
126304 New  [U-Boot,3/3] board/amcc/taihu/flash.c: Fix GCC 4.6 build 
warnings


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I wish I had a bronze torc for every user who didn't read the manual.
 - Terry Pratchett, _The Light Fantastic_
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] board/amcc/common/flash.c: Fix GCC 4.6 build warning

2011-12-01 Thread Stefan Roese 
On Thursday 17 November 2011 20:49:59 Wolfgang Denk wrote:
 Fix:
 In file included from flash.c:45:0:
 ../common/flash.c: In function 'flash_erase':
 ../common/flash.c:399:24: warning: variable 'l_sect' set but not used
 [-Wunused-but-set-variable]
 
 Signed-off-by: Wolfgang Denk w...@denx.de
 Cc: Stefan Roese s...@denx.de

Thanks.

Acked-by: Stefan Roese s...@denx.de

Best regards,
Stefan

--
DENX Software Engineering GmbH,  MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 1/3] board/amcc/common/flash.c: Fix GCC 4.6 build warning

2011-11-17 Thread Wolfgang Denk 
Fix:
In file included from flash.c:45:0:
../common/flash.c: In function 'flash_erase':
../common/flash.c:399:24: warning: variable 'l_sect' set but not used
[-Wunused-but-set-variable]

Signed-off-by: Wolfgang Denk w...@denx.de
Cc: Stefan Roese s...@denx.de
---
total: 0 errors, 0 warnings, 46 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
MULTISTATEMENT_MACRO_USE_DO_WHILE
0001-board-amcc-common-flash.c-Fix-GCC-4.6-build-warning.patch has no obvious 
style problems and is ready for submission.

 board/amcc/common/flash.c |   10 ++
 1 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/board/amcc/common/flash.c b/board/amcc/common/flash.c
index 8f23375..1960fc1 100644
--- a/board/amcc/common/flash.c
+++ b/board/amcc/common/flash.c
@@ -396,7 +396,7 @@ int flash_erase(flash_info_t * info, int s_first, int 
s_last)
 {
volatile CONFIG_SYS_FLASH_WORD_SIZE *addr = (CONFIG_SYS_FLASH_WORD_SIZE 
*) (info-start[0]);
volatile CONFIG_SYS_FLASH_WORD_SIZE *addr2;
-   int flag, prot, sect, l_sect;
+   int flag, prot, sect;
int i;
 
if ((s_first  0) || (s_first  s_last)) {
@@ -427,8 +427,6 @@ int flash_erase(flash_info_t * info, int s_first, int 
s_last)
printf(\n);
}
 
-   l_sect = -1;
-
/* Disable interrupts which might cause a timeout here */
flag = disable_interrupts();
 
@@ -454,7 +452,6 @@ int flash_erase(flash_info_t * info, int s_first, int 
s_last)
addr[CONFIG_SYS_FLASH_ADDR1] = 
(CONFIG_SYS_FLASH_WORD_SIZE) 0x00550055;
addr2[0] = (CONFIG_SYS_FLASH_WORD_SIZE) 
0x00300030; /* sector erase */
}
-   l_sect = sect;
/*
 * Wait for each sector to complete, it's more
 * reliable.  According to AMD Spec, you must
@@ -825,7 +822,7 @@ static int flash_erase_2(flash_info_t * info, int s_first, 
int s_last)
 {
volatile CONFIG_SYS_FLASH_WORD_SIZE *addr = (CONFIG_SYS_FLASH_WORD_SIZE 
*) (info-start[0]);
volatile CONFIG_SYS_FLASH_WORD_SIZE *addr2;
-   int flag, prot, sect, l_sect;
+   int flag, prot, sect;
int i;
 
if ((s_first  0) || (s_first  s_last)) {
@@ -856,8 +853,6 @@ static int flash_erase_2(flash_info_t * info, int s_first, 
int s_last)
printf(\n);
}
 
-   l_sect = -1;
-
/* Disable interrupts which might cause a timeout here */
flag = disable_interrupts();
 
@@ -883,7 +878,6 @@ static int flash_erase_2(flash_info_t * info, int s_first, 
int s_last)
addr[CONFIG_SYS_FLASH_ADDR1] = 
(CONFIG_SYS_FLASH_WORD_SIZE) 0x00550055;
addr2[0] = (CONFIG_SYS_FLASH_WORD_SIZE) 
0x00300030; /* sector erase */
}
-   l_sect = sect;
/*
 * Wait for each sector to complete, it's more
 * reliable.  According to AMD Spec, you must
-- 
1.7.6.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot