Re: [U-Boot] [PATCH 1/3] dm: Return actual bools in dm_fdt_pre_reloc

2017-03-14 Thread Simon Glass 
On 2 March 2017 at 21:52, Simon Glass  wrote:
> On 23 February 2017 at 09:30, Heiko Stuebner  wrote:
>> Documentation says that we're returning true/false, not 1/0 so adapt
>> the function to return actual booleans.
>>
>> Signed-off-by: Heiko Stuebner 
>> ---
>>  drivers/core/util.c | 12 ++--
>>  include/dm/util.h   |  2 +-
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> Acked-by: Simon Glass 

Applied to u-boot-rockchip, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] dm: Return actual bools in dm_fdt_pre_reloc

2017-03-02 Thread Simon Glass 
On 23 February 2017 at 09:30, Heiko Stuebner  wrote:
> Documentation says that we're returning true/false, not 1/0 so adapt
> the function to return actual booleans.
>
> Signed-off-by: Heiko Stuebner 
> ---
>  drivers/core/util.c | 12 ++--
>  include/dm/util.h   |  2 +-
>  2 files changed, 7 insertions(+), 7 deletions(-)

Acked-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 1/3] dm: Return actual bools in dm_fdt_pre_reloc

2017-02-23 Thread Heiko Stuebner 
Documentation says that we're returning true/false, not 1/0 so adapt
the function to return actual booleans.

Signed-off-by: Heiko Stuebner 
---
 drivers/core/util.c | 12 ++--
 include/dm/util.h   |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/core/util.c b/drivers/core/util.c
index bd4de7acd6..5ceac8bbb1 100644
--- a/drivers/core/util.c
+++ b/drivers/core/util.c
@@ -37,17 +37,17 @@ int list_count_items(struct list_head *head)
return count;
 }
 
-int dm_fdt_pre_reloc(const void *blob, int offset)
+bool dm_fdt_pre_reloc(const void *blob, int offset)
 {
if (fdt_getprop(blob, offset, "u-boot,dm-pre-reloc", NULL))
-   return 1;
+   return true;
 
 #ifdef CONFIG_TPL_BUILD
if (fdt_getprop(blob, offset, "u-boot,dm-tpl", NULL))
-   return 1;
+   return true;
 #elif defined(CONFIG_SPL_BUILD)
if (fdt_getprop(blob, offset, "u-boot,dm-spl", NULL))
-   return 1;
+   return true;
 #else
/*
 * In regular builds individual spl and tpl handling both
@@ -55,8 +55,8 @@ int dm_fdt_pre_reloc(const void *blob, int offset)
 */
if (fdt_getprop(blob, offset, "u-boot,dm-spl", NULL) ||
fdt_getprop(blob, offset, "u-boot,dm-tpl", NULL))
-   return 1;
+   return true;
 #endif
 
-   return 0;
+   return false;
 }
diff --git a/include/dm/util.h b/include/dm/util.h
index 32060ab30e..45529ce0e6 100644
--- a/include/dm/util.h
+++ b/include/dm/util.h
@@ -72,6 +72,6 @@ static inline void dm_dump_devres(void)
  *
  * Returns true if node is needed in SPL/TL, false otherwise.
  */
-int dm_fdt_pre_reloc(const void *blob, int offset);
+bool dm_fdt_pre_reloc(const void *blob, int offset);
 
 #endif
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot