Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1243107758-4528-1-git-send-email-plagn...@jcrosoft.com you wrote: at the first run of make we generate the autoconf.mk and autoconf.mk.dep if not already the case and we currently include only to .dep in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Appied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A Chairman was as necessary to a Board planet as the zero was in mathematics, but being a zero had big disadvantages... - Terry Pratchett, _The Dark Side of the Sun_ ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Dear Mike Frysinger, In message 200906231307.32968.vap...@gentoo.org you wrote: while i dont really understand your changelog, i think you're attempting to fix a problem i too have hit with Blackfin systems. but i just hacked around it in my tree (i posted this patch before but Wolfgang opposed it on the basis that no other arch had the problems Blackfin did, but apparently that is no longer true): http://git.denx.de/?p=u-boot/u-boot- blackfin.git;a=commitdiff;h=12ce98a697dde38aefe7131ce9a1b2e0e01640ad So what do you suggest? Apply Jean-Chritophe's patch (maybe you could ACK it then?)? Or use your's instead? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Mandrell: You know what I think? Doctor: Ah, ah that's a catch question. With a brain your size you don't think, right? - Dr. Who ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
On Friday 10 July 2009 18:35:59 Wolfgang Denk wrote: Mike Frysinger wrote: while i dont really understand your changelog, i think you're attempting to fix a problem i too have hit with Blackfin systems. but i just hacked around it in my tree (i posted this patch before but Wolfgang opposed it on the basis that no other arch had the problems Blackfin did, but apparently that is no longer true): http://git.denx.de/?p=u-boot/u-boot- blackfin.git;a=commitdiff;h=12ce98a697dde38aefe7131ce9a1b2e0e01640ad So what do you suggest? Apply Jean-Chritophe's patch (maybe you could ACK it then?)? Or use your's instead? i tested Jean's and while it doesnt work as well as i'd like (i'd prefer it be included before the config.mk), i can work with this in place of the patch i proposed. i'll have to tweak the blackfin_config.mk once this gets merged. so yes, i'd add my signed-off-by to it. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Hi Jean, or someone who understands U-Boot's build system well, Jean-Christophe PLAGNIOL-VILLARD wrote: at the first run of make we generate the autoconf.mk and autoconf.mk.dep if not already the case and we currently include only to .dep in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 81a5cd0..7f3776e 100644 --- a/Makefile +++ b/Makefile @@ -475,6 +475,7 @@ $(obj)include/autoconf.mk: $(obj)include/config.h mv $...@.tmp $@ sinclude $(obj)include/autoconf.mk.dep +sinclude $(obj)include/autoconf.mk # else # !config.mk I'm still thinking how to fix this issue. The problem here is, deferred expansion on PLATFORM_LDFLAGS doesn't work expectedly. In this case, | autoconf.mk | --- | CONFIG_CPU_LITTLE_ENDIAN=y | | mips_config.mk | -- | | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN)) | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | PLATFORM_LDFLAGS += -EL | else | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | PLATFORM_LDFLAGS += -EB | endif doesn't work, but simply doing ... | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN)) | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | else | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | endif | | PLATFORM_LDFLAGS += -EL does work. Then, what needs to be fixed finally? Can't we have PLATFORM_LDFLAGS conditionally configured? or is this a U-Boot's build system issue? Shinya ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
I'm still thinking how to fix this issue. The problem here is, deferred expansion on PLATFORM_LDFLAGS doesn't work expectedly. In this case, | autoconf.mk | --- | CONFIG_CPU_LITTLE_ENDIAN=y | | mips_config.mk | -- | | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN)) | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | PLATFORM_LDFLAGS+= -EL | else | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | PLATFORM_LDFLAGS+= -EB | endif doesn't work, but simply doing ... | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN)) | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | else | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | endif | | PLATFORM_LDFLAGS+= -EL does work. ??? you compile it as big endian to link it as little ??? Then, what needs to be fixed finally? Can't we have PLATFORM_LDFLAGS conditionally configured? or is this a U-Boot's build system issue? it a u-boot build system issues we need to include the autoconf.mk after generate it to use it in the GENERAL Makefile which is the case here for final link Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Jean-Christophe PLAGNIOL-VILLARD wrote: | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN)) | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | else | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... | endif | | PLATFORM_LDFLAGS += -EL does work. ??? you compile it as big endian to link it as little ??? Ah, above was just a sample only intended for LE build. Then, what needs to be fixed finally? Can't we have PLATFORM_LDFLAGS conditionally configured? or is this a U-Boot's build system issue? it a u-boot build system issues we need to include the autoconf.mk after generate it to use it in the GENERAL Makefile which is the case here for final link I know that, but $(obj)include/autoconf.mk will be included by $(TOPDIR)/config.mk. Then what a rationale for including it redundantly by $(TOPDIR/Makefile? I assume that Wolfgang is probably requesting the explanation for that. Autoconf.mk is expected to be generated *before* $(TOPDIR)/config.mk is included, right? If so, do you think your patch is a reasonable enough? Or do we need to consider another approach? Shinya - not a GNU make expert :-( ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
On Saturday 23 May 2009 15:42:36 Jean-Christophe PLAGNIOL-VILLARD wrote: at the first run of make we generate the autoconf.mk and autoconf.mk.dep if not already the case and we currently include only to .dep in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 81a5cd0..7f3776e 100644 --- a/Makefile +++ b/Makefile @@ -475,6 +475,7 @@ $(obj)include/autoconf.mk: $(obj)include/config.h mv $...@.tmp $@ sinclude $(obj)include/autoconf.mk.dep +sinclude $(obj)include/autoconf.mk # else # !config.mk while i dont really understand your changelog, i think you're attempting to fix a problem i too have hit with Blackfin systems. but i just hacked around it in my tree (i posted this patch before but Wolfgang opposed it on the basis that no other arch had the problems Blackfin did, but apparently that is no longer true): http://git.denx.de/?p=u-boot/u-boot- blackfin.git;a=commitdiff;h=12ce98a697dde38aefe7131ce9a1b2e0e01640ad -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
On 13:07 Tue 23 Jun , Mike Frysinger wrote: On Saturday 23 May 2009 15:42:36 Jean-Christophe PLAGNIOL-VILLARD wrote: at the first run of make we generate the autoconf.mk and autoconf.mk.dep if not already the case and we currently include only to .dep in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 81a5cd0..7f3776e 100644 --- a/Makefile +++ b/Makefile @@ -475,6 +475,7 @@ $(obj)include/autoconf.mk: $(obj)include/config.h mv $...@.tmp $@ sinclude $(obj)include/autoconf.mk.dep +sinclude $(obj)include/autoconf.mk # else # !config.mk while i dont really understand your changelog, i think you're attempting to fix a problem i too have hit with Blackfin systems. but i just hacked around it in my tree (i posted this patch before but Wolfgang opposed it on the basis that no other arch had the problems Blackfin did, but apparently that is no longer true): http://git.denx.de/?p=u-boot/u-boot- blackfin.git;a=commitdiff;h=12ce98a697dde38aefe7131ce9a1b2e0e01640ad yes it's the same problem I guess and the solution I propose will for all boards normally Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
On 00:40 Wed 24 Jun , Shinya Kuribayashi wrote: Jean-Christophe PLAGNIOL-VILLARD wrote: | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN)) | PLATFORM_CPPFLAGS+= $(shell $(CC) -dumpmachine |... | else | PLATFORM_CPPFLAGS+= $(shell $(CC) -dumpmachine |... | endif | | PLATFORM_LDFLAGS += -EL does work. ??? you compile it as big endian to link it as little ??? Ah, above was just a sample only intended for LE build. Then, what needs to be fixed finally? Can't we have PLATFORM_LDFLAGS conditionally configured? or is this a U-Boot's build system issue? it a u-boot build system issues we need to include the autoconf.mk after generate it to use it in the GENERAL Makefile which is the case here for final link I know that, but $(obj)include/autoconf.mk will be included by $(TOPDIR)/config.mk. Then what a rationale for including it redundantly by $(TOPDIR/Makefile? I assume that Wolfgang is probably requesting the explanation for that. for sub Makefile yes as you re-include it via including config.mk for the first Makefile no as you generate it in you need to include it just after to be able to use it as you include the config.mk before generate it Autoconf.mk is expected to be generated *before* $(TOPDIR)/config.mk is included, right? no not in the general Makefile Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
On 00:28 Sun 24 May , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1243107758-4528-1-git-send-email-plagn...@jcrosoft.com you wrote: at the first run of make we generate the autoconf.mk and autoconf.mk.dep if not already the case and we currently include only to .dep in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Can you please explain which exact problem you are fixing here? I. e. in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation which we need to do this ifdef CONFIG_CPU_LITTLE_ENDIAN . else endif when doing the LD of u-boot as the CONFIG_CPU_LITTLE_ENDIAN will not be define so we will link it as big-endian can you please show an error case that gets fixed by this change? http://www.mail-archive.com/u-boot@lists.denx.de/msg14517.html Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090524151849.gj26...@game.jcrosoft.org you wrote: On 00:28 Sun 24 May , Wolfgang Denk wrote: Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1243107758-4528-1-git-send-email-plagn...@jcrosoft.com you wrote: at the first run of make we generate the autoconf.mk and autoconf.mk.dep if not already the case and we currently include only to .dep in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Can you please explain which exact problem you are fixing here? I. e. in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Believe me, I can read. Just repeating the same words you already used in the commit message is not helpful at all. Actually it I cannot help but consider this affronting. I did not understand the words there, and I don't understand them here. which we need to do this ifdef CONFIG_CPU_LITTLE_ENDIAN . else endif We need to do this. And am I now supposed to guess where (i. e. in which spoecific file) we might need to do this or why and why it may or may not be working? Come on. This is not an explanation. This is just throwing words without any meaning at me. I'm not willing to discuss on such a base. Please try to explain in a understandable way what you mean (and than use this understandable explanation for the commit message). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A person who is more than casually interested in computers should be well schooled in machine language, since it is a fundamental part of a computer. -- Donald Knuth ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 1243107758-4528-1-git-send-email-plagn...@jcrosoft.com you wrote: at the first run of make we generate the autoconf.mk and autoconf.mk.dep if not already the case and we currently include only to .dep in order to use these autogenerated value we need to include it also evenif it's include in config.mk but it's done before there generation Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Can you please explain which exact problem you are fixing here? I. e. can you please show an error case that gets fixed by this change? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de That Microsoft, the Trabant of the operating system world, may be glancing over the Berlin Wall at the Audis and BMWs and Mercedes. In their own universe Trabants and Ladas were mainstream too... -- Evan Leibovitch ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
