Re: [U-Boot] [PATCH 1/3] mips: ath79: Fix compiler warning on const assignment

2016-01-28 Thread Wills Wang



On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:

The assignment const T var; var = value; is illegal, since var is
constant. Drop the const to fix the compiler warning.

Signed-off-by: Marek Vasut 
Cc: Daniel Schwierzeck 
Cc: Wills Wang 
---
  arch/mips/mach-ath79/reset.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c
index 504b833..e8f5796 100644
--- a/arch/mips/mach-ath79/reset.c
+++ b/arch/mips/mach-ath79/reset.c
@@ -46,7 +46,7 @@ void _machine_restart(void)
  
  u32 get_bootstrap(void)

  {
-   const void __iomem *base;
+   void __iomem *base;
u32 reg = 0;
  
  	base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,

I have dropped "const" in the coming v8.

--
Best Regards
Wills

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/3] mips: ath79: Fix compiler warning on const assignment

2016-01-28 Thread Marek Vasut
On Thursday, January 28, 2016 at 02:23:48 PM, Wills Wang wrote:
> On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
> > The assignment const T var; var = value; is illegal, since var is
> > constant. Drop the const to fix the compiler warning.
> > 
> > Signed-off-by: Marek Vasut 
> > Cc: Daniel Schwierzeck 
> > Cc: Wills Wang 
> > ---
> > 
> >   arch/mips/mach-ath79/reset.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c
> > index 504b833..e8f5796 100644
> > --- a/arch/mips/mach-ath79/reset.c
> > +++ b/arch/mips/mach-ath79/reset.c
> > @@ -46,7 +46,7 @@ void _machine_restart(void)
> > 
> >   u32 get_bootstrap(void)
> >   {
> > 
> > -   const void __iomem *base;
> > +   void __iomem *base;
> > 
> > u32 reg = 0;
> > 
> > base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,
> 
> I have dropped "const" in the coming v8.

Fine

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/3] mips: ath79: Fix compiler warning on const assignment

2016-01-27 Thread Marek Vasut
The assignment const T var; var = value; is illegal, since var is
constant. Drop the const to fix the compiler warning.

Signed-off-by: Marek Vasut 
Cc: Daniel Schwierzeck 
Cc: Wills Wang 
---
 arch/mips/mach-ath79/reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c
index 504b833..e8f5796 100644
--- a/arch/mips/mach-ath79/reset.c
+++ b/arch/mips/mach-ath79/reset.c
@@ -46,7 +46,7 @@ void _machine_restart(void)
 
 u32 get_bootstrap(void)
 {
-   const void __iomem *base;
+   void __iomem *base;
u32 reg = 0;
 
base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,
-- 
2.1.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot