Re: [U-Boot] [PATCH 1/4] ata: mvebu: move mvebu sata driver to drivers/ata directory

2018-05-22 Thread Simon Glass
Hi Ken,

On 17 May 2018 at 19:27,   wrote:
> From: Ken Ma 
>
> Currently mvebu sata driver is in arch/arm/mach_mvebu directory, this
> patch moves it to drivers/ata directory with renaming "sata.c" to
> "ahci_mvebu.c" which is aligned to Linux.
> New ahci driver's kconfig option is added as AHCI_MVEBU which selects
> DM_SCSI.
>
> Signed-off-by: Ken Ma 
> Cc: Simon Glass 
> Cc: Stefan Roese 
> ---
>  arch/arm/mach-mvebu/Makefile |  1 -
>  arch/arm/mach-mvebu/sata.c   | 54 
> 
>  drivers/ata/Kconfig  |  9 
>  drivers/ata/Makefile |  1 +
>  drivers/ata/ahci_mvebu.c | 54 
> 
>  5 files changed, 64 insertions(+), 55 deletions(-)
>  delete mode 100644 arch/arm/mach-mvebu/sata.c
>  create mode 100644 drivers/ata/ahci_mvebu.c
>

How come this doesn't show up as a file move? Are you using patman to
generate your patches?

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 1/4] ata: mvebu: move mvebu sata driver to drivers/ata directory

2018-05-17 Thread make
From: Ken Ma 

Currently mvebu sata driver is in arch/arm/mach_mvebu directory, this
patch moves it to drivers/ata directory with renaming "sata.c" to
"ahci_mvebu.c" which is aligned to Linux.
New ahci driver's kconfig option is added as AHCI_MVEBU which selects
DM_SCSI.

Signed-off-by: Ken Ma 
Cc: Simon Glass 
Cc: Stefan Roese 
---
 arch/arm/mach-mvebu/Makefile |  1 -
 arch/arm/mach-mvebu/sata.c   | 54 
 drivers/ata/Kconfig  |  9 
 drivers/ata/Makefile |  1 +
 drivers/ata/ahci_mvebu.c | 54 
 5 files changed, 64 insertions(+), 55 deletions(-)
 delete mode 100644 arch/arm/mach-mvebu/sata.c
 create mode 100644 drivers/ata/ahci_mvebu.c

diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile
index d4210af..7f0d692 100644
--- a/arch/arm/mach-mvebu/Makefile
+++ b/arch/arm/mach-mvebu/Makefile
@@ -9,7 +9,6 @@ ifdef CONFIG_ARM64
 obj-$(CONFIG_ARMADA_3700) += armada3700/
 obj-$(CONFIG_ARMADA_8K) += armada8k/
 obj-y += arm64-common.o
-obj-y += sata.o
 
 else # CONFIG_ARM64
 
diff --git a/arch/arm/mach-mvebu/sata.c b/arch/arm/mach-mvebu/sata.c
deleted file mode 100644
index 5d8032b..000
--- a/arch/arm/mach-mvebu/sata.c
+++ /dev/null
@@ -1,54 +0,0 @@
-/*
- * Copyright (C) 2016 Stefan Roese 
- *
- * SPDX-License-Identifier:GPL-2.0+
- */
-
-#include 
-#include 
-#include 
-
-DECLARE_GLOBAL_DATA_PTR;
-
-/*
- * Dummy implementation that can be overwritten by a board
- * specific function
- */
-__weak int board_ahci_enable(void)
-{
-   return 0;
-}
-
-#ifdef CONFIG_ARMADA_8K
-/* CP110 has different AHCI port addresses */
-void __iomem *ahci_port_base(void __iomem *base, u32 port)
-{
-   return base + 0x1 + (port * 0x1);
-}
-#endif
-
-static int mvebu_ahci_probe(struct udevice *dev)
-{
-   /*
-* Board specific SATA / AHCI enable code, e.g. enable the
-* AHCI power or deassert reset
-*/
-   board_ahci_enable();
-
-   ahci_init(devfdt_get_addr_ptr(dev));
-
-   return 0;
-}
-
-static const struct udevice_id mvebu_ahci_ids[] = {
-   { .compatible = "marvell,armada-3700-ahci" },
-   { .compatible = "marvell,armada-8k-ahci" },
-   { }
-};
-
-U_BOOT_DRIVER(ahci_mvebu_drv) = {
-   .name   = "ahci_mvebu",
-   .id = UCLASS_AHCI,
-   .of_match   = mvebu_ahci_ids,
-   .probe  = mvebu_ahci_probe,
-};
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 86ec628..9ef4589 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -99,4 +99,13 @@ config SATA_SIL3114
help
  Enable this driver to support the SIL3114 SATA controllers.
 
+config AHCI_MVEBU
+   bool "Marvell EBU AHCI SATA support"
+   depends on ARCH_MVEBU
+   select DM_SCSI
+   help
+ This option enables support for the Marvell EBU SoC's
+ onboard AHCI SATA.
+
+ If unsure, say N.
 endmenu
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index a94c804..0254640 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -19,3 +19,4 @@ obj-$(CONFIG_SATA_MV) += sata_mv.o
 obj-$(CONFIG_SATA_SIL3114) += sata_sil3114.o
 obj-$(CONFIG_SATA_SIL) += sata_sil.o
 obj-$(CONFIG_SANDBOX) += sata_sandbox.o
+obj-$(CONFIG_AHCI_MVEBU) += ahci_mvebu.o
diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c
new file mode 100644
index 000..5c1b293
--- /dev/null
+++ b/drivers/ata/ahci_mvebu.c
@@ -0,0 +1,54 @@
+/*
+ * Copyright (C) 2018 Marvell International Ltd.
+ * Copyright (C) 2016 Stefan Roese 
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ * https://spdx.org/licenses
+ */
+
+#include 
+#include 
+#include 
+
+/*
+ * Dummy implementation that can be overwritten by a board
+ * specific function
+ */
+__weak int board_ahci_enable(void)
+{
+   return 0;
+}
+
+#ifdef CONFIG_ARMADA_8K
+/* CP110 has different AHCI port addresses */
+void __iomem *ahci_port_base(void __iomem *base, u32 port)
+{
+   return base + 0x1 + (port * 0x1);
+}
+#endif
+
+static int mvebu_ahci_probe(struct udevice *dev)
+{
+   /*
+* Board specific SATA / AHCI enable code, e.g. enable the
+* AHCI power or deassert reset
+*/
+   board_ahci_enable();
+
+   ahci_init(devfdt_get_addr_ptr(dev));
+
+   return 0;
+}
+
+static const struct udevice_id mvebu_ahci_ids[] = {
+   { .compatible = "marvell,armada-3700-ahci" },
+   { .compatible = "marvell,armada-8k-ahci" },
+   { }
+};
+
+U_BOOT_DRIVER(ahci_mvebu_drv) = {
+   .name   = "ahci_mvebu",
+   .id = UCLASS_AHCI,
+   .of_match   = mvebu_ahci_ids,
+   .probe  = mvebu_ahci_probe,
+};
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot