Re: [U-Boot] [PATCH 1/6] arch: kona: Initial commit of kona-common architecture code

2014-01-30 Thread Darwin Rambo 


On 14-01-29 02:32 PM, Tom Rini wrote:
> On Mon, Jan 27, 2014 at 10:53:25AM -0800, Darwin Rambo wrote:
> 
>> The Kona architecture is present on a number of Broadcom mobile SoCs
>> including the bcm281xx family of chips.
> [snip]
>> +int __weak clk_sdio_enable(void *base, u32 rate, u32 *actual_ratep)
>> +{
>> +return 0;
>> +}
>> +int __weak clk_bsc_enable(void *base, u32 rate, u32 *actual_ratep)
>> +{
>> +return 0;
>> +}
> 
> Blank lines between functions please.
OK
> 
>> diff --git a/arch/arm/cpu/armv7/kona-common/lowlevel_init.S 
>> b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
>> new file mode 100644
>> index 000..a03afcc
>> --- /dev/null
>> +++ b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
>> @@ -0,0 +1,15 @@
>> +/*
>> +*
>> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
>> +*
>> +* SPDX-License-Identifier:  GPL-2.0+
>> +*
>> +*/
>> +
>> +//#include 
>> +//#include 
>> +//#include 
>> +
>> +.globl lowlevel_init
>> +lowlevel_init:
>> +mov pc, lr
> 
> (a) no commented out include lines
OK
> (b) This is empty, which seems wrong.  I strongly suspect you want to
> make use of arch/arm/cpu/armv7/lowlevel_init.S and have an s_init
> function, ala omap*/tegra/rmobile/etc.
Will check this out. Thanks.
> 
>> diff --git a/arch/arm/cpu/armv7/kona-common/proc.c 
>> b/arch/arm/cpu/armv7/kona-common/proc.c
>> new file mode 100644
>> index 000..92fb39b
>> --- /dev/null
>> +++ b/arch/arm/cpu/armv7/kona-common/proc.c
>> @@ -0,0 +1,20 @@
>> +/*
>> +*
>> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
>> +*
>> +* SPDX-License-Identifier:  GPL-2.0+
>> +*
>> +*/
>> +
>> +#include 
>> +#include 
>> +#include 
>> +#include 
>> +
>> +void do_proc_wfe(int forever)
>> +{
>> +do {
>> +asm volatile ("wfe  @ wait for event\n");
>> +/*printf("wake up from wfe\n"); */
> 
> No commented out printf, thanks.
> 
OK
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/6] arch: kona: Initial commit of kona-common architecture code

2014-01-29 Thread Tom Rini 
On Mon, Jan 27, 2014 at 10:53:25AM -0800, Darwin Rambo wrote:

> The Kona architecture is present on a number of Broadcom mobile SoCs
> including the bcm281xx family of chips.
[snip]
> +int __weak clk_sdio_enable(void *base, u32 rate, u32 *actual_ratep)
> +{
> + return 0;
> +}
> +int __weak clk_bsc_enable(void *base, u32 rate, u32 *actual_ratep)
> +{
> + return 0;
> +}

Blank lines between functions please.

> diff --git a/arch/arm/cpu/armv7/kona-common/lowlevel_init.S 
> b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
> new file mode 100644
> index 000..a03afcc
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
> @@ -0,0 +1,15 @@
> +/*
> +*
> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
> +*
> +* SPDX-License-Identifier:  GPL-2.0+
> +*
> +*/
> +
> +//#include 
> +//#include 
> +//#include 
> +
> +.globl lowlevel_init
> +lowlevel_init:
> + mov pc, lr

(a) no commented out include lines
(b) This is empty, which seems wrong.  I strongly suspect you want to
make use of arch/arm/cpu/armv7/lowlevel_init.S and have an s_init
function, ala omap*/tegra/rmobile/etc.

> diff --git a/arch/arm/cpu/armv7/kona-common/proc.c 
> b/arch/arm/cpu/armv7/kona-common/proc.c
> new file mode 100644
> index 000..92fb39b
> --- /dev/null
> +++ b/arch/arm/cpu/armv7/kona-common/proc.c
> @@ -0,0 +1,20 @@
> +/*
> +*
> +* Copyright 2013 Broadcom Corporation.  All rights reserved.
> +*
> +* SPDX-License-Identifier:  GPL-2.0+
> +*
> +*/
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +void do_proc_wfe(int forever)
> +{
> + do {
> + asm volatile ("wfe  @ wait for event\n");
> + /*printf("wake up from wfe\n"); */

No commented out printf, thanks.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 1/6] arch: kona: Initial commit of kona-common architecture code

2014-01-27 Thread Darwin Rambo 
The Kona architecture is present on a number of Broadcom mobile SoCs
including the bcm281xx family of chips.

Signed-off-by: Darwin Rambo 
Reviewed-by: Steve Rae 
Reviewed-by: Tim Kryger 
---
 arch/arm/cpu/armv7/Makefile|1 +
 arch/arm/cpu/armv7/kona-common/Makefile|   10 
 arch/arm/cpu/armv7/kona-common/clk-stubs.c |   22 +
 arch/arm/cpu/armv7/kona-common/hwinit-common.c |   18 ++
 arch/arm/cpu/armv7/kona-common/lowlevel_init.S |   15 
 arch/arm/cpu/armv7/kona-common/proc.c  |   20 +++
 arch/arm/include/asm/kona-common/clk.h |   31 
 arch/arm/include/asm/kona-common/misc.h|   20 +++
 8 files changed, 137 insertions(+)
 create mode 100644 arch/arm/cpu/armv7/kona-common/Makefile
 create mode 100644 arch/arm/cpu/armv7/kona-common/clk-stubs.c
 create mode 100644 arch/arm/cpu/armv7/kona-common/hwinit-common.c
 create mode 100644 arch/arm/cpu/armv7/kona-common/lowlevel_init.S
 create mode 100644 arch/arm/cpu/armv7/kona-common/proc.c
 create mode 100644 arch/arm/include/asm/kona-common/clk.h
 create mode 100644 arch/arm/include/asm/kona-common/misc.h

diff --git a/arch/arm/cpu/armv7/Makefile b/arch/arm/cpu/armv7/Makefile
index 0467d00..119ebb3 100644
--- a/arch/arm/cpu/armv7/Makefile
+++ b/arch/arm/cpu/armv7/Makefile
@@ -23,6 +23,7 @@ obj-y += nonsec_virt.o
 obj-y  += virt-v7.o
 endif
 
+obj-$(CONFIG_KONA) += kona-common/
 obj-$(CONFIG_OMAP_COMMON) += omap-common/
 obj-$(CONFIG_TEGRA) += tegra-common/
 
diff --git a/arch/arm/cpu/armv7/kona-common/Makefile 
b/arch/arm/cpu/armv7/kona-common/Makefile
new file mode 100644
index 000..9a7c167
--- /dev/null
+++ b/arch/arm/cpu/armv7/kona-common/Makefile
@@ -0,0 +1,10 @@
+#
+# Copyright 2013 Broadcom Corporation. All rights reserved.
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y  += clk-stubs.o
+obj-y  += hwinit-common.o
+obj-y  += proc.o
+obj-y  += lowlevel_init.o
diff --git a/arch/arm/cpu/armv7/kona-common/clk-stubs.c 
b/arch/arm/cpu/armv7/kona-common/clk-stubs.c
new file mode 100644
index 000..dd3ce34
--- /dev/null
+++ b/arch/arm/cpu/armv7/kona-common/clk-stubs.c
@@ -0,0 +1,22 @@
+/*
+*
+* Copyright 2013 Broadcom Corporation.  All rights reserved.
+*
+* SPDX-License-Identifier:  GPL-2.0+
+*
+*/
+
+#include 
+
+/*
+ * These weak functions are available to kona architectures that don't
+ * require clock enables from the driver code.
+ */
+int __weak clk_sdio_enable(void *base, u32 rate, u32 *actual_ratep)
+{
+   return 0;
+}
+int __weak clk_bsc_enable(void *base, u32 rate, u32 *actual_ratep)
+{
+   return 0;
+}
diff --git a/arch/arm/cpu/armv7/kona-common/hwinit-common.c 
b/arch/arm/cpu/armv7/kona-common/hwinit-common.c
new file mode 100644
index 000..5d6b131
--- /dev/null
+++ b/arch/arm/cpu/armv7/kona-common/hwinit-common.c
@@ -0,0 +1,18 @@
+/*
+*
+* Copyright 2013 Broadcom Corporation.  All rights reserved.
+*
+* SPDX-License-Identifier:  GPL-2.0+
+*
+*/
+
+#include 
+#include 
+
+#ifndef CONFIG_SYS_DCACHE_OFF
+void enable_caches(void)
+{
+   /* Enable D-cache. I-cache is already enabled in start.S */
+   dcache_enable();
+}
+#endif
diff --git a/arch/arm/cpu/armv7/kona-common/lowlevel_init.S 
b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
new file mode 100644
index 000..a03afcc
--- /dev/null
+++ b/arch/arm/cpu/armv7/kona-common/lowlevel_init.S
@@ -0,0 +1,15 @@
+/*
+*
+* Copyright 2013 Broadcom Corporation.  All rights reserved.
+*
+* SPDX-License-Identifier:  GPL-2.0+
+*
+*/
+
+//#include 
+//#include 
+//#include 
+
+.globl lowlevel_init
+lowlevel_init:
+   mov pc, lr
diff --git a/arch/arm/cpu/armv7/kona-common/proc.c 
b/arch/arm/cpu/armv7/kona-common/proc.c
new file mode 100644
index 000..92fb39b
--- /dev/null
+++ b/arch/arm/cpu/armv7/kona-common/proc.c
@@ -0,0 +1,20 @@
+/*
+*
+* Copyright 2013 Broadcom Corporation.  All rights reserved.
+*
+* SPDX-License-Identifier:  GPL-2.0+
+*
+*/
+
+#include 
+#include 
+#include 
+#include 
+
+void do_proc_wfe(int forever)
+{
+   do {
+   asm volatile ("wfe  @ wait for event\n");
+   /*printf("wake up from wfe\n"); */
+   } while (forever);
+}
diff --git a/arch/arm/include/asm/kona-common/clk.h 
b/arch/arm/include/asm/kona-common/clk.h
new file mode 100644
index 000..c2