Re: [U-Boot] [PATCH 1/6] usb: ehci-generic: don't probe fail if there is no clk_enable() ops
Hi Kever On 8/28/19 10:23 AM, Kever Yang wrote: > Some clock driver do not have a clk_enable() call back, and we should not > treat this as fail in ehci probe like other modules, eg. clk_enabl_bulk() > do not return fail if ret value is '-ENOSYS' > > Signed-off-by: Kever Yang > --- > > drivers/usb/host/ehci-generic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c > index 0270f3bc95..682a070306 100644 > --- a/drivers/usb/host/ehci-generic.c > +++ b/drivers/usb/host/ehci-generic.c > @@ -96,7 +96,7 @@ static int ehci_usb_probe(struct udevice *dev) > if (err < 0) > break; > err = clk_enable(>clocks[i]); > - if (err) { > + if (err && err != -ENOSYS) { > dev_err(dev, "failed to enable clock %d\n", i); > clk_free(>clocks[i]); > goto clk_err; Reviewed-by: Patrice Chotard Thanks ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 1/6] usb: ehci-generic: don't probe fail if there is no clk_enable() ops
Some clock driver do not have a clk_enable() call back, and we should not treat this as fail in ehci probe like other modules, eg. clk_enabl_bulk() do not return fail if ret value is '-ENOSYS' Signed-off-by: Kever Yang --- drivers/usb/host/ehci-generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-generic.c b/drivers/usb/host/ehci-generic.c index 0270f3bc95..682a070306 100644 --- a/drivers/usb/host/ehci-generic.c +++ b/drivers/usb/host/ehci-generic.c @@ -96,7 +96,7 @@ static int ehci_usb_probe(struct udevice *dev) if (err < 0) break; err = clk_enable(>clocks[i]); - if (err) { + if (err && err != -ENOSYS) { dev_err(dev, "failed to enable clock %d\n", i); clk_free(>clocks[i]); goto clk_err; -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot