Re: [U-Boot] [PATCH 1/7] driver: net: fsl-mc: Add version check for MC objects

[york sun]

On 12/24/2015 02:02 AM, Prabhakar Kushwaha wrote:
> Check and compare version of management  complex's object with the version
> supported by Freescale ldpaa2 ethernet driver.
> 
> Signed-off-by: Prabhakar Kushwaha 
> ---
>  drivers/net/fsl-mc/mc.c   | 51 
> ++-
>  drivers/net/ldpaa_eth/ldpaa_eth.c | 28 +
>  2 files changed, 78 insertions(+), 1 deletion(-)

Slightly reformat commit message.
Applied to u-boot-fsl-qoriq master. Awaiting upstream.

Thanks.

York

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/7] driver: net: fsl-mc: Add version check for MC objects

[york sun]

On 12/24/2015 02:02 AM, Prabhakar Kushwaha wrote:
> Check and compare version of management  complex's object with the version
> supported by Freescale ldpaa2 ethernet driver.
> 
> Signed-off-by: Prabhakar Kushwaha 
> ---
>  drivers/net/fsl-mc/mc.c   | 51 
> ++-
>  drivers/net/ldpaa_eth/ldpaa_eth.c | 28 +
>  2 files changed, 78 insertions(+), 1 deletion(-)
> 

The driver is not backward compatible, is it? Looks like every time the firmware
upgrades, the driver changes.

York


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/7] driver: net: fsl-mc: Add version check for MC objects

[Prabhakar Kushwaha]

> -Original Message-
> From: york sun [mailto:york@nxp.com]
> Sent: Monday, January 25, 2016 10:49 PM
> To: Prabhakar Kushwaha ; u-boot@lists.denx.de
> Cc: Yusong Sun 
> Subject: Re: [PATCH 1/7] driver: net: fsl-mc: Add version check for MC
> objects
> 
> On 12/24/2015 02:02 AM, Prabhakar Kushwaha wrote:
> > Check and compare version of management  complex's object with the
> > version supported by Freescale ldpaa2 ethernet driver.
> >
> > Signed-off-by: Prabhakar Kushwaha 
> > ---
> >  drivers/net/fsl-mc/mc.c   | 51
> ++-
> >  drivers/net/ldpaa_eth/ldpaa_eth.c | 28 +
> >  2 files changed, 78 insertions(+), 1 deletion(-)
> >
> 
> The driver is not backward compatible, is it? Looks like every time the
> firmware upgrades, the driver changes.
> 

Yes, driver is not backward compatible. 
Each Firmware  new version changes lots of things including APIs. It is still 
getting stable. 

--prabhakar

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 1/7] driver: net: fsl-mc: Add version check for MC objects

[Prabhakar Kushwaha]

Check and compare version of management  complex's object with the version
supported by Freescale ldpaa2 ethernet driver.

Signed-off-by: Prabhakar Kushwaha 
---
 drivers/net/fsl-mc/mc.c   | 51 ++-
 drivers/net/ldpaa_eth/ldpaa_eth.c | 28 +
 2 files changed, 78 insertions(+), 1 deletion(-)

diff --git a/drivers/net/fsl-mc/mc.c b/drivers/net/fsl-mc/mc.c
index bac4610..b773e35 100644
--- a/drivers/net/fsl-mc/mc.c
+++ b/drivers/net/fsl-mc/mc.c
@@ -655,6 +655,26 @@ int fsl_mc_ldpaa_init(bd_t *bis)
return 0;
 }
 
+static int dprc_version_check(struct fsl_mc_io *mc_io, uint16_t handle)
+{
+   struct dprc_attributes attr;
+   int error;
+
+   memset(, 0, sizeof(struct dprc_attributes));
+   error = dprc_get_attributes(mc_io, MC_CMD_NO_FLAGS, handle, );
+   if (error == 0) {
+   if ((attr.version.major != DPRC_VER_MAJOR) ||
+   (attr.version.minor != DPRC_VER_MINOR)) {
+   printf("DPRC version mismatch found %u.%u,",
+  attr.version.major,
+  attr.version.minor);
+   printf("supported version is %u.%u\n",
+  DPRC_VER_MAJOR, DPRC_VER_MINOR);
+   }
+   }
+   return error;
+}
+
 static int dpio_init(void)
 {
struct qbman_swp_desc p_des;
@@ -688,11 +708,18 @@ static int dpio_init(void)
goto err_get_attr;
}
 
+   if ((attr.version.major != DPIO_VER_MAJOR) ||
+   (attr.version.minor != DPIO_VER_MINOR)) {
+   printf("DPIO version mismatch found %u.%u,",
+  attr.version.major, attr.version.minor);
+   printf("supported version is %u.%u\n",
+  DPIO_VER_MAJOR, DPIO_VER_MINOR);
+   }
+
dflt_dpio->dpio_id = attr.id;
 #ifdef DEBUG
printf("Init: DPIO id=0x%d\n", dflt_dpio->dpio_id);
 #endif
-
err = dpio_enable(dflt_mc_io, MC_CMD_NO_FLAGS, dflt_dpio->dpio_handle);
if (err < 0) {
printf("dpio_enable() failed %d\n", err);
@@ -784,6 +811,12 @@ static int dprc_init(void)
goto err_root_open;
}
 
+   err = dprc_version_check(root_mc_io, root_dprc_handle);
+   if (err < 0) {
+   printf("dprc_version_check() failed: %d\n", err);
+   goto err_root_open;
+   }
+
cfg.options = DPRC_CFG_OPT_TOPOLOGY_CHANGES_ALLOWED |
  DPRC_CFG_OPT_OBJ_CREATE_ALLOWED |
  DPRC_CFG_OPT_ALLOC_ALLOWED;
@@ -906,6 +939,14 @@ static int dpbp_init(void)
goto err_get_attr;
}
 
+   if ((dpbp_attr.version.major != DPBP_VER_MAJOR) ||
+   (dpbp_attr.version.minor != DPBP_VER_MINOR)) {
+   printf("DPBP version mismatch found %u.%u,",
+  dpbp_attr.version.major, dpbp_attr.version.minor);
+   printf("supported version is %u.%u\n",
+  DPBP_VER_MAJOR, DPBP_VER_MINOR);
+   }
+
dflt_dpbp->dpbp_attr.id = dpbp_attr.id;
 #ifdef DEBUG
printf("Init: DPBP id=0x%d\n", dflt_dpbp->dpbp_attr.id);
@@ -994,6 +1035,14 @@ static int dpni_init(void)
goto err_get_attr;
}
 
+   if ((dpni_attr.version.major != DPNI_VER_MAJOR) ||
+   (dpni_attr.version.minor != DPNI_VER_MINOR)) {
+   printf("DPNI version mismatch found %u.%u,",
+  dpni_attr.version.major, dpni_attr.version.minor);
+   printf("supported version is %u.%u\n",
+  DPNI_VER_MAJOR, DPNI_VER_MINOR);
+   }
+
dflt_dpni->dpni_id = dpni_attr.id;
 #ifdef DEBUG
printf("Init: DPNI id=0x%d\n", dflt_dpni->dpni_id);
diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c 
b/drivers/net/ldpaa_eth/ldpaa_eth.c
index 69530b1..47a3a23 100644
--- a/drivers/net/ldpaa_eth/ldpaa_eth.c
+++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
@@ -599,6 +599,29 @@ static void ldpaa_dpbp_free(void)
dpbp_close(dflt_mc_io, MC_CMD_NO_FLAGS, dflt_dpbp->dpbp_handle);
 }
 
+static int ldpaa_dpmac_version_check(struct fsl_mc_io *mc_io,
+struct ldpaa_eth_priv *priv)
+{
+   struct dpmac_attr attr;
+   int error;
+
+   memset(, 0, sizeof(struct dpmac_attr));
+   error = dpmac_get_attributes(mc_io, MC_CMD_NO_FLAGS,
+priv->dpmac_handle,
+);
+   if (error == 0) {
+   if ((attr.version.major != DPMAC_VER_MAJOR) ||
+   (attr.version.minor != DPMAC_VER_MINOR)) {
+   printf("DPMAC version mismatch found %u.%u,",
+  attr.version.major, attr.version.minor);
+   printf("supported version is %u.%u\n",
+  DPMAC_VER_MAJOR, DPMAC_VER_MINOR);
+   }
+   }
+