Re: [U-Boot] [PATCH 1/9] rtc: mc146818: Add a comment to the #endif

2015-10-21 Thread Simon Glass
On 18 October 2015 at 20:22, Bin Meng  wrote:
> On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass  wrote:
>> Add a comment to make it clear to which block the #endif relates.
>>
>> Signed-off-by: Simon Glass 
>> ---
>>
>>  drivers/rtc/mc146818.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/mc146818.c b/drivers/rtc/mc146818.c
>> index 363ade3..9e94a80 100644
>> --- a/drivers/rtc/mc146818.c
>> +++ b/drivers/rtc/mc146818.c
>> @@ -192,7 +192,7 @@ static void mc146818_init(void)
>> /* Clear any pending interrupts */
>> mc146818_read8(RTC_CONFIG_C);
>>  }
>> -#endif
>> +#endif /* CONFIG_CMD_DATE */
>>
>>  #ifdef CONFIG_DM_RTC
>>
>> --
>
> Reviewed-by: Bin Meng 

Applied to u-boot-x86.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 1/9] rtc: mc146818: Add a comment to the #endif

2015-10-18 Thread Simon Glass
Add a comment to make it clear to which block the #endif relates.

Signed-off-by: Simon Glass 
---

 drivers/rtc/mc146818.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/mc146818.c b/drivers/rtc/mc146818.c
index 363ade3..9e94a80 100644
--- a/drivers/rtc/mc146818.c
+++ b/drivers/rtc/mc146818.c
@@ -192,7 +192,7 @@ static void mc146818_init(void)
/* Clear any pending interrupts */
mc146818_read8(RTC_CONFIG_C);
 }
-#endif
+#endif /* CONFIG_CMD_DATE */
 
 #ifdef CONFIG_DM_RTC
 
-- 
2.6.0.rc2.230.g3dd15c0

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 1/9] rtc: mc146818: Add a comment to the #endif

2015-10-18 Thread Bin Meng
On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass  wrote:
> Add a comment to make it clear to which block the #endif relates.
>
> Signed-off-by: Simon Glass 
> ---
>
>  drivers/rtc/mc146818.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/mc146818.c b/drivers/rtc/mc146818.c
> index 363ade3..9e94a80 100644
> --- a/drivers/rtc/mc146818.c
> +++ b/drivers/rtc/mc146818.c
> @@ -192,7 +192,7 @@ static void mc146818_init(void)
> /* Clear any pending interrupts */
> mc146818_read8(RTC_CONFIG_C);
>  }
> -#endif
> +#endif /* CONFIG_CMD_DATE */
>
>  #ifdef CONFIG_DM_RTC
>
> --

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot