Re: [U-Boot] [PATCH 10/10][v4] driver: net: ldpaa: Add debug information

2015-11-30 Thread York Sun


On 11/03/2015 10:56 PM, Prabhakar Kushwaha wrote:
> Add following debug information in the driver
>  - Get various DPNI counter values
>  - Get link status of DPNI objects
>  - Get information of both ends of connection (DPMAC - DPNI)
> 
> Signed-off-by: Prabhakar Kushwaha 
> ---
>  Changes for v2: Use child container for DPMAC-DPNI connection
>  Changes for v3: Sending as it is
>  Changes for v4: Sending as it is
> 
> 
>  drivers/net/ldpaa_eth/ldpaa_eth.c | 123 
> ++
>  1 file changed, 123 insertions(+)
> 

Applied to fsl-qoriq master. Thanks.

York
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 10/10][v4] driver: net: ldpaa: Add debug information

2015-11-03 Thread Prabhakar Kushwaha
Add following debug information in the driver
 - Get various DPNI counter values
 - Get link status of DPNI objects
 - Get information of both ends of connection (DPMAC - DPNI)

Signed-off-by: Prabhakar Kushwaha 
---
 Changes for v2: Use child container for DPMAC-DPNI connection
 Changes for v3: Sending as it is
 Changes for v4: Sending as it is


 drivers/net/ldpaa_eth/ldpaa_eth.c | 123 ++
 1 file changed, 123 insertions(+)

diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.c 
b/drivers/net/ldpaa_eth/ldpaa_eth.c
index 3d4c0f5..5ddc9fe 100644
--- a/drivers/net/ldpaa_eth/ldpaa_eth.c
+++ b/drivers/net/ldpaa_eth/ldpaa_eth.c
@@ -24,6 +24,84 @@ static int init_phy(struct eth_device *dev)
return 0;
 }
 
+#ifdef DEBUG
+static void ldpaa_eth_get_dpni_counter(void)
+{
+   int err = 0;
+   u64 value;
+
+   err = dpni_get_counter(dflt_mc_io, MC_CMD_NO_FLAGS,
+dflt_dpni->dpni_handle,
+DPNI_CNT_ING_FRAME,
+&value);
+   if (err < 0) {
+   printf("dpni_get_counter: DPNI_CNT_ING_FRAME failed\n");
+   return;
+   }
+   printf("DPNI_CNT_ING_FRAME=%lld\n", value);
+
+   err = dpni_get_counter(dflt_mc_io, MC_CMD_NO_FLAGS,
+dflt_dpni->dpni_handle,
+DPNI_CNT_ING_BYTE,
+&value);
+   if (err < 0) {
+   printf("dpni_get_counter: DPNI_CNT_ING_BYTE failed\n");
+   return;
+   }
+   printf("DPNI_CNT_ING_BYTE=%lld\n", value);
+
+   err = dpni_get_counter(dflt_mc_io, MC_CMD_NO_FLAGS,
+dflt_dpni->dpni_handle,
+DPNI_CNT_ING_FRAME_DROP ,
+&value);
+   if (err < 0) {
+   printf("dpni_get_counter: DPNI_CNT_ING_FRAME_DROP failed\n");
+   return;
+   }
+   printf("DPNI_CNT_ING_FRAME_DROP =%lld\n", value);
+
+   err = dpni_get_counter(dflt_mc_io, MC_CMD_NO_FLAGS,
+dflt_dpni->dpni_handle,
+DPNI_CNT_ING_FRAME_DISCARD,
+&value);
+   if (err < 0) {
+   printf("dpni_get_counter: DPNI_CNT_ING_FRAME_DISCARD failed\n");
+   return;
+   }
+   printf("DPNI_CNT_ING_FRAME_DISCARD=%lld\n", value);
+
+   err = dpni_get_counter(dflt_mc_io, MC_CMD_NO_FLAGS,
+dflt_dpni->dpni_handle,
+DPNI_CNT_EGR_FRAME,
+&value);
+   if (err < 0) {
+   printf("dpni_get_counter: DPNI_CNT_EGR_FRAME failed\n");
+   return;
+   }
+   printf("DPNI_CNT_EGR_FRAME=%lld\n", value);
+
+   err = dpni_get_counter(dflt_mc_io, MC_CMD_NO_FLAGS,
+dflt_dpni->dpni_handle,
+DPNI_CNT_EGR_BYTE ,
+&value);
+   if (err < 0) {
+   printf("dpni_get_counter: DPNI_CNT_EGR_BYTE failed\n");
+   return;
+   }
+   printf("DPNI_CNT_EGR_BYTE =%lld\n", value);
+
+   err = dpni_get_counter(dflt_mc_io, MC_CMD_NO_FLAGS,
+dflt_dpni->dpni_handle,
+DPNI_CNT_EGR_FRAME_DISCARD ,
+&value);
+   if (err < 0) {
+   printf("dpni_get_counter: DPNI_CNT_EGR_FRAME_DISCARD failed\n");
+   return;
+   }
+   printf("DPNI_CNT_EGR_FRAME_DISCARD =%lld\n", value);
+}
+#endif
+
 static void ldpaa_eth_rx(struct ldpaa_eth_priv *priv,
 const struct dpaa_fd *fd)
 {
@@ -222,6 +300,9 @@ static int ldpaa_eth_open(struct eth_device *net_dev, bd_t 
*bd)
struct ldpaa_eth_priv *priv = (struct ldpaa_eth_priv *)net_dev->priv;
struct dpni_queue_attr rx_queue_attr;
struct dpmac_link_state dpmac_link_state = { 0 };
+#ifdef DEBUG
+   struct dpni_link_state link_state;
+#endif
int err;
 
if (net_dev->state == ETH_STATE_ACTIVE)
@@ -295,6 +376,20 @@ static int ldpaa_eth_open(struct eth_device *net_dev, bd_t 
*bd)
printf("dpmac_set_link_state() failed\n");
return err;
}
+
+#ifdef DEBUG
+   err = dpni_get_link_state(dflt_mc_io, MC_CMD_NO_FLAGS,
+ dflt_dpni->dpni_handle, &link_state);
+   if (err < 0) {
+   printf("dpni_get_link_state() failed\n");
+   return err;
+   }
+
+   printf("link status: %d - ", link_state.up);
+   link_state.up == 0 ? printf("down\n") :
+   link_state.up == 1 ? printf("up\n") : printf("error state\n");
+#endif
+
/* TODO: support multiple Rx flows */
err = dpni_get_rx_flow(dflt_mc_io, MC_CMD_NO_FLAGS,
   dflt_dpni->dpni_handle, 0, 0, &rx_queue_attr);
@@ -339,6 +434,10 @@ static void ldpaa_eth_stop(struct eth_device *net_dev)
(net_dev->state == ETH_STATE_INIT))
return;
 
+#ifdef DEBUG
+   ldpaa_eth_get_dpni_counter();
+#endif
+
err =