Re: [U-Boot] [PATCH 10/12] ARM: rmobile: Remove SH SDHI probing from ULCB board

[Nobuhiro Iwamatsu]

Hi,

2017-08-21 0:13 GMT+09:00 Marek Vasut :
> Drop the SH SDHI bit from the board since SD now probes from DT instead.
>
> Signed-off-by: Marek Vasut 
> Cc: Nobuhiro Iwamatsu 
> ---
>  board/renesas/ulcb/ulcb.c | 12 +---
>  1 file changed, 1 insertion(+), 11 deletions(-)

Applied, thanks.

Best regards,
  Nobuhiro
>
> diff --git a/board/renesas/ulcb/ulcb.c b/board/renesas/ulcb/ulcb.c
> index 6b080311d0..068cbdea03 100644
> --- a/board/renesas/ulcb/ulcb.c
> +++ b/board/renesas/ulcb/ulcb.c
> @@ -143,8 +143,6 @@ int board_init(void)
>  #ifdef CONFIG_SH_SDHI
>  int board_mmc_init(bd_t *bis)
>  {
> -   int ret = -ENODEV;
> -
> /* SDHI0 */
> gpio_request(GPIO_GFN_SD0_DAT0, NULL);
> gpio_request(GPIO_GFN_SD0_DAT1, NULL);
> @@ -160,11 +158,6 @@ int board_mmc_init(bd_t *bis)
> gpio_direction_output(GPIO_GP_5_2, 1);  /* power on */
> gpio_direction_output(GPIO_GP_5_1, 1);  /* 1: 3.3V, 0: 1.8V */
>
> -   ret = sh_sdhi_init(CONFIG_SYS_SH_SDHI0_BASE, 0,
> -  SH_SDHI_QUIRK_64BIT_BUF);
> -   if (ret)
> -   return ret;
> -
> /* SDHI1/SDHI2 eMMC */
> gpio_request(GPIO_GFN_SD1_DAT0, NULL);
> gpio_request(GPIO_GFN_SD1_DAT1, NULL);
> @@ -187,10 +180,7 @@ int board_mmc_init(bd_t *bis)
> gpio_direction_output(GPIO_GP_5_3, 0);  /* 1: 3.3V, 0: 1.8V */
> gpio_direction_output(GPIO_GP_5_9, 0);  /* 1: 3.3V, 0: 1.8V */
>
> -   ret = sh_sdhi_init(CONFIG_SYS_SH_SDHI2_BASE, 1,
> -  SH_SDHI_QUIRK_64BIT_BUF);
> -
> -   return ret;
> +   return 0;
>  }
>  #endif
>
> --
> 2.11.0
>



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 10/12] ARM: rmobile: Remove SH SDHI probing from ULCB board

[Marek Vasut]

Drop the SH SDHI bit from the board since SD now probes from DT instead.

Signed-off-by: Marek Vasut 
Cc: Nobuhiro Iwamatsu 
---
 board/renesas/ulcb/ulcb.c | 12 +---
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/board/renesas/ulcb/ulcb.c b/board/renesas/ulcb/ulcb.c
index 6b080311d0..068cbdea03 100644
--- a/board/renesas/ulcb/ulcb.c
+++ b/board/renesas/ulcb/ulcb.c
@@ -143,8 +143,6 @@ int board_init(void)
 #ifdef CONFIG_SH_SDHI
 int board_mmc_init(bd_t *bis)
 {
-   int ret = -ENODEV;
-
/* SDHI0 */
gpio_request(GPIO_GFN_SD0_DAT0, NULL);
gpio_request(GPIO_GFN_SD0_DAT1, NULL);
@@ -160,11 +158,6 @@ int board_mmc_init(bd_t *bis)
gpio_direction_output(GPIO_GP_5_2, 1);  /* power on */
gpio_direction_output(GPIO_GP_5_1, 1);  /* 1: 3.3V, 0: 1.8V */
 
-   ret = sh_sdhi_init(CONFIG_SYS_SH_SDHI0_BASE, 0,
-  SH_SDHI_QUIRK_64BIT_BUF);
-   if (ret)
-   return ret;
-
/* SDHI1/SDHI2 eMMC */
gpio_request(GPIO_GFN_SD1_DAT0, NULL);
gpio_request(GPIO_GFN_SD1_DAT1, NULL);
@@ -187,10 +180,7 @@ int board_mmc_init(bd_t *bis)
gpio_direction_output(GPIO_GP_5_3, 0);  /* 1: 3.3V, 0: 1.8V */
gpio_direction_output(GPIO_GP_5_9, 0);  /* 1: 3.3V, 0: 1.8V */
 
-   ret = sh_sdhi_init(CONFIG_SYS_SH_SDHI2_BASE, 1,
-  SH_SDHI_QUIRK_64BIT_BUF);
-
-   return ret;
+   return 0;
 }
 #endif
 
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot