Re: [U-Boot] [PATCH 12/18] rockchip: sdhci: Convert to livetree

[Simon Glass]

On 16 August 2017 at 11:32, Philipp Tomsich
 wrote:
> Update the Rockchip SDHCI wrapper to support a live device tree.
>
> Signed-off-by: Philipp Tomsich 
> ---
>
>  drivers/mmc/rockchip_sdhci.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Simon Glass 

Please see below.

>
> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
> index f31d329..8d62bf9 100644
> --- a/drivers/mmc/rockchip_sdhci.c
> +++ b/drivers/mmc/rockchip_sdhci.c
> @@ -9,7 +9,6 @@
>  #include 
>  #include 
>  #include 
> -#include 
>  #include 
>  #include 
>  #include 
> @@ -82,7 +81,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice 
> *dev)
> struct sdhci_host *host = dev_get_priv(dev);
>
> host->name = dev->name;
> -   host->ioaddr = devfdt_get_addr_ptr(dev);
> +   host->ioaddr = (void *)dev_read_addr(dev);

Can you please add a dev_read_addr_ptr() ?

>  #endif
>
> return 0;
> --
> 2.1.4
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 12/18] rockchip: sdhci: Convert to livetree

[Philipp Tomsich]

Update the Rockchip SDHCI wrapper to support a live device tree.

Signed-off-by: Philipp Tomsich 
---

 drivers/mmc/rockchip_sdhci.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
index f31d329..8d62bf9 100644
--- a/drivers/mmc/rockchip_sdhci.c
+++ b/drivers/mmc/rockchip_sdhci.c
@@ -9,7 +9,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -82,7 +81,7 @@ static int arasan_sdhci_ofdata_to_platdata(struct udevice 
*dev)
struct sdhci_host *host = dev_get_priv(dev);
 
host->name = dev->name;
-   host->ioaddr = devfdt_get_addr_ptr(dev);
+   host->ioaddr = (void *)dev_read_addr(dev);
 #endif
 
return 0;
-- 
2.1.4

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot