Re: [U-Boot] [PATCH 13/13] Blackfin: force all boards to HZ of 1000
On Thursday 02 April 2009 07:28:21 Jean-Christophe PLAGNIOL-VILLARD wrote: > On 07:21 Thu 02 Apr , Mike Frysinger wrote: > > On Thursday 02 April 2009 06:57:03 Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 06:45 Thu 02 Apr , Mike Frysinger wrote: > > > > Since the Blackfin timer code requires HZ to be 1000, barf on any > > > > board that tries to use a different value. > > > > > > > > Signed-off-by: Mike Frysinger > > > > --- > > > > include/asm-blackfin/blackfin-config-post.h |8 ++-- > > > > 1 files changed, 6 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/asm-blackfin/blackfin-config-post.h > > > > b/include/asm-blackfin/blackfin-config-post.h index fea4737..623fdc7 > > > > 100644 > > > > --- a/include/asm-blackfin/blackfin-config-post.h > > > > +++ b/include/asm-blackfin/blackfin-config-post.h > > > > @@ -135,9 +135,13 @@ > > > > #ifndef CONFIG_SYS_MAXARGS > > > > # define CONFIG_SYS_MAXARGS 16 > > > > #endif > > > > -#ifndef CONFIG_SYS_HZ > > > > -# define CONFIG_SYS_HZ 1000 > > > > +#if defined(CONFIG_SYS_HZ) > > > > +# if (CONFIG_SYS_HZ != 1000) > > > > +# warning "CONFIG_SYS_HZ must always be 1000" > > > > +# endif > > > > +# undef CONFIG_SYS_HZ > > > > > > does this is really necessary? > > > > to prevent insane people today, sure. it'll probably fall out when i > > start my "cleanup ticks and timer" work for the next merge though ... > > > > > > #endif > > > > +#define CONFIG_SYS_HZ 1000 > > > > > > why not asm-blackfin/config.h? > > > > there is no such file ? > > There is now it was introduced by Kumar. news to me. yes, i can probably wholesale convert the current blackfin- config-post.h to config.h. too late for this merge window though :). -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 13/13] Blackfin: force all boards to HZ of 1000
On 07:21 Thu 02 Apr , Mike Frysinger wrote: > On Thursday 02 April 2009 06:57:03 Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 06:45 Thu 02 Apr , Mike Frysinger wrote: > > > Since the Blackfin timer code requires HZ to be 1000, barf on any board > > > that tries to use a different value. > > > > > > Signed-off-by: Mike Frysinger > > > --- > > > include/asm-blackfin/blackfin-config-post.h |8 ++-- > > > 1 files changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/asm-blackfin/blackfin-config-post.h > > > b/include/asm-blackfin/blackfin-config-post.h index fea4737..623fdc7 > > > 100644 > > > --- a/include/asm-blackfin/blackfin-config-post.h > > > +++ b/include/asm-blackfin/blackfin-config-post.h > > > @@ -135,9 +135,13 @@ > > > #ifndef CONFIG_SYS_MAXARGS > > > # define CONFIG_SYS_MAXARGS 16 > > > #endif > > > -#ifndef CONFIG_SYS_HZ > > > -# define CONFIG_SYS_HZ 1000 > > > +#if defined(CONFIG_SYS_HZ) > > > +# if (CONFIG_SYS_HZ != 1000) > > > +# warning "CONFIG_SYS_HZ must always be 1000" > > > +# endif > > > +# undef CONFIG_SYS_HZ > > > > does this is really necessary? > > to prevent insane people today, sure. it'll probably fall out when i start > my > "cleanup ticks and timer" work for the next merge though ... > > > > #endif > > > +#define CONFIG_SYS_HZ 1000 > > > > why not asm-blackfin/config.h? > > there is no such file ? There is now it was introduced by Kumar. Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 13/13] Blackfin: force all boards to HZ of 1000
On Thursday 02 April 2009 06:57:03 Jean-Christophe PLAGNIOL-VILLARD wrote: > On 06:45 Thu 02 Apr , Mike Frysinger wrote: > > Since the Blackfin timer code requires HZ to be 1000, barf on any board > > that tries to use a different value. > > > > Signed-off-by: Mike Frysinger > > --- > > include/asm-blackfin/blackfin-config-post.h |8 ++-- > > 1 files changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/include/asm-blackfin/blackfin-config-post.h > > b/include/asm-blackfin/blackfin-config-post.h index fea4737..623fdc7 > > 100644 > > --- a/include/asm-blackfin/blackfin-config-post.h > > +++ b/include/asm-blackfin/blackfin-config-post.h > > @@ -135,9 +135,13 @@ > > #ifndef CONFIG_SYS_MAXARGS > > # define CONFIG_SYS_MAXARGS 16 > > #endif > > -#ifndef CONFIG_SYS_HZ > > -# define CONFIG_SYS_HZ 1000 > > +#if defined(CONFIG_SYS_HZ) > > +# if (CONFIG_SYS_HZ != 1000) > > +# warning "CONFIG_SYS_HZ must always be 1000" > > +# endif > > +# undef CONFIG_SYS_HZ > > does this is really necessary? to prevent insane people today, sure. it'll probably fall out when i start my "cleanup ticks and timer" work for the next merge though ... > > #endif > > +#define CONFIG_SYS_HZ 1000 > > why not asm-blackfin/config.h? there is no such file ? there are pre/post config files for Blackfin ports which contain Blackfin-specific settings. for vendor-specific common settings, there are files in the normal include/config/ tree. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 13/13] Blackfin: force all boards to HZ of 1000
On 06:45 Thu 02 Apr , Mike Frysinger wrote: > Since the Blackfin timer code requires HZ to be 1000, barf on any board > that tries to use a different value. > > Signed-off-by: Mike Frysinger > --- > include/asm-blackfin/blackfin-config-post.h |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/asm-blackfin/blackfin-config-post.h > b/include/asm-blackfin/blackfin-config-post.h > index fea4737..623fdc7 100644 > --- a/include/asm-blackfin/blackfin-config-post.h > +++ b/include/asm-blackfin/blackfin-config-post.h > @@ -135,9 +135,13 @@ > #ifndef CONFIG_SYS_MAXARGS > # define CONFIG_SYS_MAXARGS 16 > #endif > -#ifndef CONFIG_SYS_HZ > -# define CONFIG_SYS_HZ 1000 > +#if defined(CONFIG_SYS_HZ) > +# if (CONFIG_SYS_HZ != 1000) > +# warning "CONFIG_SYS_HZ must always be 1000" > +# endif > +# undef CONFIG_SYS_HZ does this is really necessary? > #endif > +#define CONFIG_SYS_HZ 1000 why not asm-blackfin/config.h? Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 13/13] Blackfin: force all boards to HZ of 1000
Since the Blackfin timer code requires HZ to be 1000, barf on any board
that tries to use a different value.
Signed-off-by: Mike Frysinger
---
include/asm-blackfin/blackfin-config-post.h |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/include/asm-blackfin/blackfin-config-post.h
b/include/asm-blackfin/blackfin-config-post.h
index fea4737..623fdc7 100644
--- a/include/asm-blackfin/blackfin-config-post.h
+++ b/include/asm-blackfin/blackfin-config-post.h
@@ -135,9 +135,13 @@
#ifndef CONFIG_SYS_MAXARGS
# define CONFIG_SYS_MAXARGS 16
#endif
-#ifndef CONFIG_SYS_HZ
-# define CONFIG_SYS_HZ 1000
+#if defined(CONFIG_SYS_HZ)
+# if (CONFIG_SYS_HZ != 1000)
+# warning "CONFIG_SYS_HZ must always be 1000"
+# endif
+# undef CONFIG_SYS_HZ
#endif
+#define CONFIG_SYS_HZ 1000
#ifndef CONFIG_SYS_BAUDRATE_TABLE
# define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
#endif
--
1.6.2
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
