Re: [U-Boot] [PATCH 15/25] power domain: Introduce TI System Control Interface (TI SCI) power domain driver

2018-08-24 Thread Tom Rini
On Tue, Aug 21, 2018 at 08:01:53PM +0530, Lokesh Vutla wrote:

> From: Andreas Dannenberg 
> 
> Some TI Keystone 2 and K3 family of SoCs contain a system controller
> (like the Power Management Micro Controller (PMMC) on 66AK2G SoCs and
> the Device Management and Security Controller on AM65x SoCs) that manage
> the low-level device control (like clocks, resets etc) for the various
> hardware modules present on the SoC. These device control operations are
> provided to the host processor OS through a communication protocol
> called the TI System Control Interface (TI SCI) protocol.
> 
> This patch adds a power domain driver that communicates to the system
> controller over the TI SCI protocol for performing power management of
> various devices present on the SoC. Various power domain functionalities
> are achieved by the means of different TI SCI device operations provided
> by the TI SCI framework.
> 
> This code is loosely based on the drivers/soc/ti/ti_sci_pm_domains.c
> driver of the Linux kernel.
> 
> Signed-off-by: Andreas Dannenberg 
> Signed-off-by: Lokesh Vutla 

Reviewed-by: Tom Rini 

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 15/25] power domain: Introduce TI System Control Interface (TI SCI) power domain driver

2018-08-21 Thread Lokesh Vutla
From: Andreas Dannenberg 

Some TI Keystone 2 and K3 family of SoCs contain a system controller
(like the Power Management Micro Controller (PMMC) on 66AK2G SoCs and
the Device Management and Security Controller on AM65x SoCs) that manage
the low-level device control (like clocks, resets etc) for the various
hardware modules present on the SoC. These device control operations are
provided to the host processor OS through a communication protocol
called the TI System Control Interface (TI SCI) protocol.

This patch adds a power domain driver that communicates to the system
controller over the TI SCI protocol for performing power management of
various devices present on the SoC. Various power domain functionalities
are achieved by the means of different TI SCI device operations provided
by the TI SCI framework.

This code is loosely based on the drivers/soc/ti/ti_sci_pm_domains.c
driver of the Linux kernel.

Signed-off-by: Andreas Dannenberg 
Signed-off-by: Lokesh Vutla 
---
 .../power/ti,sci-pm-domain.txt|  52 +
 drivers/power/domain/Kconfig  |   7 ++
 drivers/power/domain/Makefile |   1 +
 drivers/power/domain/ti-sci-power-domain.c| 107 ++
 4 files changed, 167 insertions(+)
 create mode 100644 doc/device-tree-bindings/power/ti,sci-pm-domain.txt
 create mode 100644 drivers/power/domain/ti-sci-power-domain.c

diff --git a/doc/device-tree-bindings/power/ti,sci-pm-domain.txt 
b/doc/device-tree-bindings/power/ti,sci-pm-domain.txt
new file mode 100644
index 00..0e190e20fe
--- /dev/null
+++ b/doc/device-tree-bindings/power/ti,sci-pm-domain.txt
@@ -0,0 +1,52 @@
+Texas Instruments TI SCI Generic Power Domain
+=
+
+Some TI SoCs contain a system controller (like the SYSFW, etc...) that is
+responsible for controlling the state of the IPs that are present.
+Communication between the host processor running an OS and the system
+controller happens through a protocol known as TI SCI [1].
+
+[1] http://processors.wiki.ti.com/index.php/TISCI
+
+PM Domain Node
+==
+The PM domain node represents the global PM domain managed by the SYSFW. 
Because
+this relies on the TI SCI protocol to communicate with the SYSFW it must be a
+child of the sysfw node.
+
+Required Properties:
+
+- compatible: Must be "ti,sci-pm-domain"
+- #power-domain-cells: Must be 1 so that an id can be provided in each
+  device node.
+
+Example (AM65x):
+
+   sysfw: sysfw {
+   compatible = "ti,am654-system-controller";
+   ...
+   k3_pds: power-controller {
+   compatible = "ti,sci-pm-domain";
+   #power-domain-cells = <1>;
+   };
+   };
+
+PM Domain Consumers
+===
+Hardware blocks belonging to a PM domain should contain a "power-domains"
+property that is a phandle pointing to the corresponding PM domain node
+along with an index representing the device id to be passed to the PMMC
+for device control.
+
+Required Properties:
+
+- power-domains: phandle pointing to the corresponding PM domain node
+and an ID representing the device.
+
+Example (AM65x):
+
+   uart2: serial@0280 {
+   compatible = "ti,omap4-uart";
+   ...
+   power-domains = <_pds 0x3f>;
+   };
diff --git a/drivers/power/domain/Kconfig b/drivers/power/domain/Kconfig
index 7cfa761498..80b0b48b0f 100644
--- a/drivers/power/domain/Kconfig
+++ b/drivers/power/domain/Kconfig
@@ -31,4 +31,11 @@ config TEGRA186_POWER_DOMAIN
  Enable support for manipulating Tegra's on-SoC power domains via IPC
  requests to the BPMP (Boot and Power Management Processor).
 
+config TI_SCI_POWER_DOMAIN
+   bool "Enable the TI SCI-based power domain driver"
+   depends on POWER_DOMAIN && TI_SCI_PROTOCOL
+   help
+ Generic power domain implementation for TI devices implementing the
+ TI SCI protocol.
+
 endmenu
diff --git a/drivers/power/domain/Makefile b/drivers/power/domain/Makefile
index 020eee2378..9c6399b722 100644
--- a/drivers/power/domain/Makefile
+++ b/drivers/power/domain/Makefile
@@ -7,3 +7,4 @@ obj-$(CONFIG_BCM6328_POWER_DOMAIN) += bcm6328-power-domain.o
 obj-$(CONFIG_SANDBOX_POWER_DOMAIN) += sandbox-power-domain.o
 obj-$(CONFIG_SANDBOX_POWER_DOMAIN) += sandbox-power-domain-test.o
 obj-$(CONFIG_TEGRA186_POWER_DOMAIN) += tegra186-power-domain.o
+obj-$(CONFIG_TI_SCI_POWER_DOMAIN) += ti-sci-power-domain.o
diff --git a/drivers/power/domain/ti-sci-power-domain.c 
b/drivers/power/domain/ti-sci-power-domain.c
new file mode 100644
index 00..aafde62cbf
--- /dev/null
+++ b/drivers/power/domain/ti-sci-power-domain.c
@@ -0,0 +1,107 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Texas Instruments System Control Interface (TI SCI) power domain driver
+ *
+ *