Re: [U-Boot] [PATCH 16/53] dtoc: Update Fdt.FromData() to allow a name

2019-07-29 Thread sjg
It is confusing when something goes wrong with a device tree which was
created from data rather than a file, since there is no identifying
filename. Add an option to provide this. Use the filename as the name,
where available

Signed-off-by: Simon Glass 
---

 tools/dtoc/fdt.py | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Applied to u-boot-dm, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 16/53] dtoc: Update Fdt.FromData() to allow a name

2019-07-20 Thread Simon Glass
It is confusing when something goes wrong with a device tree which was
created from data rather than a file, since there is no identifying
filename. Add an option to provide this. Use the filename as the name,
where available

Signed-off-by: Simon Glass 
---

 tools/dtoc/fdt.py | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/dtoc/fdt.py b/tools/dtoc/fdt.py
index 3870eb1fa1b..b341ef3f83b 100644
--- a/tools/dtoc/fdt.py
+++ b/tools/dtoc/fdt.py
@@ -498,29 +498,35 @@ class Fdt:
 Properties:
   fname: Filename of fdt
   _root: Root of device tree (a Node object)
+  name: Helpful name for this Fdt for the user (useful when creating the
+DT from data rather than a file)
 """
 def __init__(self, fname):
 self._fname = fname
 self._cached_offsets = False
 self.phandle_to_node = {}
+self.name = ''
 if self._fname:
+self.name = self._fname
 self._fname = fdt_util.EnsureCompiled(self._fname)
 
 with open(self._fname, 'rb') as fd:
 self._fdt_obj = libfdt.Fdt(fd.read())
 
 @staticmethod
-def FromData(data):
+def FromData(data, name=''):
 """Create a new Fdt object from the given data
 
 Args:
 data: Device-tree data blob
+name: Helpful name for this Fdt for the user
 
 Returns:
 Fdt object containing the data
 """
 fdt = Fdt(None)
 fdt._fdt_obj = libfdt.Fdt(bytes(data))
+fdt.name = name
 return fdt
 
 def LookupPhandle(self, phandle):
-- 
2.22.0.657.g960e92d24f-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot