Re: [U-Boot] [PATCH 18/30] i2c: add i2c deblock sequence before and after every mux config

2011-04-28 Thread Heiko Schocher
Hello Valentin,

Valentin Longchamp wrote:
 From: Stefan Bigler stefan.big...@keymile.com
 
 To make sure that the mux can be configured a deblocking sequence
 is done before the mux configuration. After the mux switch the new leaf
 of, the i2c tree must be again deblocked.
 
 Signed-off-by: Stefan Bigler stefan.big...@keymile.com
 Acked-by: Heiko Schocher h...@denx.de
 cc: Wolfgang Denk w...@denx.de
 cc: Detlev Zundel d...@denx.de
 cc: Prafulla Wadaskar prafu...@marvell.com
 cc: Valentin Longchamp valentin.longch...@keymile.com
 cc: Holger Brunck holger.bru...@keymile.com
 Signed-off-by: Valentin Longchamp valentin.longch...@keymile.com
 ---
  common/cmd_i2c.c |   12 
  include/i2c.h|2 --
  2 files changed, 12 insertions(+), 2 deletions(-)

Thanks! Applied to u-boot-i2c. As this patch is independent, it
must not be in a patchseries, so I applied it directly to the
i2c-tree.

bye,
Heiko
-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 18/30] i2c: add i2c deblock sequence before and after every mux config

2011-04-08 Thread Valentin Longchamp
From: Stefan Bigler stefan.big...@keymile.com

To make sure that the mux can be configured a deblocking sequence
is done before the mux configuration. After the mux switch the new leaf
of, the i2c tree must be again deblocked.

Signed-off-by: Stefan Bigler stefan.big...@keymile.com
Acked-by: Heiko Schocher h...@denx.de
cc: Wolfgang Denk w...@denx.de
cc: Detlev Zundel d...@denx.de
cc: Prafulla Wadaskar prafu...@marvell.com
cc: Valentin Longchamp valentin.longch...@keymile.com
cc: Holger Brunck holger.bru...@keymile.com
Signed-off-by: Valentin Longchamp valentin.longch...@keymile.com
---
 common/cmd_i2c.c |   12 
 include/i2c.h|2 --
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
index c272b0d..d913e13 100644
--- a/common/cmd_i2c.c
+++ b/common/cmd_i2c.c
@@ -132,6 +132,14 @@ DECLARE_GLOBAL_DATA_PTR;
 
 #define DISP_LINE_LEN  16
 
+/* implement possible board specific board init */
+void __def_i2c_init_board(void)
+{
+   return;
+}
+void i2c_init_board(void)
+   __attribute__((weak, alias(__def_i2c_init_board)));
+
 /* TODO: Implement architecture-specific get/set functions */
 unsigned int __def_i2c_get_bus_speed(void)
 {
@@ -1541,6 +1549,8 @@ int i2x_mux_select_mux(int bus)
 
mux = dev-mux;
while (mux != NULL) {
+   /* do deblocking on each level of mux, before mux config */
+   i2c_init_board();
if (i2c_write(mux-chip, 0, 0, mux-channel, 1) != 0) {
printf (Error setting Mux: chip:%x channel: \
%x\n, mux-chip, mux-channel);
@@ -1548,6 +1558,8 @@ int i2x_mux_select_mux(int bus)
}
mux = mux-next;
}
+   /* do deblocking on each level of mux and after mux config */
+   i2c_init_board();
return 0;
 }
 #endif /* CONFIG_I2C_MUX */
diff --git a/include/i2c.h b/include/i2c.h
index cd23c8a..8ceb4c8 100644
--- a/include/i2c.h
+++ b/include/i2c.h
@@ -108,9 +108,7 @@
  * repeatedly to change the speed and slave addresses.
  */
 void i2c_init(int speed, int slaveaddr);
-#ifdef CONFIG_SYS_I2C_INIT_BOARD
 void i2c_init_board(void);
-#endif
 #ifdef CONFIG_SYS_I2C_BOARD_LATE_INIT
 void i2c_board_late_init(void);
 #endif
-- 
1.7.0.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot