Re: [U-Boot] [PATCH 2/2] pinctrl: imx7ulp: Add new info instance for iomuxc1

[Stefano Babic]

On 14/08/2017 12:09, Peng Fan wrote:
> To i.MX7ULP, we need to create two info instances for
> iomux0 and iomux1 respectively, otherwise iomuxc0/1 will
> share one info instance and use one base, because imx_pinctrl_probe
> will use info to store base address and etc. But iomuxc0/1
> actually have different base address.
> 
> Signed-off-by: Peng Fan 
> Cc: Simon Glass 
> Cc: Stefano Babic 
> ---
>  drivers/pinctrl/nxp/pinctrl-imx7ulp.c | 10 +++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/nxp/pinctrl-imx7ulp.c 
> b/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
> index 4a893e5..618ce6a 100644
> --- a/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
> +++ b/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
> @@ -12,7 +12,11 @@
>  
>  #include "pinctrl-imx.h"
>  
> -static struct imx_pinctrl_soc_info imx7ulp_pinctrl_soc_info = {
> +static struct imx_pinctrl_soc_info imx7ulp_pinctrl_soc_info0 = {
> + .flags = ZERO_OFFSET_VALID | SHARE_MUX_CONF_REG | CONFIG_IBE_OBE,
> +};
> +
> +static struct imx_pinctrl_soc_info imx7ulp_pinctrl_soc_info1 = {
>   .flags = ZERO_OFFSET_VALID | SHARE_MUX_CONF_REG | CONFIG_IBE_OBE,
>  };
>  
> @@ -25,8 +29,8 @@ static int imx7ulp_pinctrl_probe(struct udevice *dev)
>  }
>  
>  static const struct udevice_id imx7ulp_pinctrl_match[] = {
> - { .compatible = "fsl,imx7ulp-iomuxc-0", .data = 
> (ulong)_pinctrl_soc_info },
> - { .compatible = "fsl,imx7ulp-iomuxc-1", .data = 
> (ulong)_pinctrl_soc_info },
> + { .compatible = "fsl,imx7ulp-iomuxc-0", .data = 
> (ulong)_pinctrl_soc_info0 },
> + { .compatible = "fsl,imx7ulp-iomuxc-1", .data = 
> (ulong)_pinctrl_soc_info1 },
>   { /* sentinel */ }
>  };
>  
> 
Applied to u-boot-imx, -master, thanks !

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/2] pinctrl: imx7ulp: Add new info instance for iomuxc1

[Peng Fan]

To i.MX7ULP, we need to create two info instances for
iomux0 and iomux1 respectively, otherwise iomuxc0/1 will
share one info instance and use one base, because imx_pinctrl_probe
will use info to store base address and etc. But iomuxc0/1
actually have different base address.

Signed-off-by: Peng Fan 
Cc: Simon Glass 
Cc: Stefano Babic 
---
 drivers/pinctrl/nxp/pinctrl-imx7ulp.c | 10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/nxp/pinctrl-imx7ulp.c 
b/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
index 4a893e5..618ce6a 100644
--- a/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
+++ b/drivers/pinctrl/nxp/pinctrl-imx7ulp.c
@@ -12,7 +12,11 @@
 
 #include "pinctrl-imx.h"
 
-static struct imx_pinctrl_soc_info imx7ulp_pinctrl_soc_info = {
+static struct imx_pinctrl_soc_info imx7ulp_pinctrl_soc_info0 = {
+   .flags = ZERO_OFFSET_VALID | SHARE_MUX_CONF_REG | CONFIG_IBE_OBE,
+};
+
+static struct imx_pinctrl_soc_info imx7ulp_pinctrl_soc_info1 = {
.flags = ZERO_OFFSET_VALID | SHARE_MUX_CONF_REG | CONFIG_IBE_OBE,
 };
 
@@ -25,8 +29,8 @@ static int imx7ulp_pinctrl_probe(struct udevice *dev)
 }
 
 static const struct udevice_id imx7ulp_pinctrl_match[] = {
-   { .compatible = "fsl,imx7ulp-iomuxc-0", .data = 
(ulong)_pinctrl_soc_info },
-   { .compatible = "fsl,imx7ulp-iomuxc-1", .data = 
(ulong)_pinctrl_soc_info },
+   { .compatible = "fsl,imx7ulp-iomuxc-0", .data = 
(ulong)_pinctrl_soc_info0 },
+   { .compatible = "fsl,imx7ulp-iomuxc-1", .data = 
(ulong)_pinctrl_soc_info1 },
{ /* sentinel */ }
 };
 
-- 
2.6.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot