Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Bin Meng 
Hi Andy,

On Sun, Jul 23, 2017 at 11:35 PM, Andy Shevchenko
 wrote:
> On Sun, Jul 23, 2017 at 4:33 PM, Bin Meng  wrote:
>> On Sun, Jul 23, 2017 at 8:51 PM, Andy Shevchenko
>>  wrote:
>>> On Sun, Jul 23, 2017 at 1:48 PM, Bin Meng  wrote:
 On Sun, Jul 23, 2017 at 6:36 PM, Andy Shevchenko
  wrote:
> On Sun, Jul 23, 2017 at 1:26 PM, Bin Meng  wrote:
>
>> Sure. Reword it as "Allow toolchains that are pre-configured to build
>> 32-bit codes to compile 64-bit U-Boot"?
>
> Hmm... The flag you are adding does enforce or allow?
> So, if -m64 will still allow to compile 32-bit code, then it's
> allowing, otherwise it's enforcing.
> Or I miss something?

 -m64 will only be passed to compiler when building source files that
 are part of 64-bit U-Boot. For 32-bit U-Boot, it is still -m32.
>>>
>>> Yes, what I'm trying to understand is
>>> 1. U-Boot is compiled _either_ 64-bit, _or_ 32-bit binary -- correct?
>>
>> 64-bit U-Boot image is a combination of 32-bit U-Boot (SPL) plus
>> 64-bit U-Boot (proper). For the U-Boot proper, it has be compiled with
>> 64-bit and currently -m64 is missing, primary due to the toolchain we
>> previously used has implicitly -m64 configured.
>
> Okay, thanks for patience and explanation.
>
> Can you somehow (partially) inject this into initial subject + commit message?

Yes, will do in v2.

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Andy Shevchenko 
On Sun, Jul 23, 2017 at 4:33 PM, Bin Meng  wrote:
> On Sun, Jul 23, 2017 at 8:51 PM, Andy Shevchenko
>  wrote:
>> On Sun, Jul 23, 2017 at 1:48 PM, Bin Meng  wrote:
>>> On Sun, Jul 23, 2017 at 6:36 PM, Andy Shevchenko
>>>  wrote:
 On Sun, Jul 23, 2017 at 1:26 PM, Bin Meng  wrote:

> Sure. Reword it as "Allow toolchains that are pre-configured to build
> 32-bit codes to compile 64-bit U-Boot"?

 Hmm... The flag you are adding does enforce or allow?
 So, if -m64 will still allow to compile 32-bit code, then it's
 allowing, otherwise it's enforcing.
 Or I miss something?
>>>
>>> -m64 will only be passed to compiler when building source files that
>>> are part of 64-bit U-Boot. For 32-bit U-Boot, it is still -m32.
>>
>> Yes, what I'm trying to understand is
>> 1. U-Boot is compiled _either_ 64-bit, _or_ 32-bit binary -- correct?
>
> 64-bit U-Boot image is a combination of 32-bit U-Boot (SPL) plus
> 64-bit U-Boot (proper). For the U-Boot proper, it has be compiled with
> 64-bit and currently -m64 is missing, primary due to the toolchain we
> previously used has implicitly -m64 configured.

Okay, thanks for patience and explanation.

Can you somehow (partially) inject this into initial subject + commit message?

-- 
With Best Regards,
Andy Shevchenko
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Bin Meng 
Hi Andy,

On Sun, Jul 23, 2017 at 8:51 PM, Andy Shevchenko
 wrote:
> On Sun, Jul 23, 2017 at 1:48 PM, Bin Meng  wrote:
>> On Sun, Jul 23, 2017 at 6:36 PM, Andy Shevchenko
>>  wrote:
>>> On Sun, Jul 23, 2017 at 1:26 PM, Bin Meng  wrote:
 On Sun, Jul 23, 2017 at 6:07 PM, Andy Shevchenko
  wrote:
>
 Sure. Reword it as "Allow toolchains that are pre-configured to build
 32-bit codes to compile 64-bit U-Boot"?
>>>
>>> Hmm... The flag you are adding does enforce or allow?
>>> So, if -m64 will still allow to compile 32-bit code, then it's
>>> allowing, otherwise it's enforcing.
>>> Or I miss something?
>>
>> -m64 will only be passed to compiler when building source files that
>> are part of 64-bit U-Boot. For 32-bit U-Boot, it is still -m32.
>
> Yes, what I'm trying to understand is
> 1. U-Boot is compiled _either_ 64-bit, _or_ 32-bit binary -- correct?

64-bit U-Boot image is a combination of 32-bit U-Boot (SPL) plus
64-bit U-Boot (proper). For the U-Boot proper, it has be compiled with
64-bit and currently -m64 is missing, primary due to the toolchain we
previously used has implicitly -m64 configured.

> 2. If above is correct then -m64 _enforces_ to compile it as 64-bit -- 
> correct?
>

Correct.

> Or I'm mistaken with the last and -m64 just adds a _preference_ to
> compile as 64-bit?
>

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Andy Shevchenko 
On Sun, Jul 23, 2017 at 1:48 PM, Bin Meng  wrote:
> On Sun, Jul 23, 2017 at 6:36 PM, Andy Shevchenko
>  wrote:
>> On Sun, Jul 23, 2017 at 1:26 PM, Bin Meng  wrote:
>>> On Sun, Jul 23, 2017 at 6:07 PM, Andy Shevchenko
>>>  wrote:

>>> Sure. Reword it as "Allow toolchains that are pre-configured to build
>>> 32-bit codes to compile 64-bit U-Boot"?
>>
>> Hmm... The flag you are adding does enforce or allow?
>> So, if -m64 will still allow to compile 32-bit code, then it's
>> allowing, otherwise it's enforcing.
>> Or I miss something?
>
> -m64 will only be passed to compiler when building source files that
> are part of 64-bit U-Boot. For 32-bit U-Boot, it is still -m32.

Yes, what I'm trying to understand is
1. U-Boot is compiled _either_ 64-bit, _or_ 32-bit binary -- correct?
2. If above is correct then -m64 _enforces_ to compile it as 64-bit -- correct?

Or I'm mistaken with the last and -m64 just adds a _preference_ to
compile as 64-bit?

-- 
With Best Regards,
Andy Shevchenko
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Bin Meng 
Hi Andy,

On Sun, Jul 23, 2017 at 6:36 PM, Andy Shevchenko
 wrote:
> On Sun, Jul 23, 2017 at 1:26 PM, Bin Meng  wrote:
>> On Sun, Jul 23, 2017 at 6:07 PM, Andy Shevchenko
>>  wrote:
>>> On Sun, Jul 23, 2017 at 1:05 PM, Bin Meng  wrote:
 On Sun, Jul 23, 2017 at 6:01 PM, Andy Shevchenko
  wrote:
> On Sun, Jul 23, 2017 at 12:37 PM, Bin Meng  wrote:
>>>
> The subject is a bit cofusing. As I read (and as I understand) we need
> to have 64-bit toolchain available (multilib package and so on).
> Basically what you do is "enforcing 64-bit toolchain to be used". Right?
>

 Yes, multilib package is required for 64-bit toolchain to build 32-bit
 U-Boot. Maybe the confusion comes from what we call 32-bit/64-bit
 toolchains. Or maybe we should call it pre-configured toolchain for
 building 32-bit/64-bit codes? The issue is when using kernel.org
 i386-linux-gcc to build qemu-x86_64_defconfig (64-bit U-Boot), the
 issue is seen. It's because the i386-linux-gcc is pre-configured with
 '-m32' which is for building 32-bit codes.
>>>
>>> My point is that subject (and maybe commit message) should be massaged
>>> a bit to avoid confusion.
>>>
>>
>> Sure. Reword it as "Allow toolchains that are pre-configured to build
>> 32-bit codes to compile 64-bit U-Boot"?
>
> Hmm... The flag you are adding does enforce or allow?
> So, if -m64 will still allow to compile 32-bit code, then it's
> allowing, otherwise it's enforcing.
> Or I miss something?

-m64 will only be passed to compiler when building source files that
are part of 64-bit U-Boot. For 32-bit U-Boot, it is still -m32.

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Andy Shevchenko 
On Sun, Jul 23, 2017 at 1:26 PM, Bin Meng  wrote:
> On Sun, Jul 23, 2017 at 6:07 PM, Andy Shevchenko
>  wrote:
>> On Sun, Jul 23, 2017 at 1:05 PM, Bin Meng  wrote:
>>> On Sun, Jul 23, 2017 at 6:01 PM, Andy Shevchenko
>>>  wrote:
 On Sun, Jul 23, 2017 at 12:37 PM, Bin Meng  wrote:
>>
 The subject is a bit cofusing. As I read (and as I understand) we need
 to have 64-bit toolchain available (multilib package and so on).
 Basically what you do is "enforcing 64-bit toolchain to be used". Right?

>>>
>>> Yes, multilib package is required for 64-bit toolchain to build 32-bit
>>> U-Boot. Maybe the confusion comes from what we call 32-bit/64-bit
>>> toolchains. Or maybe we should call it pre-configured toolchain for
>>> building 32-bit/64-bit codes? The issue is when using kernel.org
>>> i386-linux-gcc to build qemu-x86_64_defconfig (64-bit U-Boot), the
>>> issue is seen. It's because the i386-linux-gcc is pre-configured with
>>> '-m32' which is for building 32-bit codes.
>>
>> My point is that subject (and maybe commit message) should be massaged
>> a bit to avoid confusion.
>>
>
> Sure. Reword it as "Allow toolchains that are pre-configured to build
> 32-bit codes to compile 64-bit U-Boot"?

Hmm... The flag you are adding does enforce or allow?
So, if -m64 will still allow to compile 32-bit code, then it's
allowing, otherwise it's enforcing.
Or I miss something?

-- 
With Best Regards,
Andy Shevchenko
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Bin Meng 
Hi Andy,

On Sun, Jul 23, 2017 at 6:07 PM, Andy Shevchenko
 wrote:
> On Sun, Jul 23, 2017 at 1:05 PM, Bin Meng  wrote:
>> On Sun, Jul 23, 2017 at 6:01 PM, Andy Shevchenko
>>  wrote:
>>> On Sun, Jul 23, 2017 at 12:37 PM, Bin Meng  wrote:
>
>>> The subject is a bit cofusing. As I read (and as I understand) we need
>>> to have 64-bit toolchain available (multilib package and so on).
>>> Basically what you do is "enforcing 64-bit toolchain to be used". Right?
>>>
>>
>> Yes, multilib package is required for 64-bit toolchain to build 32-bit
>> U-Boot. Maybe the confusion comes from what we call 32-bit/64-bit
>> toolchains. Or maybe we should call it pre-configured toolchain for
>> building 32-bit/64-bit codes? The issue is when using kernel.org
>> i386-linux-gcc to build qemu-x86_64_defconfig (64-bit U-Boot), the
>> issue is seen. It's because the i386-linux-gcc is pre-configured with
>> '-m32' which is for building 32-bit codes.
>
> My point is that subject (and maybe commit message) should be massaged
> a bit to avoid confusion.
>

Sure. Reword it as "Allow toolchains that are pre-configured to build
32-bit codes to compile 64-bit U-Boot"?

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Andy Shevchenko 
On Sun, Jul 23, 2017 at 1:05 PM, Bin Meng  wrote:
> On Sun, Jul 23, 2017 at 6:01 PM, Andy Shevchenko
>  wrote:
>> On Sun, Jul 23, 2017 at 12:37 PM, Bin Meng  wrote:

>> The subject is a bit cofusing. As I read (and as I understand) we need
>> to have 64-bit toolchain available (multilib package and so on).
>> Basically what you do is "enforcing 64-bit toolchain to be used". Right?
>>
>
> Yes, multilib package is required for 64-bit toolchain to build 32-bit
> U-Boot. Maybe the confusion comes from what we call 32-bit/64-bit
> toolchains. Or maybe we should call it pre-configured toolchain for
> building 32-bit/64-bit codes? The issue is when using kernel.org
> i386-linux-gcc to build qemu-x86_64_defconfig (64-bit U-Boot), the
> issue is seen. It's because the i386-linux-gcc is pre-configured with
> '-m32' which is for building 32-bit codes.

My point is that subject (and maybe commit message) should be massaged
a bit to avoid confusion.

-- 
With Best Regards,
Andy Shevchenko
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Bin Meng 
Hi Andy,

On Sun, Jul 23, 2017 at 6:01 PM, Andy Shevchenko
 wrote:
> On Sun, Jul 23, 2017 at 12:37 PM, Bin Meng  wrote:
>> Attempting to use a 32-bit toolchain (eg: kernel.org 4.9
>> i386-linux-gcc) to compile 64-bit U-Boot (qemu-x86_64_defconfig)
>> fails with the following errors:
>>
>>   arch/x86/cpu/intel_common/microcode.c:79:2: error: PIC register
>>   clobbered by 'ebx' in 'asm'
>>
>> The issue is with 32-bit toolchain compiling sources for 64-bit.
>> Using a 64-bit toolchain (eg: kernel.org 4.9 x86_64-linux-gcc)
>> works out of the box. When compiling sources for 32-bit, '-m32' is
>> passed to the toolchain (no matter it's 32-bit or 64-bit).
>>
>> Now do the same thing, passing '-m64' to the toolchain for 64-bit
>> sources build.
>>
>
> The subject is a bit cofusing. As I read (and as I understand) we need
> to have 64-bit toolchain available (multilib package and so on).
> Basically what you do is "enforcing 64-bit toolchain to be used". Right?
>

Yes, multilib package is required for 64-bit toolchain to build 32-bit
U-Boot. Maybe the confusion comes from what we call 32-bit/64-bit
toolchains. Or maybe we should call it pre-configured toolchain for
building 32-bit/64-bit codes? The issue is when using kernel.org
i386-linux-gcc to build qemu-x86_64_defconfig (64-bit U-Boot), the
issue is seen. It's because the i386-linux-gcc is pre-configured with
'-m32' which is for building 32-bit codes.

>> Signed-off-by: Bin Meng 
>> ---
>>
>>  arch/x86/config.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>

Regards,
Bin
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Andy Shevchenko 
On Sun, Jul 23, 2017 at 12:37 PM, Bin Meng  wrote:
> Attempting to use a 32-bit toolchain (eg: kernel.org 4.9
> i386-linux-gcc) to compile 64-bit U-Boot (qemu-x86_64_defconfig)
> fails with the following errors:
>
>   arch/x86/cpu/intel_common/microcode.c:79:2: error: PIC register
>   clobbered by 'ebx' in 'asm'
>
> The issue is with 32-bit toolchain compiling sources for 64-bit.
> Using a 64-bit toolchain (eg: kernel.org 4.9 x86_64-linux-gcc)
> works out of the box. When compiling sources for 32-bit, '-m32' is
> passed to the toolchain (no matter it's 32-bit or 64-bit).
>
> Now do the same thing, passing '-m64' to the toolchain for 64-bit
> sources build.
>

The subject is a bit cofusing. As I read (and as I understand) we need
to have 64-bit toolchain available (multilib package and so on).
Basically what you do is "enforcing 64-bit toolchain to be used". Right?

> Signed-off-by: Bin Meng 
> ---
>
>  arch/x86/config.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/config.mk b/arch/x86/config.mk
> index 043425e..8835dcf 100644
> --- a/arch/x86/config.mk
> +++ b/arch/x86/config.mk
> @@ -26,7 +26,7 @@ endif
>  ifeq ($(IS_32BIT),y)
>  PLATFORM_CPPFLAGS += -march=i386 -m32
>  else
> -PLATFORM_CPPFLAGS += $(if $(CONFIG_SPL_BUILD),,-fpic) -fno-common
> +PLATFORM_CPPFLAGS += $(if $(CONFIG_SPL_BUILD),,-fpic) -fno-common -m64
>  endif
>
>  PLATFORM_RELFLAGS += -ffunction-sections -fvisibility=hidden
> --
> 2.9.2
>
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot



-- 
With Best Regards,
Andy Shevchenko
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/2] x86: Allow 32-bit toolchain to compile 64-bit U-Boot

2017-07-23 Thread Bin Meng 
Attempting to use a 32-bit toolchain (eg: kernel.org 4.9
i386-linux-gcc) to compile 64-bit U-Boot (qemu-x86_64_defconfig)
fails with the following errors:

  arch/x86/cpu/intel_common/microcode.c:79:2: error: PIC register
  clobbered by 'ebx' in 'asm'

The issue is with 32-bit toolchain compiling sources for 64-bit.
Using a 64-bit toolchain (eg: kernel.org 4.9 x86_64-linux-gcc)
works out of the box. When compiling sources for 32-bit, '-m32' is
passed to the toolchain (no matter it's 32-bit or 64-bit).

Now do the same thing, passing '-m64' to the toolchain for 64-bit
sources build.

Signed-off-by: Bin Meng 
---

 arch/x86/config.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/config.mk b/arch/x86/config.mk
index 043425e..8835dcf 100644
--- a/arch/x86/config.mk
+++ b/arch/x86/config.mk
@@ -26,7 +26,7 @@ endif
 ifeq ($(IS_32BIT),y)
 PLATFORM_CPPFLAGS += -march=i386 -m32
 else
-PLATFORM_CPPFLAGS += $(if $(CONFIG_SPL_BUILD),,-fpic) -fno-common
+PLATFORM_CPPFLAGS += $(if $(CONFIG_SPL_BUILD),,-fpic) -fno-common -m64
 endif
 
 PLATFORM_RELFLAGS += -ffunction-sections -fvisibility=hidden
-- 
2.9.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot