subject:"\[U\-Boot\] \[PATCH 2\/3\] ARMv8\/layerscape\: Add FSL PPA support"

Re: [U-Boot] [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support

2016-01-20 Thread Zhiqiang Hou

Hi Prabhakar,

Thanks for your feedback!

> -Original Message-
> From: Prabhakar Kushwaha
> Sent: 2016年1月19日 22:07
> To: Zhiqiang Hou ; u-boot@lists.denx.de;
> albert.u.b...@aribaud.net; mingkai...@freescale.com; york...@freescale.com
> Cc: le...@freescale.com; prabha...@freescale.com;
> bhupesh.sha...@freescale.com; s...@chromium.org; bmeng...@gmail.com;
> h...@denx.de; joe.hershber...@ni.com; ma...@denx.de; Zhiqiang Hou
> ; Hou Zhiqiang 
> Subject: RE: [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support
> 
> > -Original Message-
> > From: Zhiqiang Hou [mailto:zhiqiang@freescale.com]
> > Sent: Tuesday, January 19, 2016 6:10 PM
> > To: u-boot@lists.denx.de; albert.u.b...@aribaud.net;
> > mingkai...@freescale.com; york...@freescale.com
> > Cc: le...@freescale.com; prabha...@freescale.com;
> > bhupesh.sha...@freescale.com; s...@chromium.org; bmeng...@gmail.com;
> > h...@denx.de; joe.hershber...@ni.com; ma...@denx.de; Zhiqiang Hou
> > ; Hou Zhiqiang 
> > Subject: [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support
> >
> > From: Hou Zhiqiang 
> >
> > The FSL Primary Protected Application (PPA) is a software component
> > loaded during boot which runs in TrustZone and remains resident after boot.
> >
> > Signed-off-by: Hou Zhiqiang 
> > ---
> >  arch/arm/cpu/armv8/fsl-layerscape/Makefile |   1 +
> >  arch/arm/cpu/armv8/fsl-layerscape/ppa.c| 196
> > +
> >  arch/arm/cpu/armv8/fsl-layerscape/ppa_entry.S  |  37 +
> > arch/arm/include/asm/arch-fsl-layerscape/ppa.h |  15 ++
> >  4 files changed, 249 insertions(+)
> >  create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ppa.c
> >  create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ppa_entry.S
> >  create mode 100644 arch/arm/include/asm/arch-fsl-layerscape/ppa.h
> >
> > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> > b/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> > index cce7405..27bfeb1 100644
> > --- a/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> > +++ b/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> > @@ -10,6 +10,7 @@ obj-y += soc.o
> >  obj-$(CONFIG_MP) += mp.o
> >  obj-$(CONFIG_OF_LIBFDT) += fdt.o
> >  obj-$(CONFIG_SPL) += spl.o
> > +obj-$(CONFIG_FSL_LS_PPA) += ppa.o ppa_entry.o
> >
> >  ifneq ($(CONFIG_FSL_LSCH3),)
> >  obj-y += fsl_lsch3_speed.o
> > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
> > b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
> > new file mode 100644
> > index 000..15e4f8b
> > --- /dev/null
> > +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
> > @@ -0,0 +1,196 @@
> > +/*
> > + * Copyright 2015 Freescale Semiconductor, Inc.
> > + *
> > + * SPDX-License-Identifier:GPL-2.0+
> > + */
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +extern void c_runtime_cpu_setup(void);
> > +
> > +#define LS_PPA_FIT_FIRMWARE_IMAGE  "firmware"
> > +#define LS_PPA_FIT_CNF_NAME"config@1"
> > +#define PPA_MEM_SIZE_ENV_VAR   "ppamemsize"
> > +
> > +/*
> 
> 
> 
> 
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +
> > +ADDR_BASE_SCFG:
> > +.long  0x0157
> 
> If I am correct it is address of BOOLPTR. This address looks to be specific to
> LS1043.
> For other SoC it may change
> 

Yes, I will make it a common interface for ARMv8 Layerscape platform in next 
version.

> 
> > +
> > +ENTRY(ppa_init)
> > +/* Save stack pointer for EL2 */
> > +mov x1, sp
> > +msr sp_el2, x1
> > +
> > +/* Set boot loc pointer */
> > +adr  x4, 1f
> > +adr  x1, ADDR_BASE_SCFG
> > +ldr  w2, [x1]
> > +mov  x1, x4
> > +rev  w3, w1
> > +str  w3, [x2, #0x604]
> 
> It is LS1043 specific
> 
> 
> > +lsr  x1, x4, #32
> > +rev  w3, w1
> > +str  w3, [x2, #0x600]
> Same as above
> 

Thanks,
Zhiqiang
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support

2016-01-19 Thread Zhiqiang Hou

From: Hou Zhiqiang 

The FSL Primary Protected Application (PPA) is a software component
loaded during boot which runs in TrustZone and remains resident
after boot.

Signed-off-by: Hou Zhiqiang 
---
 arch/arm/cpu/armv8/fsl-layerscape/Makefile |   1 +
 arch/arm/cpu/armv8/fsl-layerscape/ppa.c| 196 +
 arch/arm/cpu/armv8/fsl-layerscape/ppa_entry.S  |  37 +
 arch/arm/include/asm/arch-fsl-layerscape/ppa.h |  15 ++
 4 files changed, 249 insertions(+)
 create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ppa.c
 create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ppa_entry.S
 create mode 100644 arch/arm/include/asm/arch-fsl-layerscape/ppa.h

diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Makefile 
b/arch/arm/cpu/armv8/fsl-layerscape/Makefile
index cce7405..27bfeb1 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/Makefile
+++ b/arch/arm/cpu/armv8/fsl-layerscape/Makefile
@@ -10,6 +10,7 @@ obj-y += soc.o
 obj-$(CONFIG_MP) += mp.o
 obj-$(CONFIG_OF_LIBFDT) += fdt.o
 obj-$(CONFIG_SPL) += spl.o
+obj-$(CONFIG_FSL_LS_PPA) += ppa.o ppa_entry.o
 
 ifneq ($(CONFIG_FSL_LSCH3),)
 obj-y += fsl_lsch3_speed.o
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c 
b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
new file mode 100644
index 000..15e4f8b
--- /dev/null
+++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
@@ -0,0 +1,196 @@
+/*
+ * Copyright 2015 Freescale Semiconductor, Inc.
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+DECLARE_GLOBAL_DATA_PTR;
+
+extern void c_runtime_cpu_setup(void);
+
+#define LS_PPA_FIT_FIRMWARE_IMAGE  "firmware"
+#define LS_PPA_FIT_CNF_NAME"config@1"
+#define PPA_MEM_SIZE_ENV_VAR   "ppamemsize"
+
+/*
+ * Return the actual size of the PPA private DRAM block.
+ */
+unsigned long ppa_get_dram_block_size(void)
+{
+   unsigned long dram_block_size = CONFIG_SYS_LS_PPA_DRAM_BLOCK_MIN_SIZE;
+
+   char *dram_block_size_env_var = getenv(PPA_MEM_SIZE_ENV_VAR);
+
+   if (dram_block_size_env_var) {
+   dram_block_size = simple_strtoul(dram_block_size_env_var, NULL,
+10);
+
+   if (dram_block_size < CONFIG_SYS_LS_PPA_DRAM_BLOCK_MIN_SIZE) {
+   printf("fsl-ppa: WARNING: Invalid value for \'"
+  PPA_MEM_SIZE_ENV_VAR
+  "\' environment variable: %lu\n",
+  dram_block_size);
+
+   dram_block_size = CONFIG_SYS_LS_PPA_DRAM_BLOCK_MIN_SIZE;
+   }
+   }
+
+   return dram_block_size;
+}
+
+/*
+ * PPA firmware FIT image parser checks if the image is in FIT
+ * format, verifies integrity of the image and calculates raw
+ * image address and size values.
+ *
+ * Returns 0 on success and a negative errno on error task fail.
+ */
+static int parse_ppa_firmware_fit_image(const void **raw_image_addr,
+   size_t *raw_image_size)
+{
+   const void *ppa_data;
+   size_t ppa_size;
+   void *fit_hdr;
+   int conf_node_off, fw_node_off;
+   char *conf_node_name = NULL;
+
+#ifdef CONFIG_SYS_LS_PPA_FW_IN_NOR
+   fit_hdr = (void *)CONFIG_SYS_LS_PPA_FW_ADDR;
+#else
+#error "No CONFIG_SYS_LS_PPA_FW_IN_xxx defined"
+#endif
+
+   conf_node_name = LS_PPA_FIT_CNF_NAME;
+
+   if (fdt_check_header(fit_hdr)) {
+   printf("fsl-ppa: Bad firmware image (not a FIT image)\n");
+   return -EINVAL;
+   }
+
+   if (!fit_check_format(fit_hdr)) {
+   printf("fsl-ppa: Bad firmware image (bad FIT header)\n");
+   return -EINVAL;
+   }
+
+   conf_node_off = fit_conf_get_node(fit_hdr, conf_node_name);
+   if (conf_node_off < 0) {
+   printf("fsl-ppa: %s: no such config\n", conf_node_name);
+   return -ENOENT;
+   }
+
+   fw_node_off = fit_conf_get_prop_node(fit_hdr, conf_node_off,
+   LS_PPA_FIT_FIRMWARE_IMAGE);
+   if (fw_node_off < 0) {
+   printf("fsl-ppa: No '%s' in config\n",
+   LS_PPA_FIT_FIRMWARE_IMAGE);
+   return -ENOLINK;
+   }
+
+   /* Verify PPA firmware image */
+   if (!(fit_image_verify(fit_hdr, fw_node_off))) {
+   printf("fsl-ppa: Bad firmware image (bad CRC)\n");
+   return -EINVAL;
+   }
+
+   if (fit_image_get_data(fit_hdr, fw_node_off, _data, _size)) {
+   printf("fsl-ppa: Can't get %s subimage data/size",
+   LS_PPA_FIT_FIRMWARE_IMAGE);
+   return -ENOENT;
+   }
+
+   debug("fsl-ppa: raw_image_addr = %p, raw_image_size = 0x%lx\n",
+   ppa_data, ppa_size);
+   *raw_image_addr = ppa_data;
+   *raw_image_size = ppa_size;
+
+

Re: [U-Boot] [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support

2016-01-19 Thread Prabhakar Kushwaha

> -Original Message-
> From: Zhiqiang Hou [mailto:zhiqiang@freescale.com]
> Sent: Tuesday, January 19, 2016 6:10 PM
> To: u-boot@lists.denx.de; albert.u.b...@aribaud.net;
> mingkai...@freescale.com; york...@freescale.com
> Cc: le...@freescale.com; prabha...@freescale.com;
> bhupesh.sha...@freescale.com; s...@chromium.org;
> bmeng...@gmail.com; h...@denx.de; joe.hershber...@ni.com;
> ma...@denx.de; Zhiqiang Hou ; Hou Zhiqiang
> 
> Subject: [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support
> 
> From: Hou Zhiqiang 
> 
> The FSL Primary Protected Application (PPA) is a software component loaded
> during boot which runs in TrustZone and remains resident after boot.
> 
> Signed-off-by: Hou Zhiqiang 
> ---
>  arch/arm/cpu/armv8/fsl-layerscape/Makefile |   1 +
>  arch/arm/cpu/armv8/fsl-layerscape/ppa.c| 196
> +
>  arch/arm/cpu/armv8/fsl-layerscape/ppa_entry.S  |  37 +
> arch/arm/include/asm/arch-fsl-layerscape/ppa.h |  15 ++
>  4 files changed, 249 insertions(+)
>  create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ppa.c
>  create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ppa_entry.S
>  create mode 100644 arch/arm/include/asm/arch-fsl-layerscape/ppa.h
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> b/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> index cce7405..27bfeb1 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/Makefile
> @@ -10,6 +10,7 @@ obj-y += soc.o
>  obj-$(CONFIG_MP) += mp.o
>  obj-$(CONFIG_OF_LIBFDT) += fdt.o
>  obj-$(CONFIG_SPL) += spl.o
> +obj-$(CONFIG_FSL_LS_PPA) += ppa.o ppa_entry.o
> 
>  ifneq ($(CONFIG_FSL_LSCH3),)
>  obj-y += fsl_lsch3_speed.o
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
> b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
> new file mode 100644
> index 000..15e4f8b
> --- /dev/null
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/ppa.c
> @@ -0,0 +1,196 @@
> +/*
> + * Copyright 2015 Freescale Semiconductor, Inc.
> + *
> + * SPDX-License-Identifier:  GPL-2.0+
> + */
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +extern void c_runtime_cpu_setup(void);
> +
> +#define LS_PPA_FIT_FIRMWARE_IMAGE"firmware"
> +#define LS_PPA_FIT_CNF_NAME  "config@1"
> +#define PPA_MEM_SIZE_ENV_VAR "ppamemsize"
> +
> +/*




> +#include 
> +#include 
> +#include 
> +#include 
> +
> +ADDR_BASE_SCFG:
> +.long  0x0157

If I am correct it is address of BOOLPTR. This address looks to be specific to 
LS1043. 
For other SoC it may change


> +
> +ENTRY(ppa_init)
> +/* Save stack pointer for EL2 */
> +mov x1, sp
> +msr sp_el2, x1
> +
> +/* Set boot loc pointer */
> +adr  x4, 1f
> +adr  x1, ADDR_BASE_SCFG
> +ldr  w2, [x1]
> +mov  x1, x4
> +rev  w3, w1
> +str  w3, [x2, #0x604]

It is LS1043 specific


> +lsr  x1, x4, #32
> +rev  w3, w1
> +str  w3, [x2, #0x600]
Same as above

--prabhakar
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support

[U-Boot] [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support

Re: [U-Boot] [PATCH 2/3] ARMv8/layerscape: Add FSL PPA support

3 matches

Site Navigation

Mail list logo

Footer information